[GitHub] tinkerpop issue #792: TINKERPOP-1854 Add Lambdas for Gremlin.Net

Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/792 Since I also don't have a strong opinion on that matter, I just went ahead and only introduced the `ILambda` interface to make the implementation internal as you suggested. ---

[jira] [Commented] (TINKERPOP-1854) Support lambdas in Gremlin.Net

[ https://issues.apache.org/jira/browse/TINKERPOP-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400908#comment-16400908 ] ASF GitHub Bot commented on TINKERPOP-1854: --- Github user FlorianHockmann commented on the

[GitHub] tinkerpop pull request #817: TINKERPOP-1920 Fixed P.within/without() handlin...

GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/817 TINKERPOP-1920 Fixed P.within/without() handling for collections https://issues.apache.org/jira/browse/TINKERPOP-1920 Made the logic the same as what we have in Java currently for

[jira] [Commented] (TINKERPOP-1920) Tests fail because P.Within() arguments are wrapped in an array in Gremlin.Net

[ https://issues.apache.org/jira/browse/TINKERPOP-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400678#comment-16400678 ] ASF GitHub Bot commented on TINKERPOP-1920: --- GitHub user spmallette opened a pull request:

[jira] [Commented] (TINKERPOP-1922) Gherkin features fail that contain P.not() in Gremlin.Net

[ https://issues.apache.org/jira/browse/TINKERPOP-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400519#comment-16400519 ] Florian Hockmann commented on TINKERPOP-1922: - D'OH, so I guess that I just tested with an

[jira] [Closed] (TINKERPOP-1922) Gherkin features fail that contain P.not() in Gremlin.Net

[ https://issues.apache.org/jira/browse/TINKERPOP-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1922. --- Resolution: Fixed Assignee: stephen mallette Verified that this was resolve

Re: [DISCUSS] JIRA Issues in Commits

GitHub interface gets me to the PR if there was a PR. I guess that didn't help me yesterday for a CTR'd commit that I was pretty certain had a JIRA associated to it. Anyway, it's just a suggestion for committers - no big deal from me right now if you cant get in the rhythm of doing it. On Thu,

[jira] [Commented] (TINKERPOP-1854) Support lambdas in Gremlin.Net

[ https://issues.apache.org/jira/browse/TINKERPOP-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400114#comment-16400114 ] ASF GitHub Bot commented on TINKERPOP-1854: --- Github user jorgebay commented on the issue:

[jira] [Commented] (TINKERPOP-1854) Support lambdas in Gremlin.Net

[ https://issues.apache.org/jira/browse/TINKERPOP-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400113#comment-16400113 ] ASF GitHub Bot commented on TINKERPOP-1854: --- Github user FlorianHockmann commented on the

[GitHub] tinkerpop issue #792: TINKERPOP-1854 Add Lambdas for Gremlin.Net

Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/792 I would prefer a generic `ILambda` for string based lambdas (groovy and python) but I don't have an strong opinion about it. ---

Re: [DISCUSS] JIRA Issues in Commits

I wouldn't like to enforce it for commits that are part of the pull request review flow, I think it would be a burden for new contributors. To track the origin of a commit we can always look on Github web interface (at the top of the commit). For example: this commit

[GitHub] tinkerpop issue #792: TINKERPOP-1854 Add Lambdas for Gremlin.Net

Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/792 > Can we make Lambda class static and make the Lambda.Groovy() and Lambda.Python() return an ILambda interface? Sure, making the implementation internal makes perfect sense to me.

[jira] [Commented] (TINKERPOP-1854) Support lambdas in Gremlin.Net

[ https://issues.apache.org/jira/browse/TINKERPOP-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400093#comment-16400093 ] ASF GitHub Bot commented on TINKERPOP-1854: --- Github user jorgebay commented on the issue:

[GitHub] tinkerpop issue #792: TINKERPOP-1854 Add Lambdas for Gremlin.Net

Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/792 The implementation looks great and the final `GraphTraversal` and `GraphTraversalSource` APIs make a lot of sense, like: ```csharp public GraphTraversal Branch (IFunction

[jira] [Commented] (TINKERPOP-1897) Provide Docker images of Gremlin Server and Console

[ https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400074#comment-16400074 ] ASF GitHub Bot commented on TINKERPOP-1897: --- Github user FlorianHockmann commented on the

[GitHub] tinkerpop issue #802: Add docker images for console and server TINKERPOP-189...

Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/802 I'm ok with merging this after the next release. Starting with a release candidate first like we usually do for GLVs makes sense in my opinion. Then we can also deal with things like the