[
https://issues.apache.org/jira/browse/TINKERPOP-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476433#comment-16476433
]
ASF GitHub Bot commented on TINKERPOP-1962:
---
Github user dkuppitz commented on the issue:
[
https://issues.apache.org/jira/browse/TINKERPOP-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476429#comment-16476429
]
ASF GitHub Bot commented on TINKERPOP-1913:
---
Github user ashwini-ms commented on the issue:
Github user ashwini-ms commented on the issue:
https://github.com/apache/tinkerpop/pull/868
Thanks a lot !!
From: stephen mallette
Sent: Tuesday, May 15, 2018 12:42 PM
To: apache/tinkerpop
Cc: Ashwini Singh
[
https://issues.apache.org/jira/browse/TINKERPOP-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1841.
---
Resolution: Done
Assignee: stephen mallette
Fix Version/s: 3.2.10
[
https://issues.apache.org/jira/browse/TINKERPOP-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476387#comment-16476387
]
ASF GitHub Bot commented on TINKERPOP-1841:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/869
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476385#comment-16476385
]
ASF GitHub Bot commented on TINKERPOP-1913:
---
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/868
btw, we really need to rebase the TINKERPOP-1913 branch so that it can get
up to the 3.3.4-SNAPSHOT. I'll handle that on merge.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/868
Thanks for submitting this. I'll let @jorgebay and @FlorianHockmann provide
their reviews first as they know their way around the C# better than I.
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/868#discussion_r188410231
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientTests.cs ---
@@ -167,6 +168,25 @@ public class GremlinClientTests
[
https://issues.apache.org/jira/browse/TINKERPOP-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476369#comment-16476369
]
ASF GitHub Bot commented on TINKERPOP-1841:
---
Github user robertdale commented on the issue:
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/869
VOTE +1
---
Github user danielcweber commented on the issue:
https://github.com/apache/tinkerpop/pull/842
An explicit reference from the unit test project seems to do the trick.
Still unclear what depends on 9.0.0 though...
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476019#comment-16476019
]
ASF GitHub Bot commented on TINKERPOP-1945:
---
Github user danielcweber commented on the
[
https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475981#comment-16475981
]
ASF GitHub Bot commented on TINKERPOP-1945:
---
Github user danielcweber commented on the
Github user danielcweber commented on the issue:
https://github.com/apache/tinkerpop/pull/842
>Did you modify your Nuget.config? It's possible to specify there that
Nuget should always take the highest version.
No, haven't bothered with nuget.configs since .net core came
[
https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475975#comment-16475975
]
ASF GitHub Bot commented on TINKERPOP-1945:
---
Github user FlorianHockmann commented on the
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/842
Yeah, I also did a quick search but only found dependencies like >= 9.0.0.
> but I'm puzzled why it runs locally
Did you modify your Nuget.config? It's possible to
[
https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475951#comment-16475951
]
ASF GitHub Bot commented on TINKERPOP-1945:
---
Github user danielcweber commented on the
Github user danielcweber commented on the issue:
https://github.com/apache/tinkerpop/pull/842
I might force a dependency on 11.0.0 from the unit test project itself, but
I'm puzzled why it runs locally (same resolution logic should apply here), and
the project explicitly depending on
[
https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475878#comment-16475878
]
ASF GitHub Bot commented on TINKERPOP-1945:
---
Github user FlorianHockmann commented on the
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/842
Probably one of the dependencies of the project has in turn a dependency on
Newtonsoft.Json and wants explicitly version 9 of it and not some higher
version. [The
[
https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475766#comment-16475766
]
ASF GitHub Bot commented on TINKERPOP-1945:
---
Github user danielcweber commented on the
Github user danielcweber commented on the issue:
https://github.com/apache/tinkerpop/pull/842
There we go, a force downgrade of Newtonsoft.Json:
https://travis-ci.org/apache/tinkerpop/jobs/379192651#L4033
@spmallette Could you have a look at it?
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475743#comment-16475743
]
ASF GitHub Bot commented on TINKERPOP-1945:
---
Github user danielcweber commented on the
Github user danielcweber commented on the issue:
https://github.com/apache/tinkerpop/pull/842
It seems that the tests actually deploy a Newtonsoft.Json-dll that is
portable and doesn't include the BigInteger support...which is odd since
Gremlin.net's target is netstandard1.3 and the
[
https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475739#comment-16475739
]
ASF GitHub Bot commented on TINKERPOP-1945:
---
Github user danielcweber commented on the
Github user danielcweber commented on the issue:
https://github.com/apache/tinkerpop/pull/842
I can't really explain the build failure, the failing test runs just fine
locally with an updated Newtonsoft.Json, is the package somehow
force-downgraded?
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475645#comment-16475645
]
ASF GitHub Bot commented on TINKERPOP-1945:
---
Github user danielcweber commented on the
Github user danielcweber commented on the issue:
https://github.com/apache/tinkerpop/pull/842
So on the .net side, that would not be more than a string?
---
30 matches
Mail list logo