[GitHub] tinkerpop pull request #921: Add self loop example to Cycle Detection recipe...

2018-08-27 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/921#discussion_r213148817 --- Diff: docs/src/recipes/cycle-detection.asciidoc --- @@ -48,6 +48,31 @@ the length of the cycle is known to be three and there is no need to exceed th

[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript

2018-08-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594277#comment-16594277 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user bterlson commented

[GitHub] tinkerpop pull request #922: TINKERPOP-1959: Gremlin Javascript ability to s...

2018-08-27 Thread bterlson
Github user bterlson commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/922#discussion_r213130596 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/remote-connection.js --- @@ -66,7 +67,27 @@ class RemoteStrategy extends

[GitHub] tinkerpop issue #915: Tinkerpop 1913-Followup

2018-08-27 Thread redoz
Github user redoz commented on the issue: https://github.com/apache/tinkerpop/pull/915 @ashwinisingh01 Not sure what you're asking here. Is de1d7e59d0081567f6aa774d746098d9cef7defa before the rebase or the result of the rebase? ---

[GitHub] tinkerpop pull request #921: Add self loop example to Cycle Detection recipe...

2018-08-27 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/921#discussion_r213065687 --- Diff: docs/src/recipes/cycle-detection.asciidoc --- @@ -48,6 +48,25 @@ the length of the cycle is known to be three and there is no need to exceed th

[jira] [Created] (TINKERPOP-2028) GraphSONMessageSerializerV3d0 should register GremlinServerModule

2018-08-27 Thread Kevin Gallardo (JIRA)
Kevin Gallardo created TINKERPOP-2028: - Summary: GraphSONMessageSerializerV3d0 should register GremlinServerModule Key: TINKERPOP-2028 URL: https://issues.apache.org/jira/browse/TINKERPOP-2028 Pro

[GitHub] tinkerpop pull request #921: Add self loop example to Cycle Detection recipe...

2018-08-27 Thread newkek
Github user newkek commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/921#discussion_r212996772 --- Diff: docs/src/recipes/cycle-detection.asciidoc --- @@ -48,6 +48,25 @@ the length of the cycle is known to be three and there is no need to exceed that

[GitHub] tinkerpop pull request #921: Add self loop example to Cycle Detection recipe...

2018-08-27 Thread newkek
Github user newkek commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/921#discussion_r212996121 --- Diff: docs/src/recipes/cycle-detection.asciidoc --- @@ -48,6 +48,25 @@ the length of the cycle is known to be three and there is no need to exceed that

[jira] [Commented] (TINKERPOP-2027) Add a Typescript definitions file to the project

2018-08-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593275#comment-16593275 ] ASF GitHub Bot commented on TINKERPOP-2027: --- Github user jorgebay commented

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-08-27 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/898 > I'd be happy to give the typings file generation @mattallenuk I saw you've [created the ticket](https://issues.apache.org/jira/browse/TINKERPOP-2027): Nice! we can discuss on the tick