code freeze 3.2.10/3.3.4

So - code freeze for the tp32 and tp33 branches is in effect at this point. We'll use this thread to discuss issues related to 3.2.10 and 3.3.4 leading up to the build of release artifacts for 10/15. We currently have a few PRs that need merging to those branches,

[jira] [Commented] (TINKERPOP-2037) Remove unused groovy-sql dependency

[ https://issues.apache.org/jira/browse/TINKERPOP-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640157#comment-16640157 ] ASF GitHub Bot commented on TINKERPOP-2037: --- Github user asfgit closed the pull request at:

[GitHub] tinkerpop pull request #946: TINKERPOP-2037 removed groovy-sql

Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/946 ---

[jira] [Closed] (TINKERPOP-2037) Remove unused groovy-sql dependency

[ https://issues.apache.org/jira/browse/TINKERPOP-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Dale closed TINKERPOP-2037. -- Resolution: Fixed > Remove unused groovy-sql dependency >

[jira] [Commented] (TINKERPOP-2058) Contains predicates should rely on Compare predicates

[ https://issues.apache.org/jira/browse/TINKERPOP-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640119#comment-16640119 ] ASF GitHub Bot commented on TINKERPOP-2058: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #950: TINKERPOP-2058 Contains predicates should rely on Comp...

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/950 VOTE +1 ---

[jira] [Closed] (TINKERPOP-2056) Use NumberHelper in Compare

[ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Kuppitz closed TINKERPOP-2056. - Resolution: Fixed Fix Version/s: 3.2.10 3.3.4

[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare

[ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640083#comment-16640083 ] ASF GitHub Bot commented on TINKERPOP-2056: --- Github user asfgit closed the pull request at:

[GitHub] tinkerpop pull request #949: TINKERPOP-2056 Use NumberHelper in Compare

Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/949 ---

[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare

[ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640014#comment-16640014 ] ASF GitHub Bot commented on TINKERPOP-2056: --- Github user robertdale commented on the issue:

[jira] [Commented] (TINKERPOP-1972) inject() tests are throwing exceptions in .NET GLV tests

[ https://issues.apache.org/jira/browse/TINKERPOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640002#comment-16640002 ] ASF GitHub Bot commented on TINKERPOP-1972: --- GitHub user FlorianHockmann opened a pull

[GitHub] tinkerpop pull request #953: TINKERPOP-1972 Fix inject step in Gremlin.Net

GitHub user FlorianHockmann opened a pull request: https://github.com/apache/tinkerpop/pull/953 TINKERPOP-1972 Fix inject step in Gremlin.Net https://issues.apache.org/jira/browse/TINKERPOP-1972 We had two issues with the `inject` step in Gremlin.Net. The first one

[jira] [Updated] (TINKERPOP-2010) Generate jsdoc for gremlin-javascript

[ https://issues.apache.org/jira/browse/TINKERPOP-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-2010: Fix Version/s: (was: 3.3.4) (was: 3.2.10)

[jira] [Updated] (TINKERPOP-2004) LazyBarrierStrategy should be the only strategy that adds barriers

[ https://issues.apache.org/jira/browse/TINKERPOP-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-2004: Fix Version/s: (was: 3.3.4) (was: 3.2.10)

Re: [DISCUSS] ReferenceStrategy

On 2018/10/03 17:06:16, Stephen Mallette wrote: > We currently have this situation where users get a fair bit of > inconsistency around the contents of graph elements depending on a matrix > of different usage options that we offer - here's just a few "options" as > examples: > > 1. Use

[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript

[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639917#comment-16639917 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user mattallenuk commented on the

[GitHub] tinkerpop issue #952: TINKERPOP-1959 submit scripts in javascript

Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/952 @jorgebay @spmallette Thanks for finding the issue and sorting guys! ---

[GitHub] tinkerpop issue #945: TINKERPOP-2053 Support for OptionsStrategy

Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/945 VOTE +1 ---

[jira] [Commented] (TINKERPOP-2053) Provider OptionsStrategy for traversal configurations

[ https://issues.apache.org/jira/browse/TINKERPOP-2053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639885#comment-16639885 ] ASF GitHub Bot commented on TINKERPOP-2053: --- Github user dkuppitz commented on the issue:

GitBox

After some problems with pushes to Apache Git (weird slowness and "demultiplexer" problems) I contacted Apache Infra. In the midst of working things through with Daniel Gruno he asked again if we'd like to go to GitBox. Well, after a few IM exchanges, I learned that there's even less change and

[GitHub] tinkerpop issue #951: Optimizes Set with enum using the EnumSet implementati...

Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/951 VOTE +1 ---

[GitHub] tinkerpop issue #946: TINKERPOP-2037 removed groovy-sql

Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/946 VOTE +1 ---

[jira] [Commented] (TINKERPOP-2037) Remove unused groovy-sql dependency

[ https://issues.apache.org/jira/browse/TINKERPOP-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639874#comment-16639874 ] ASF GitHub Bot commented on TINKERPOP-2037: --- Github user dkuppitz commented on the issue:

[GitHub] tinkerpop pull request #952: TINKERPOP-1959 submit scripts in javascript

Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/952#discussion_r223009609 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js --- @@ -216,14 +219,18 @@ class

[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript

[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639844#comment-16639844 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user spmallette commented on a diff in

[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare

[ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639831#comment-16639831 ] ASF GitHub Bot commented on TINKERPOP-2056: --- Github user dkuppitz commented on the issue:

[GitHub] tinkerpop issue #949: TINKERPOP-2056 Use NumberHelper in Compare

Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/949 From what we've seen in previous tests, it should be marginally faster. I haven't run any new tests as this was more about consistency. ---

[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript

[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639819#comment-16639819 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop pull request #952: TINKERPOP-1959 submit scripts in javascript

Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/952#discussion_r223001408 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js --- @@ -216,14 +219,18 @@ class

[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript

[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639791#comment-16639791 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop pull request #952: TINKERPOP-1959 submit scripts in javascript

Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/952#discussion_r222996609 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js --- @@ -216,14 +219,18 @@ class

[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript

[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639798#comment-16639798 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user jorgebay commented on a diff in

[GitHub] tinkerpop pull request #922: TINKERPOP-1959: Gremlin Javascript ability to s...

Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/922 ---

[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript

[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639795#comment-16639795 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user asfgit closed the pull request at:

[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/922 PR for this is now on #952 ---

[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript

[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639787#comment-16639787 ] ASF GitHub Bot commented on TINKERPOP-1959: --- GitHub user spmallette opened a pull request:

[GitHub] tinkerpop pull request #952: TINKERPOP-1959 submit scripts in javascript

GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/952 TINKERPOP-1959 submit scripts in javascript https://issues.apache.org/jira/browse/TINKERPOP-1959 Follow on PR to #922 - more details there. This branch now contains a fix for the

[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript

[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639768#comment-16639768 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/922 @mattallenuk I figured out what was going on. The `EnumValue` was being interpreted as a `Map` when serializing to GraphSON. The change is pretty trivial, but I have a bunch of other little

[jira] [Commented] (TINKERPOP-2015) Allow users to configure the WebSocket connections

[ https://issues.apache.org/jira/browse/TINKERPOP-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639719#comment-16639719 ] ASF GitHub Bot commented on TINKERPOP-2015: --- Github user jantzeca commented on the issue:

[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...

Github user jantzeca commented on the issue: https://github.com/apache/tinkerpop/pull/928 @spmallette Okay, thank you! ---

AW: [DISCUSS] 3.2.10, 3.3.4, 3.4.0 Releases

Regarding the two possible bugs in Gremlin.Net: For TINKERPOP-2043, my current assumption is that the fix for TINKERPOP-2026 also solves this issue as TINKERPOP-2043 is caused by a failing close of WebSocket connections which is now silently catched with the fix from TINKERPOP-2026. So, I

[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare

[ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639666#comment-16639666 ] ASF GitHub Bot commented on TINKERPOP-2056: --- Github user spmallette commented on the issue:

Re: [DISCUSS] 3.2.10, 3.3.4, 3.4.0 Releases

It seems like we're closing in on the final items: + TINKERPOP-2019/TINKERPOP-2043 - Possible bugs in .NET - Florian, it looks like you are digging around in these issues trying to get to the bottom of things - do you feel that we can release without these? + TINKERPOP-1972 - Two failing tests in

[GitHub] tinkerpop issue #949: TINKERPOP-2056 Use NumberHelper in Compare

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/949 Just pushed a commit 4bdb006c5ee418f27ef7bb8a9330714ce414c50f on the release branches to deal with these pesky tests that sometimes fail in travis: ```text [ERROR]

[GitHub] tinkerpop pull request #951: Optimizes Set with enum using the EnumSet imple...

GitHub user otaviojava opened a pull request: https://github.com/apache/tinkerpop/pull/951 Optimizes Set with enum using the EnumSet implementation [tp32] This PR replaces the HashSet implementation to [EnumSet](https://docs.oracle.com/javase/7/docs/api/java/util/EnumSet.html)