[GitHub] [tinkerpop] spmallette commented on issue #1013: TINKERPOP-2105 - connection.py - add finally to return connection to the client pool i…

2018-12-13 Thread GitHub
sorry - i just haven't had a chance to really look at this in detail. hopefully i can get at it tomorrow. thanks for submitting it. I did notice however that travis is failing the python tests - i assume that the failures are related to this change: https://travis-ci.org/apache/tinkerpop/jobs/

[GitHub] [tinkerpop] spmallette commented on issue #1013: TINKERPOP-2105 - connection.py - add finally to return connection to the client pool i…

2018-12-13 Thread GitHub
sorry - i just haven't had a chance to really look at this in detail. hopefully i can get at it tomorrow. thanks for submitting it. [ Full content available at: https://github.com/apache/tinkerpop/pull/1013 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Created] (TINKERPOP-2114) Document common Gremlin anti-patterns

2018-12-13 Thread Daniel Kuppitz (JIRA)
Daniel Kuppitz created TINKERPOP-2114: - Summary: Document common Gremlin anti-patterns Key: TINKERPOP-2114 URL: https://issues.apache.org/jira/browse/TINKERPOP-2114 Project: TinkerPop Iss

[GitHub] [tinkerpop] spmallette commented on pull request #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type

2018-12-13 Thread GitHub
nicely done. i really wanted a `partition()` function, but what you're doing there is better than that stupid for loop [ Full content available at: https://github.com/apache/tinkerpop/pull/1018 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] dkuppitz commented on pull request #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type

2018-12-13 Thread GitHub
The whole loop and remapping can be simplified to: ``` return Enumerable.Range(0, jArray.Count / 2).SelectMany(i => Enumerable.Repeat(reader.ToObject(jArray[i * 2]), (int) reader.ToObject(jArray[i * 2 + 1]))). ToList(); ``` [ Full content available at: https://github.com/apache/tinke

[GitHub] [tinkerpop] jorgebay commented on issue #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type

2018-12-13 Thread GitHub
VOTE +1 [ Full content available at: https://github.com/apache/tinkerpop/pull/1018 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2111) Add BulkSet as a GraphSON type

2018-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720383#comment-16720383 ] ASF GitHub Bot commented on TINKERPOP-2111: --- spmallette opened a new pull r

[GitHub] [tinkerpop] spmallette opened pull request #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type

2018-12-13 Thread GitHub
https://issues.apache.org/jira/browse/TINKERPOP-2111 Adding `BulkSet` brings some consistency to how results are processed and sets things up better for GraphBinary. Implemented for all GLVs though they do not yet have `BulkSet` implementations - they simply coerce to `List` during deserializat

[jira] [Closed] (TINKERPOP-2013) Process tests that are auto-ignored stink

2018-12-13 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-2013. --- Resolution: Done Fix Version/s: 3.3.5 3.4.0 Basically m

[jira] [Created] (TINKERPOP-2113) P.Within() doesn't work when given a List argument

2018-12-13 Thread Florian Hockmann (JIRA)
Florian Hockmann created TINKERPOP-2113: --- Summary: P.Within() doesn't work when given a List argument Key: TINKERPOP-2113 URL: https://issues.apache.org/jira/browse/TINKERPOP-2113 Project: Tinker

Re: hold on merges to tp33/master

2018-12-13 Thread Stephen Mallette
Ok, all good, that was much shorter and easier than I had expected. tp33/master are open for business On Thu, Dec 13, 2018 at 6:04 AM Stephen Mallette wrote: > I'm in the midst of a complicated body of changes/merges for the release > branches. I think I'm coming close to be able to push.Please

hold on merges to tp33/master

2018-12-13 Thread Stephen Mallette
I'm in the midst of a complicated body of changes/merges for the release branches. I think I'm coming close to be able to push.Please hold off from pushing to tp33 and master while I try to polish this up. It would be a big help - thanks.