[GitHub] [tinkerpop] thefliik commented on issue #1056: fix: Path#toString() variable reference bug

2019-02-06 Thread GitHub
The code in question on `tp33`: https://github.com/apache/tinkerpop/blob/tp33/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.js#L118-L139 [ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ] This message was relayed via gitbox.apache.org for

[GitHub] [tinkerpop] spmallette commented on issue #1056: fix: Path#toString() variable reference bug

2019-02-06 Thread GitHub
`tp33` continually merges to `master` - wonder why `toString()` isn't present on that branch [ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] thefliik commented on issue #1056: fix: Path#toString() variable reference bug

2019-02-06 Thread GitHub
@jorgebay in the `tp33` branch it looks like the Path#toString() method has been removed entirely, so when/if that branch is merged into master this PR will be unnecessary. Feel free to close. [ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ] This message was relayed

[jira] [Closed] (TINKERPOP-2150) GraphBinary: Support configuring the TypeSerializerRegistry builder class in config

2019-02-06 Thread Jorge Bay (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Bay closed TINKERPOP-2150. Resolution: Done > GraphBinary: Support configuring the TypeSerializerRegistry builder class

[jira] [Commented] (TINKERPOP-2150) GraphBinary: Support configuring the TypeSerializerRegistry builder class in config

2019-02-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761779#comment-16761779 ] ASF GitHub Bot commented on TINKERPOP-2150: --- jorgebay commented on pull request #1055:

[GitHub] [tinkerpop] jorgebay closed pull request #1055: TINKERPOP-2150 Support configuring the registry builder in config

2019-02-06 Thread GitHub
[ pull request closed by jorgebay ] [ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] dkuppitz commented on issue #1055: TINKERPOP-2150 Support configuring the registry builder in config

2019-02-06 Thread GitHub
VOTE +1 [ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

Re: ATTN Committers/PMC Members: Bio Update

2019-02-06 Thread Jorge Bay Gondra
I've updated my bio to include GraphBinary in CTR fashion. On Tue, Feb 5, 2019 at 10:55 AM Florian Hockmann wrote: > My bio is also still up-to-date. > > Regards, > Florian > > -Ursprüngliche Nachricht- > Von: Robert Dale > Gesendet: Sonntag, 3. Februar 2019 03:50 > An:

[GitHub] [tinkerpop] jorgebay commented on issue #1056: fix: Path#toString() variable reference bug

2019-02-06 Thread GitHub
Thanks @thefliik , I've filed a ticket to keep track of this: https://issues.apache.org/jira/browse/TINKERPOP-2152 Can you target branch `tp33` for this to be applied to the 3.3 line? [ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ] This message was relayed via

[jira] [Created] (TINKERPOP-2152) Path toString fails in Gremlin JavaScript

2019-02-06 Thread Jorge Bay (JIRA)
Jorge Bay created TINKERPOP-2152: Summary: Path toString fails in Gremlin JavaScript Key: TINKERPOP-2152 URL: https://issues.apache.org/jira/browse/TINKERPOP-2152 Project: TinkerPop Issue

[jira] [Closed] (TINKERPOP-2149) GraphBinary: Make type serializer resolution pluggable

2019-02-06 Thread Jorge Bay (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Bay closed TINKERPOP-2149. Resolution: Done > GraphBinary: Make type serializer resolution pluggable >

[jira] [Commented] (TINKERPOP-2149) GraphBinary: Make type serializer resolution pluggable

2019-02-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761614#comment-16761614 ] ASF GitHub Bot commented on TINKERPOP-2149: --- jorgebay commented on pull request #1054:

[GitHub] [tinkerpop] jorgebay closed pull request #1054: TINKERPOP-2149 Add fallback resolver to TypeSerializerRegistry

2019-02-06 Thread GitHub
[ pull request closed by jorgebay ] [ Full content available at: https://github.com/apache/tinkerpop/pull/1054 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on issue #1055: TINKERPOP-2150 Support configuring the registry builder in config

2019-02-06 Thread GitHub
I've updated the docs and added an entry to the CHANGELOG. [ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org