Re: TP4 Processors now support both push- and pull-based semantics.

2019-04-26 Thread bryncooke
On 2019/04/24 12:19:54, Marko Rodriguez wrote: > Hello, > > > I think it would be better to either expose Flowable on the API (or Flow if > > you don't want to be tied in to RxJava) > > We definitely don’t want to expose anything “provider specific.” Especially > at the Processor

Re: TP4 Processors now support both push- and pull-based semantics.

2019-04-24 Thread bryncooke
On 2019/04/23 13:07:09, Marko Rodriguez wrote: > Hi, > > Stephen and Bryn were looking over my RxJava implementation the other day and > Bryn, with his British accent, was like [I paraphrase]: > > “Whoa dawg! Bro should like totally not be blocking to fill an > iterator. Gnar gnar

Re: [DISCUSS] ReferenceStrategy

2018-10-24 Thread bryncooke
On 2018/10/22 18:21:13, Stephen Mallette wrote: > https://issues.apache.org/jira/browse/TINKERPOP-2075 > > On Mon, Oct 8, 2018 at 1:37 PM Stephen Mallette > wrote: > > > > I'd like to propose 2a. Update Gremlin Server and TinkerGraph to behave > > in the desired way, this would set the

OptionsStrategy improvements

2018-10-08 Thread bryncooke
Hi, I recently saw the new OptionsStrategy feature added in https://issues.apache.org/jira/browse/TINKERPOP-2053, and was wondering it it would be possible to add dedicated support for this at the traversal level. Using a strategy is fine, and I can see that it fits well with the existing

Re: [DISCUSS] ReferenceStrategy

2018-10-05 Thread bryncooke
On 2018/10/03 17:06:16, Stephen Mallette wrote: > We currently have this situation where users get a fair bit of > inconsistency around the contents of graph elements depending on a matrix > of different usage options that we offer - here's just a few "options" as > examples: > > 1. Use

[GitHub] tinkerpop issue #812: TINKERPOP-1911 Refactored JavaTranslator

2018-03-06 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/812 +1 (Non binding) ---

[GitHub] tinkerpop issue #755: TINKERPOP-1834: Consider iterate() as a first class st...

2017-11-27 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/755 This looks great. +1 (non binding) ---

[GitHub] tinkerpop issue #748: TINKERPOP-1834: Consider iterate() as a first class st...

2017-11-20 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/748 Would a cap step with no side effect keys be a better fit here rather than filter? It would remove the need for a 'false' traversal. ---

[GitHub] tinkerpop issue #641: TINKERPOP-1703: Make DsegEdgeOtherVertexStep non-final

2017-06-30 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/641 Can we rename the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tinkerpop issue #590: TINKERPOP-1664 StarVertexProperty will check meta-prop...

2017-04-06 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/590 I've reworked for tp31. Also I check null values on array parameters. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tinkerpop pull request #590: TINKERPOP-1664 StarVertexProperty will check me...

2017-04-03 Thread BrynCooke
GitHub user BrynCooke opened a pull request: https://github.com/apache/tinkerpop/pull/590 TINKERPOP-1664 StarVertexProperty will check meta-properties are valid. StarVertexProperty will check meta-properties are valid. You can merge this pull request into a Git repository

[GitHub] tinkerpop issue #567: TINKERPOP-1644 Improve script compilation syncronisati...

2017-03-08 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/567 1. ManagedConcurrentValueMap is not a map. I don't really know why we use this. but computeIfAbsent is not present on this class. 2. Guava LoadingCache and MoreExecutors.directExecutor

[GitHub] tinkerpop issue #567: TINKERPOP-1644 Improve script compilation syncronisati...

2017-03-07 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/567 I like the idea of using a Future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tinkerpop pull request #567: TINKERPOP-1644 Improve script compilation syncr...

2017-03-06 Thread BrynCooke
GitHub user BrynCooke opened a pull request: https://github.com/apache/tinkerpop/pull/567 TINKERPOP-1644 Improve script compilation syncronisation Script compilation is synchronised. Script compilation times are placed in to logs. Failed scripts will not be recompiled

[GitHub] tinkerpop pull request #470: TINKERPOP-887 Conversion of FastNoSuchElementEx...

2016-11-02 Thread BrynCooke
Github user BrynCooke closed the pull request at: https://github.com/apache/tinkerpop/pull/470 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] tinkerpop issue #470: TINKERPOP-887 Conversion of FastNoSuchElementException...

2016-11-02 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/470 Great thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #470: TINKERPOP-887 Conversion of FastNoSuchElementException...

2016-11-02 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/470 Retargeting at tp32. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tinkerpop issue #470: TINKERPOP-887 Conversion of FastNoSuchElementException...

2016-10-31 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/470 Yes, that's it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #470: TINKERPOP-887 Conversion of FastNoSuchElementException...

2016-10-31 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/470 Exactly. It's currently a huge pain to figure out where things have gone wrong. Without this patch I have to divide and conquer my code every time I hit a FastNoSuchElementException

[GitHub] tinkerpop issue #470: TINKERPOP-887 Conversion of FastNoSuchElementException...

2016-10-31 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/470 @dkuppitz I've updated the changelog and upgrade docs. Please could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] tinkerpop issue #470: TINKERPOP-887 Conversion of FastNoSuchElementException...

2016-10-31 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/470 The lambda traversal will throw a regular NoSuchElementException is it is unparented. However, won't this will only happen once? The exception will bubble up and out of the top level

[GitHub] tinkerpop issue #470: TINKERPOP-887 Conversion of FastNoSuchElementException...

2016-10-29 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/470 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] tinkerpop issue #470: TINKERPOP-887 Conversion of FastNoSuchElementException...

2016-10-29 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/470 @okram I have changed the approach entirely to avoid adding an extra strategy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tinkerpop pull request #470: TINKERPOP-887 ExceptionHandlerStrategy

2016-10-28 Thread BrynCooke
GitHub user BrynCooke opened a pull request: https://github.com/apache/tinkerpop/pull/470 TINKERPOP-887 ExceptionHandlerStrategy Added exception handler strategy to convert FastNoSuchElementExceptions in to regular NoSuchElementExceptions when exiting a traversal. You can merge

[GitHub] tinkerpop issue #355: TINKERPOP-1355 Design HasContainer for extension

2016-07-04 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/355 Also the conversion of the collection to an array is dangerous. Who knows what the collection is actually backed by? It should use an iterator and get the first element if it exists

[GitHub] tinkerpop pull request #355: TINKERPOP-1355 Design HasContainer for extensio...

2016-07-04 Thread BrynCooke
GitHub user BrynCooke opened a pull request: https://github.com/apache/tinkerpop/pull/355 TINKERPOP-1355 Design HasContainer for extension You can merge this pull request into a Git repository by running: $ git pull https://github.com/BrynCooke/incubator-tinkerpop TINKERPOP

[GitHub] tinkerpop issue #347: Force startedIterating before sleep

2016-06-27 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/347 @dkuppitz Yes you are right, I've tweaked the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop pull request #347: Force startedIterating before sleep

2016-06-27 Thread BrynCooke
GitHub user BrynCooke opened a pull request: https://github.com/apache/tinkerpop/pull/347 Force startedIterating before sleep You can merge this pull request into a Git repository by running: $ git pull https://github.com/BrynCooke/incubator-tinkerpop TINKERPOP-1348