[GitHub] tinkerpop issue #478: TINKERPOP-1490 Implemented promise API for Traversal

Github user aholmberg commented on the issue: https://github.com/apache/tinkerpop/pull/478 > the type of future returned will depend on the underlying RemoteConnection implementation. That depends on whether you are okay leaking remote connection implementation thro

[GitHub] tinkerpop issue #478: TINKERPOP-1490 Implemented promise API for Traversal

Github user aholmberg commented on the issue: https://github.com/apache/tinkerpop/pull/478 Coupling the traversal API to a web framework does not seem appealing to me. Could we consider using the [futures backport](https://pypi.python.org/pypi/futures), which backports the Python 3

[GitHub] tinkerpop issue #448: Python glv graphson update

Github user aholmberg commented on the issue: https://github.com/apache/tinkerpop/pull/448 Pushed the split names. I didn't see issues related to these changes running `process-docs.sh`. May have been related to the previous removal of GraphSONWriter/Reader. --- If your project

[GitHub] tinkerpop issue #448: Python glv graphson update

Github user aholmberg commented on the issue: https://github.com/apache/tinkerpop/pull/448 Maybe we should clarify what APIs really need to be preserved. I have been thinking about the `process` package, and `structure` module as the Gremlin API, and the `driver` and `io` as distinct

[GitHub] tinkerpop issue #448: Python glv graphson update

Github user aholmberg commented on the issue: https://github.com/apache/tinkerpop/pull/448 Thanks. I see the code there. What is not clear to me is why these two things are divided, and why that API should be replicated here. I'm having a hard time doing this change because it makes

[GitHub] tinkerpop issue #448: Python glv graphson update

Github user aholmberg commented on the issue: https://github.com/apache/tinkerpop/pull/448 (also, ACK on rebase -- I should be getting to it today) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tinkerpop issue #448: Python glv graphson update

Github user aholmberg commented on the issue: https://github.com/apache/tinkerpop/pull/448 > you changed GraphSONWriter and GraphSONWriter to GraphSONIO This was not Python-specific, but felt like a natural design to me. I unified the I/O per type, and tied those toget

[GitHub] tinkerpop issue #448: Python glv graphson update

Github user aholmberg commented on the issue: https://github.com/apache/tinkerpop/pull/448 argh. needs a third rebase, too :-/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tinkerpop issue #448: Python glv graphson update

Github user aholmberg commented on the issue: https://github.com/apache/tinkerpop/pull/448 > graphson_io=None to the __init__ method signature I think that is a fine idea. I was mostly focused on the GraphSON API and not concerned with adding it to the token RemoteConnect

[GitHub] tinkerpop issue #448: Python glv graphson update

Github user aholmberg commented on the issue: https://github.com/apache/tinkerpop/pull/448 I'm ambivalent on that. I just noticed unittest was present, and the bare assertions were not very informative. I can take that commit out if you think it's not worth it now. --- If your

[GitHub] tinkerpop pull request #448: Python glv graphson update

GitHub user aholmberg opened a pull request: https://github.com/apache/tinkerpop/pull/448 Python glv graphson update I have a series of gremlinpython graphson serdes simplifications, followed by a refactor to make type mappings an instance variable, rather than a module-level

[GitHub] tinkerpop pull request #:

Github user aholmberg commented on the pull request: https://github.com/apache/tinkerpop/commit/6ed7edc0b4ad2abf933e917812d49ad92230c8d1#commitcomment-18474370 In gremlin-variant/src/main/groovy/org/apache/tinkerpop/gremlin/python/GremlinPythonGenerator.groovy: In gremlin

[GitHub] tinkerpop pull request #:

Github user aholmberg commented on the pull request: https://github.com/apache/tinkerpop/commit/6ed7edc0b4ad2abf933e917812d49ad92230c8d1#commitcomment-18474349 In gremlin-variant/src/main/groovy/org/apache/tinkerpop/gremlin/python/GremlinPythonGenerator.groovy: In gremlin

[GitHub] tinkerpop pull request #:

Github user aholmberg commented on the pull request: https://github.com/apache/tinkerpop/commit/6ed7edc0b4ad2abf933e917812d49ad92230c8d1#commitcomment-18473940 In gremlin-variant/src/main/groovy/org/apache/tinkerpop/gremlin/python/GremlinPythonGenerator.groovy: In gremlin

[GitHub] tinkerpop pull request #364: tweaks in gremlin language variants doc

GitHub user aholmberg opened a pull request: https://github.com/apache/tinkerpop/pull/364 tweaks in gremlin language variants doc I noticed a few possible errors while reading the "Gremlin Language Variants" tutorial. You can merge this pull request into a Git