Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/945
VOTE +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/951
VOTE +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/946
VOTE +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/949
From what we've seen in previous tests, it should be marginally faster. I
haven't run any new tests as this was more about consistency.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/950
Reminder: Merge #949 first, then rebase this PRs branch and fix `PTest`
(include differing number tests for `Contains` predicates).
https://github.com/apache/tinkerpop/pull/949/files
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/950
TINKERPOP-2058 Contains predicates should rely on Compare predicates
https://issues.apache.org/jira/browse/TINKERPOP-2058
If the object to be filtered is a number, `Contains` predicates
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/949
TINKERPOP-2056 Use NumberHelper in Compare
Instead of converting all numbers to `BigDecimal`, `Compare` predicates now
use `NumberHelper` for numerical comparisons.
`docker/build.sh -t
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/948
That's the kind of benchmark I was looking for. I don't think it needs to
be part of the project (these micro-benchmarks always seem to be too unstable
and making them part of the test suite
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/948
Although this looks like a very reasonable change and I don't have any
objections, could you please run some benchmarks to show what we gain by this
change?
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/944#discussion_r222065189
--- Diff: docs/src/reference/the-traversal.asciidoc ---
@@ -3356,24 +3356,32 @@ interface. Steps that allow for this type of
modulation will explicitly
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/943
VOTE +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/920
I haven't done any extensive performance benchmarks, but the overall build
time went down by 1 minute -- wohoo :)
Anyway, `docker/build.sh -t -i` passed.
VOTE +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/928
Hm, alright. I don't have an environment to test it myself, but apparently
I'm missing something; I thought it would be a simple property delegation.
VOTE +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/928
IMO it would be better to expose the options as a property unless there's a
good reason to not allow any changes in options after the client has been
initialized. But since the underlying
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/939
VOTE +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/941
VOTE +1
---
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/944
TINKERPOP-2041 Text Predicates
https://issues.apache.org/jira/browse/TINKERPOP-2041
This PR adds a few text predicates (`TP`):
* `startsWith`
* `endsWith`
* `contains
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/933
VOTE +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/934
Changes and tests look good to me.
VOTE +1
---
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/935
TINKERPOP-2025 Change to SHA-256/512 and drop SHA-1 for releases
https://issues.apache.org/jira/browse/TINKERPOP-2025
Unfortunately, upgrading the Apache parent pom didn't solve
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/931#discussion_r217759875
--- Diff: docs/src/upgrade/release-3.4.x.asciidoc ---
@@ -29,6 +29,29 @@ Please see the
link:https://github.com/apache/tinkerpop/blob/3.4.0
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/932
VOTE +1
---
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/931
TINKERPOP-2029 ConcurrentModificationException for InlineFilterStrategy
https://issues.apache.org/jira/browse/TINKERPOP-2029
To fix the original issue, I basically rewrote
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/921
VOTE +1
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213398454
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213364785
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213148817
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213065687
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,25 @@ the length of the cycle is known to be three and there
is no need to exceed
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r212807145
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,25 @@ the length of the cycle is known to be three and there
is no need to exceed
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/920
I can see why `Collections.addAll(...)` would be faster than
`c.addAll(Arrays.asList(...))`, but not why it would be faster than a simple
loop. I think if you really want to squeeze out as much
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/912
Very nice work.
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/919
In the future, can we please let those (potential) CTR's sit for a bit
longer? I haven't had a chance to really look at it and I guess I would have
voted against it (it's not bad, but also
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/911
VOTE +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/902
VOTE: +1
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/902#discussion_r209334263
--- Diff: docs/site/home/index.html ---
@@ -259,6 +259,7 @@ Query
Languages
https://github.com/pm-dev/kotlin-gremlin-ogm;>kot
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/902#discussion_r209336628
--- Diff: docs/src/reference/compilers.asciidoc ---
@@ -0,0 +1,416 @@
+
+Licensed to the Apache Software Foundation (ASF) under one or more
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/902#discussion_r209346676
--- Diff:
sparql-gremlin/src/main/java/org/apache/tinkerpop/gremlin/sparql/process/traversal/dsl/sparql/SparqlTraversalSource.java
---
@@ -0,0 +1,155
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/909
VOTE: +1
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/882#discussion_r207377923
--- Diff: docs/src/recipes/shortest-path.asciidoc ---
@@ -136,3 +158,44 @@ g.withSack(0.0).V().as("from"). <1>
<
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/882#discussion_r207374407
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Traversal.java
---
@@ -496,15 +496,17 @@ public default void reset
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/882#discussion_r207373358
--- Diff: docs/src/recipes/shortest-path.asciidoc ---
@@ -48,6 +48,17 @@ course, it is possible for there to be more than one
path in the graph
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/882
Done.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/897
Mucho mejor.
```
gremlin> g.withComputer().V().dedup().connectedComponent().valueMap()
==>[gremlin.connectedComponentVertexProgram.component:[1],name:[ripple],lang
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/882#discussion_r206207720
--- Diff: docs/src/reference/the-traversal.asciidoc ---
@@ -2489,6 +2489,62 @@
link:++http://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/897#discussion_r205981525
--- Diff: docs/src/recipes/connected-components.asciidoc ---
@@ -35,46 +54,92 @@ g.addV().property(id, "A").as("a").
addE(&qu
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/893#discussion_r205930660
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs ---
@@ -1704,11 +1713,11 @@ public
GraphTraversal(ICollection
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/893#discussion_r205930559
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/IoStep.java
---
@@ -0,0 +1,254
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/894
Yep, done. I added an entry in the root `.gitignore` file and added another
`.gitignore` file in `docker/hadoop/`. The two auto-generated `Dockerfile`s
will be ignored from now on.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/894
By the way, the `Dockerfile`, that's removed by this PR, has nothing to do
with the PR, but the file is an autogenerated file that shouldn't be in the
repository.
---
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/894
TINKERPOP-2011 Use NumberHelper on choose()
https://issues.apache.org/jira/browse/TINKERPOP-2011
Treat numerical options in `ChooseStep` as in any other numerical
comparison (value
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202456800
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_LP_NL_O_P_S_SE_SL_Traverser.java
---
@@ -0,0 +1,156
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202453831
--- Diff:
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStepTest.java
---
@@ -39,7 +39,9
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/876
VOTE: +1
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202438650
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_LP_NL_O_P_S_SE_SL_Traverser.java
---
@@ -0,0 +1,156
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202437245
--- Diff:
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStepTest.java
---
@@ -39,7 +39,9
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/886
VOTE: +1
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202104064
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java
---
@@ -2289,6 +2302,21 @@ else
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202104896
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -43,6 +43,7 @@
private
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202114064
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_LP_NL_O_P_S_SE_SL_Traverser.java
---
@@ -0,0 +1,156
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202105366
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/LoopsStep.java
---
@@ -26,12 +26,15
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202110691
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_O_S_SE_SL_Traverser.java
---
@@ -32,6 +32,7
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202114725
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatTest.java
---
@@ -386,5 +531,51 @@ public void
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202111311
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/O_OB_S_SE_SL_Traverser.java
---
@@ -30,6 +30,7
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202113071
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/util/LabelledCounter.java
---
@@ -0,0 +1,85
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202102880
--- Diff: docs/src/reference/the-traversal.asciidoc ---
@@ -2125,6 +2125,17 @@ traverser repeats. However, because the
emit-predicate is declared true
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/876
I agree it should be treated differently. Since `as()` labeling has an
impact on the path history, it really shouldn't be used for this case.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/885
VOTE: +1
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/885#discussion_r197851424
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs ---
@@ -45,19 +44,28 @@ public ConnectionPool(ConnectionFactory
connectionFactory
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/884
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/883
VOTE: +1
... but maybe make the configuration mandatory and throw an exception if `
world.config.user_data["graphson"]` was not set.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/880
VOTE: +1
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/881#discussion_r197826190
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/TestHelper.java ---
@@ -51,11 +52,19 @@
* @author Stephen Mallette (http
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/879
VOTE: +1
---
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/882
TINKERPOP-1990 Add a shortestPath() step
Implemented `ShortestPathVertexProgram` and `ShortestPathVertexProgramStep`.
`docker/build.sh -t -i -n -d` passed.
VOTE: +1
I
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r196096436
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatTest.java
---
@@ -386,5 +456,26 @@ public void
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/874
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/873
VOTE: +1
Though I would change the Jira ticket title before it makes it into the
CHANGELOG, as the implementation doesn't really cache anything.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/872
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/871
VOTE: +1
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/871#discussion_r192922149
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java
---
@@ -260,6 +261,7 @@
CLASS_IMPORTS.add
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/865
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/870
VOTE: +1
---
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/864
TINKERPOP-1958 Fixed a bug in TinkerGraphCountStrategy
https://issues.apache.org/jira/browse/TINKERPOP-1958
The strategy did not consider, that certain map steps may not emit
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/862
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/863
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Worked well for me.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/860
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/861
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/854
VOTE: +1
But I do think a simple test would be nice. The code screams "make me
recursive" and a future contributor, not aware of this issue, might try to
change it back and n
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/859
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/858
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/766
It does scale to up to 4 tabs. Should we ever have more, we only need to
tweak the
[maxTabs](https://github.com/apache/tinkerpop/pull/766/files#diff-c362bf9cce8980393d4230e56c86a655R31
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/843
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/848
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/853
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/855
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/851
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/839
VOTE: +1
---
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/844
TINKERPOP-1628 Implement TraversalSelectStep
https://issues.apache.org/jira/browse/TINKERPOP-1628
This PR adds a `TraversalSelectStep` which supports the selection of
dynamic / runtime
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/833
VOTE: +1
---
1 - 100 of 555 matches
Mail list logo
