[GitHub] tinkerpop issue #650: TINKERPOP-1171: Remove deprecated TraversalSource.Buil...

2017-07-03 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/650 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #644: TINKERPOP-1552 Gremlin.Net

2017-06-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/644 I guess `dotnet-dev-1.0.1` could be bumped to `dotnet-dev-1.0.4` (that's currently the latest). What is `apt-transport-http` needed for? --- If your project is set up for it, yo

[GitHub] tinkerpop issue #643: TINKERPOP-1701: HaltedTraverserStrategy should recurse...

2017-06-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/643 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #642: TINKERPOP-1704: XXXTranslators are not being respectiv...

2017-06-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/642 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #641: TINKERPOP-1703: Make DsegEdgeOtherVertexStep non-final

2017-06-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/641 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #633: TINKERPOP-741 (master) Removed deprecated transaction ...

2017-06-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/633 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #634: TINKERPOP-741 Deprecated Transaction.submit(Function)

2017-06-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/634 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #640: TINKERPOP-1694 Deprecated useMapperFromGraph

2017-06-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/640 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #639: TINKERPOP-1669: EdgeVertexStep should be designed for ...

2017-06-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/639 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #632: TINKERPOP-1519: tinker graph computer does not handle ...

2017-06-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/632 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-23 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r123745535 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupStep.java --- @@ -79,6 +79,14 @@ public void

[GitHub] tinkerpop issue #628: TINKERPOP-1550 Made ganglia/graphite optional dependen...

2017-06-22 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/628 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop pull request #628: TINKERPOP-1550 Made ganglia/graphite optional d...

2017-06-22 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/628#discussion_r123490358 --- Diff: pom.xml --- @@ -597,6 +597,7 @@ limitations under the License. com.codahale.metrics metrics-graphite

[GitHub] tinkerpop pull request #628: TINKERPOP-1550 Made ganglia/graphite optional d...

2017-06-22 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/628#discussion_r123485417 --- Diff: pom.xml --- @@ -597,6 +597,7 @@ limitations under the License. com.codahale.metrics metrics-graphite

[GitHub] tinkerpop pull request #628: TINKERPOP-1550 Made ganglia/graphite optional d...

2017-06-22 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/628#discussion_r123484932 --- Diff: gremlin-server/pom.xml --- @@ -63,10 +63,12 @@ limitations under the License. com.codahale.metrics

[GitHub] tinkerpop issue #624: TINKERPOP-929 Deprecation Removal

2017-06-22 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/624 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #635: TINKERPOP-1688 Add annotations to TraversalMetrics pre...

2017-06-22 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/635 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop pull request #638: TINKERPOP-999 Removed generics from ServerGreml...

2017-06-20 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/638#discussion_r123119092 --- Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/GremlinServer.java --- @@ -108,54 +108,24 @@ public GremlinServer(final

[GitHub] tinkerpop issue #637: TINKERPOP-1004 Expand usage of TransactionException

2017-06-20 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/637 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #636: TINKERPOP-1691 Changed semantics of EventStrategyProce...

2017-06-20 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/636 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #621: TINKERPOP-1682 by-modulator optimization strategy

2017-06-19 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/621 Added a few comments and worked on those points that I haven't commented. I will push in few minutes after getting a clean build. --- If your project is set up for it, you can reply to

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-19 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r122694055 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupStepV3d0.java --- @@ -111,6 +111,16 @@ public void

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-19 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r122736897 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/TraversalRing.java --- @@ -62,6 +62,10 @@ public void

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-19 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r122693554 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupStep.java --- @@ -79,6 +79,14 @@ public void

[GitHub] tinkerpop issue #631: TINKERPOP-1445 Add ellipses for long property values

2017-06-18 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/631 VOTE: +1 (and an extra +1 for finding a super long name that actually exists :)) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-08 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/621 TINKERPOP-1682 by-modulator optimization strategy https://issues.apache.org/jira/browse/TINKERPOP-1682 Implemented `ByModulatorOptimizationStrategy` which replaces certain standard

[GitHub] tinkerpop pull request #617: TINKERPOP-1681 Multiple hasId's are or'd into G...

2017-05-31 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/617 TINKERPOP-1681 Multiple hasId's are or'd into GraphStep https://issues.apache.org/jira/browse/TINKERPOP-1681 Fixed folding of multiple `hasId()`'s into `GraphStep`.

[GitHub] tinkerpop issue #613: TINKERPOP-1676 (tp32) GraphSON Performance

2017-05-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/613 Not sure if this should really go into `tp32` as it's kinda breaking (though it breaks something that was broken :)), but if others agree, then VOTE: +1 --- If your project is s

[GitHub] tinkerpop issue #614: TINKERPOP-1676 (master) GraphSON Performance

2017-05-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/614 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #612: TINKERPOP-1677 Bump Groovy to 2.4.11

2017-05-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/612 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #616: TINKERPOP-1680 Add string performance options to StarG...

2017-05-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/616 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #608: TINKERPOP-1618 Removed dependence on groovy for gremli...

2017-05-26 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/608 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #610: TINKERPOP-786 Gremlin DSL Support

2017-05-23 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/610 Slick! It's indeed much easier than I thought. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] tinkerpop issue #607: TINKERPOP-1673: GroovyTranslator produces Gremlin that...

2017-05-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/607 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #604: TINKERPOP-1670 Maintain Traversal type information in ...

2017-05-08 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/604 LGTM. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] tinkerpop issue #599: TINKERPOP-1044 master Include more error information i...

2017-04-18 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/599 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #598: TINKERPOP-1044 Include more error information in remot...

2017-04-18 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/598 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #601: TINKERPOP-1668: RepeatUnrollStrategy should not execut...

2017-04-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/601 Cool. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] tinkerpop pull request #602: TINKERPOP-1313 Rename RangeByIsCountStrategy

2017-04-13 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/602 TINKERPOP-1313 Rename RangeByIsCountStrategy https://issues.apache.org/jira/browse/TINKERPOP-1313 Renamed `RangeByIsCountStrategy` to `CountStrategy`. `docker/build.sh -t -i -n

[GitHub] tinkerpop issue #601: TINKERPOP-1668: RepeatUnrollStrategy should not execut...

2017-04-13 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/601 Very rare indeed. Maybe we should just add a tiny note (and/or an example) in the repeat steps docs. ``` g.V().repeat(out().sideEffect {println it.loops()}).iterate() // don'

[GitHub] tinkerpop issue #601: TINKERPOP-1668: RepeatUnrollStrategy should not execut...

2017-04-13 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/601 Lambda steps could do something with `it.loops()` and thus should have the same effect. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] tinkerpop issue #569: TINKERPOP-1438: GraphManager becomes a customizable in...

2017-04-13 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/569 Feel free to merge this PR @pluradj. The @spmallette bot is currently being rebooted / is on vacation ;). --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tinkerpop pull request #595: TINKERPOP-1608 XSLT for converting GraphSON

2017-04-10 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/595#discussion_r110655969 --- Diff: gremlin-core/src/main/resources/tp2-to-tp3-graphml.xslt --- @@ -0,0 +1,59 @@ + + + + + +http://graphml.graphdrawing.org

[GitHub] tinkerpop pull request #595: TINKERPOP-1608 XSLT for converting GraphSON

2017-04-10 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/595#discussion_r110650888 --- Diff: gremlin-core/src/main/resources/tp2-to-tp3-graphml.xslt --- @@ -0,0 +1,59 @@ + + + + + +http://graphml.graphdrawing.org

[GitHub] tinkerpop issue #595: TINKERPOP-1608 XSLT for converting GraphSON

2017-04-10 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/595 Would be nice if the transformation would work with standard tools like `xsltproc`.` ``` daniel@cube /projects/apache/tinkerpop (TINKERPOP-1608) TP2-to-TP3 GraphML XSLT $ xsltproc

[GitHub] tinkerpop issue #593: TINKERPOP-1665 Remove unittest from Gremlin-Python tes...

2017-04-10 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/593 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #583: TINKERPOP-1657 Provide abstraction to easily allow dif...

2017-04-10 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/583 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #569: TINKERPOP-1438: GraphManager becomes a customizable in...

2017-04-10 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/569 Well done. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tinkerpop issue #590: TINKERPOP-1664 StarVertexProperty will check meta-prop...

2017-04-07 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/590 VOTE: +1 And just like the Java compiler I really don't care whether it's `null == propertyKeyValues[i+1]` or `propertyKeyValues[i+1] == null`. --- If your project is set

[GitHub] tinkerpop issue #596: TINKERPOP-1443 API Checker

2017-04-06 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/596 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #588: TINKERPOP-1659 Docker uses custom maven settings.xml

2017-03-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/588 I recently got faster internet, so -1 on this. Just kidding :). Looks good to me and actually doesn't change anything in the "normal" workflow. VOTE: +1 --- If

[GitHub] tinkerpop issue #587: TINKERPOP-1642 Performance Enhancement on Mutating Tra...

2017-03-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/587 `docker/build.sh -t -n -i` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...

2017-03-29 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/589 `implementations-giraph` currently fails for me, but that happens frequently on my system (and has nothing to do with this PR). `the-traversal` looks good. VOTE: +1 --- If your

[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...

2017-03-29 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/589 I know, that's annoying and I think we mainly did it like this, because the local directory structure is different from the one that we publish. Might be a good idea to have a ticket for th

[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...

2017-03-29 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/589 Hmm, never seen it before, but since it's security related, Docker probably didn't get enough permissions..? Does the user, that is used to run the Docker daemon, have root privileges

[GitHub] tinkerpop issue #587: TINKERPOP-1642 Performance Enhancement on Mutating Tra...

2017-03-28 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/587 `docker/build.sh -t -n -i` failed. Got an NPE in `SparkGraphComputerGroovyProcessIntegrateTest`. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tinkerpop issue #578: TINKERPOP-1625: Improvements to has() related steps

2017-03-25 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/578 `docker/build.sh -t -n -i` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] tinkerpop issue #572: TINKERPOP-1652 Disable PathRetractionStrategy strategy...

2017-03-24 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/572 Ok, just tested, the TODO is still valid. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] tinkerpop issue #578: TINKERPOP-1625: Improvements to has() related steps

2017-03-24 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/578 Is it time to rebase this branch? Integration test just failed for me (`shouldDetachVertexWhenRemoved` in `Neo4j Gremlin`). --- If your project is set up for it, you can reply to this email and

[GitHub] tinkerpop issue #572: TINKERPOP-1652 Disable PathRetractionStrategy strategy...

2017-03-24 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/572 Sorry, I currently have integration tests running on another branch and thus can't test it, but the changes in this PR also fixed this `TODO`: https://github.com/apache/tinkerpop/blob/TINK

[GitHub] tinkerpop issue #574: TINKERPOP-1387: from and to modulators for path steps

2017-03-24 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/574 It's all working as expected now. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] tinkerpop issue #574: TINKERPOP-1387: from and to modulators for path steps

2017-03-23 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/574 I'm going to add a different example. Starting with an empty graph: ``` g = TinkerGraph.open().traversal() g.addV().property(id, "A").as("a"). addV(

[GitHub] tinkerpop issue #573: TINKERPOP-1303 Adds help option to :remote config comm...

2017-03-23 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/573 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #574: TINKERPOP-1387: from and to modulators for path steps

2017-03-23 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/574 ``` g.V().as("a").emit().repeat(both().as("b").simplePath().from("a").to("b")).path() ``` ...emits all paths, including cyclic paths. Without

[GitHub] tinkerpop issue #572: TINKERPOP-1652 Disable PathRetractionStrategy strategy...

2017-03-23 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/572 `docker/build.sh -t -i` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop pull request #572: TINKERPOP-1652 Disable PathRetractionStrategy s...

2017-03-16 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/572#discussion_r106552697 --- Diff: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/PathRetractionStrategyTest.java --- @@ -191,6

[GitHub] tinkerpop pull request #572: TINKERPOP-1652 Disable PathRetractionStrategy s...

2017-03-16 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/572#discussion_r106551449 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/PathRetractionStrategy.java --- @@ -72,7

[GitHub] tinkerpop issue #571: TINKERPOP-1504 Added the property key to events for ne...

2017-03-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/571 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #570: TINKERPOP-1644 Improve script compilation process and ...

2017-03-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/570 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop pull request #570: TINKERPOP-1644 Improve script compilation proce...

2017-03-13 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/570#discussion_r105754194 --- Diff: gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinGroovyScriptEngine.java --- @@ -149,19 +159,64

[GitHub] tinkerpop issue #567: TINKERPOP-1644 Improve script compilation syncronisati...

2017-03-07 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/567 This part: ``` if (clazz != null) { return clazz.get(); } clazz = CompletableFuture.supplyAsync(() -> loader.parseClass(script, generateScriptN

[GitHub] tinkerpop issue #567: TINKERPOP-1644 Improve script compilation syncronisati...

2017-03-07 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/567 Hmm, I haven't done any benchmarks, but this seem to be valid points. Just a thought: Would it help to have the class map be like `ManagedConcurrentValueMap> classMap`? --- If your pr

[GitHub] tinkerpop issue #567: TINKERPOP-1644 Improve script compilation syncronisati...

2017-03-07 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/567 Yep, missing some spaces here and there, but the code in general looks good. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] tinkerpop issue #566: TINKERPOP-1640: ComputerVerificationStrategy gives fal...

2017-03-01 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/566 `docker/build.sh -t -i` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop issue #560: TINKERPOP-1554: has(propertyKey) should have a corresp...

2017-02-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/560 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop pull request #560: TINKERPOP-1554: has(propertyKey) should have a ...

2017-02-27 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/560#discussion_r103189226 --- Diff: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/FilterRankingStrategyTest.java --- @@ -106,7

[GitHub] tinkerpop issue #534: TINKERPOP-1566 Kerberos authentication for gremlin-ser...

2017-02-25 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/534 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #564: TINKERPOP-1639 Support simple String operations

2017-02-24 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/564 It's true that this was just "would be cool" PR, that would have helped me in the short term. The general solution to this problem is proposed in https://issues.apache.org/jira/b

[GitHub] tinkerpop pull request #564: TINKERPOP-1639 Support simple String operations

2017-02-24 Thread dkuppitz
Github user dkuppitz closed the pull request at: https://github.com/apache/tinkerpop/pull/564 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] tinkerpop pull request #564: TINKERPOP-1639 Support simple String operations

2017-02-24 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/564 TINKERPOP-1639 Support simple String operations https://issues.apache.org/jira/browse/TINKERPOP-1639 Added support for simple String operations. `CountLocalStep`, `RangeLocalStep` and

[GitHub] tinkerpop pull request #563: TINKERPOP-1638 count() is optimized away in whe...

2017-02-23 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/563 TINKERPOP-1638 count() is optimized away in where() https://issues.apache.org/jira/browse/TINKERPOP-1638 Fixed a bug in `RangeByIsCountStrategy` that changed the meaning of inner

[GitHub] tinkerpop issue #562: TINKERPOP-1626: choose() is buggy in OLAP

2017-02-22 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/562 `docker/build.sh -t -i` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop issue #558: TINKERPOP-1631 Improvements to BindingsGremlinPlugin

2017-02-22 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/558 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #559: TINKERPOP-1627: LazyBarrierStrategy should not append ...

2017-02-16 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/559 `docker/build.sh -t -i` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop issue #555: TINKERPOP-1271: Refactor SparkContext creation and han...

2017-02-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/555 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #548: TINKERPOP-1589 Re-introduced CloseableIterator

2017-02-02 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/548 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #549: TINKERPOP-1617: Create a SingleIterationStrategy which...

2017-01-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/549 `docker/build.sh -t -i -n` succeeded. Manual tests were showing epic performance results. Best PR in a long time. VOTE: +1 --- If your project is set up for it, you can reply to this

[GitHub] tinkerpop issue #541: TINKERPOP-1560 Used ManagedConcurrentValueMap in Greml...

2017-01-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/541 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #546: TINKERPOP-1583: PathRetractionStrategy retracts keys t...

2017-01-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/546 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #546: TINKERPOP-1583: PathRetractionStrategy retracts keys t...

2017-01-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/546 This also fixes [TINKERPOP-1597](https://issues.apache.org/jira/browse/TINKERPOP-1597), but the test I've added can only be included in the 3.3.x line, right? --- If your project is set u

[GitHub] tinkerpop issue #543: Fixed and simplified 'language not supported' formatti...

2017-01-23 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/543 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #542: TINKERPOP-1610 Deprecated Groovy test suites

2017-01-23 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/542 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #537: TINKERPOP-1605 gremlin-console 3.2.3 -e can no longer ...

2017-01-21 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/537 Done. We already use `validate-distribution.sh` to test script evaluations, so it was easy to another test. https://github.com/apache/tinkerpop/commit

[GitHub] tinkerpop issue #537: TINKERPOP-1605 gremlin-console 3.2.3 -e can no longer ...

2017-01-21 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/537 Oh, that's a good idea! I will add that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop issue #537: TINKERPOP-1605 gremlin-console 3.2.3 -e can no longer ...

2017-01-21 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/537 Same here. I can't think of a way to test `gremlin.sh`. The script requires that the project was built, but tests can be run without building the project upfront. Going to merge this PR fo

[GitHub] tinkerpop issue #537: TINKERPOP-1605 gremlin-console 3.2.3 -e can no longer ...

2017-01-20 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/537 I don't know. The fix relies on a change in `gremlin.sh`. Is that testable? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] tinkerpop issue #538: TINKERPOP-1248: OrderGlobalStep should use local star ...

2017-01-19 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/538 Code looks good. Minor improvements were discussed in Slack. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] tinkerpop issue #539: TINKERPOP-1606: Refactor GroupStep to not have the red...

2017-01-19 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/539 `docker/build.sh -t -i` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop pull request #537: TINKERPOP-1605 gremlin-console 3.2.3 -e can no ...

2017-01-18 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/537 TINKERPOP-1605 gremlin-console 3.2.3 -e can no longer take paths relative to current working directory https://issues.apache.org/jira/browse/TINKERPOP-1605 ``` daniel@cube /tmp

[GitHub] tinkerpop issue #535: TINKERPOP-1601 LazyBarrierStrategy should not check is...

2017-01-18 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/535 So do you suggest a) to remove the assertions that check the metrics for specific steps or b) to find the indexes of all steps that were present before strategies were applied? --- If your

<    1   2   3   4   5   6   7   >