[GitHub] tinkerpop pull request #418: Fixed issue in NumberSerializer that could caus...

Github user leifurhauks commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/418#discussion_r79199796 --- Diff: gremlin-python/src/main/jython/gremlin_python/structure/io/graphson.py --- @@ -181,7 +181,7 @@ class NumberSerializer(GraphSONSerializer

[GitHub] tinkerpop pull request #418: Fixed issue in NumberSerializer that could caus...

Github user leifurhauks commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/418#discussion_r78990181 --- Diff: gremlin-python/src/main/jython/gremlin_python/structure/io/graphson.py --- @@ -181,7 +181,7 @@ class NumberSerializer(GraphSONSerializer

[GitHub] tinkerpop issue #357: TINKERPOP-1278 : Make implicit relative imports explic...

Github user leifurhauks commented on the issue: https://github.com/apache/tinkerpop/pull/357 Okay, should be good now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] tinkerpop issue #357: WIP TINKERPOP-1278 : Make implicit relative imports ex...

Github user leifurhauks commented on the issue: https://github.com/apache/tinkerpop/pull/357 Added WIP to the title of the PR while I sort out some silly mistakes I made with the conflict resolution... --- If your project is set up for it, you can reply to this email and have your

[GitHub] tinkerpop issue #357: TINKERPOP-1278 : Make implicit relative imports explic...

Github user leifurhauks commented on the issue: https://github.com/apache/tinkerpop/pull/357 Brought this branch up to date and fixed the code generators. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] tinkerpop pull request #360: revise a mutable default kwarg on GraphTraversa...

GitHub user leifurhauks opened a pull request: https://github.com/apache/tinkerpop/pull/360 revise a mutable default kwarg on GraphTraversalSource previously, in the signature of GraphTraversalSource.__init__, the bytecode kwarg had a default value of `Bytecode()`. In python

[GitHub] tinkerpop pull request #359: TINKERPOP-1278 : Removed long literal 'L' suffi...

GitHub user leifurhauks opened a pull request: https://github.com/apache/tinkerpop/pull/359 TINKERPOP-1278 : Removed long literal 'L' suffix The 'L' suffix on numeric literals is a syntax error in python3. As far as I can tell, the suffix on the literal i

[GitHub] tinkerpop pull request #357: Make implicit relative imports explicit

GitHub user leifurhauks opened a pull request: https://github.com/apache/tinkerpop/pull/357 Make implicit relative imports explicit Implicit relative imports break python3 compatibility. This commit replaces implicit relative imports with explicit relative imports, which are

[GitHub] tinkerpop pull request #345: add license boilerplate to __version__

GitHub user leifurhauks opened a pull request: https://github.com/apache/tinkerpop/pull/345 add license boilerplate to __version__ also import __version__ in setup.py instead of eval-ing it You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] tinkerpop issue #344: gremlin_python: generate/build/deps before tests

Github user leifurhauks commented on the issue: https://github.com/apache/tinkerpop/pull/344 Also, the generated `__version__.py` file fails the rat check. I think it needs to be either a) generated with the license boilerplate b) excluded from the rat check, or c

[GitHub] tinkerpop issue #344: gremlin_python: generate/build/deps before tests

Github user leifurhauks commented on the issue: https://github.com/apache/tinkerpop/pull/344 I think this should fix the CI test failures. On the subject of the python dependencies (aenum and requests), should they be bundled in the jar? aenum has a 3-clause BSD [license

[GitHub] tinkerpop pull request #344: gremlin_python: generate/build/deps before test...

GitHub user leifurhauks opened a pull request: https://github.com/apache/tinkerpop/pull/344 gremlin_python: generate/build/deps before tests Code generation is triggered by Maven before tests are run; dependencies (currently aenum, requests) are installed, and the generated

[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python

Github user leifurhauks commented on the issue: https://github.com/apache/tinkerpop/pull/340 I believe the failures are due to the fact that the aenum package (introduced in 8ee2904 ) is not installed in the CI environment. As a result, the gremlin_python module errors on import

[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python

Github user leifurhauks commented on the issue: https://github.com/apache/tinkerpop/pull/340 @okram , I realized the current implementation of bindings as dicts is breaking 2/3 compatibility. It also makes it bit hairy to extract just the key in `RawExpression`. I would

[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python

Github user leifurhauks commented on the issue: https://github.com/apache/tinkerpop/pull/340 > This is just for the GeoPoint-style adding classes? More generally, it can be used to create expressions that make use of APIs, presumably provided by the graph vendor, that are

[GitHub] tinkerpop pull request #341: add aenum dependency to gremlin_python's setup....

GitHub user leifurhauks opened a pull request: https://github.com/apache/tinkerpop/pull/341 add aenum dependency to gremlin_python's setup.py You can merge this pull request into a Git repository by running: $ git pull https://github.com/leifurhauks/incubator-tink

[GitHub] tinkerpop pull request #340: add RawExpression to gremlin_python

GitHub user leifurhauks opened a pull request: https://github.com/apache/tinkerpop/pull/340 add RawExpression to gremlin_python As described on dev@tinkerpop.apache.org thread gremlin_python GLV You can merge this pull request into a Git repository by running: $ git pull https