Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/800#discussion_r169364908
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -1073,7 +1073,8 @@ The following table describes the various
configuration options
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/800#discussion_r169302646
--- Diff: CHANGELOG.asciidoc ---
@@ -25,6 +25,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/800#discussion_r169305818
--- Diff:
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java
---
@@ -293,6 +312,21 @@ private static
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/800#discussion_r169302920
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -1073,7 +1073,8 @@ The following table describes the various
configuration options
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/800#discussion_r169304285
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/AbstractChannelizer.java
---
@@ -147,7 +149,12 @@ public void init(final
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/795
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/794
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/786
Hmm... Looks like it is reproducible on tp32.
## 3.2.7
```
apache-tinkerpop-gremlin-console-3.2.7]$ ./bin/gremlin.sh
\,,,/
(o o)
-oOOo-(3
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/791
Yeah, ok, apparently I never actually switched branches. Time to get some
coffee
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/791
Those tests pass? It doesn't seem to work for me on the cli.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/789
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/786
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/784
VOTE +1
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/784#discussion_r163529404
--- Diff: docs/src/dev/io/graphson.asciidoc ---
@@ -4066,11 +4075,12 @@ The following `RequestMessage` is an example of a
sessionless request for a
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/784#discussion_r163529843
--- Diff: docs/src/dev/io/graphson.asciidoc ---
@@ -187,8 +180,7 @@ file.withWriter { writer ->
writer.write(toJson(msg, "Sessionl
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/784#discussion_r163529709
--- Diff: docs/src/dev/io/graphson.asciidoc ---
@@ -75,8 +72,7 @@ file.withWriter { writer ->
writer.write(toJson(msg, "Sessionless Eva
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/784#discussion_r163528577
--- Diff: docs/src/dev/io/graphson.asciidoc ---
@@ -1279,7 +1270,7 @@ The following `RequestMessage` is an example of a
sessionless request for a scri
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/781
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/778
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/775
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@spmallette delete all of your images and then rebuild everything with
`docker/build.sh -d |tee /tmp/console.log` and send me that output file. I
wonder if it's choking on some python dow
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/767
Is it just the wrong expected exception in the test?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/767
Failed docker...
```
docker/build.sh -i -t
[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
13.448 s <<< FAIL
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/773
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@spmallette did you save your console log?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/771
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Hmm.. there doesn't seem to be much difference. Are you deleting both the
hadoop and base images?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Try rebuilding the docker images using master.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/767
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/768
I don't think we should break the interface. I think these should be new
methods and `@deprecate` the old ones. The old methods can call the new methods.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Excellent!
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
In the 'Console' tab, muli-line statements work. They have the `\`
continuation after the callout. However, on the 'language' tab, these seem to
be lost thus copy-paste m
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@dkuppitz I pushed a CTR fix for invisibility to tp32/master. This fixes
the screen from being rendered to pixels wide. It didn't help the code
block language popup though.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@dkuppitz my css skills are close to nil. what little i did play with it,
i'm not sure it looks any better. and in the course of doing so, I've grown
accustomed to it.
I
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Just what I was afraid of... the tabs look just like they do in the
screenshots. And I don't mean that in a good way :smile:
Seriously, this is fantastic. Multi-line work
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@dkuppitz I did see that. There was a dep added to the image. I have that
rebuilding now. Will let you know the results.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
What about for those of us unable to build it?
```
sh docker/build.sh -d
* source: /usr/src/tinkermem/docs/src/recipes/olap-spark-yarn.asciidoc
target
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/765
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/763
Fixed test only.
Tests pass.
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/763
Yeah, I didn't initially see it in tp32. This is not the right approach
anyway. Will push an update.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/763
`docker/build.sh -t` BUILD SUCCESS
VOTE +1
---
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/763
TINKERPOP-1848 python dates should be UTC in and out
https://issues.apache.org/jira/browse/TINKERPOP-1848
You can merge this pull request into a Git repository by running:
$ git
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/750
Updated the PR to tp32 base
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/750
[INFO]
[INFO] BUILD SUCCESS
[INFO
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/750
Indeed it was. Rebase on tp32. Building..
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/747
@jorgebay On which OS do you get the test errors?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/750
[INFO]
[INFO] BUILD SUCCESS
[INFO
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/750
TINKERPOP-1835 Bump Netty 4.0.53
https://issues.apache.org/jira/browse/TINKERPOP-1835
Latest bug-fix release. No new deps.
Building...
You can merge this pull request into
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/741
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/745
`mvn -pl tinkergraph-gremlin -DskipIntegrationTests=false -am clean
install` build SUCCESS
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/745
@mpollmeier Sorry, I thought that `putIfAbsent()` returned the current map
but it returns old mapping or `null` hence the `NPEs`. Should be:
```java
protected void put(final String
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/745
The race condition is in `put()` and it's used elsewhere. It would make
more sense to fix `put()` to be thread-safe. Then we can keep
`parallelStream()`
```
Map>
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/744
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/742
@spmallette Updated NOTICE with latest version. No new deps.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/742
```
$ sh docker/build.sh -i -t -n
...
[INFO]
[INFO] BUILD SUCCESS
[INFO
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/742
TINKERPOP-1824 Bump netty to 4.0.52
https://issues.apache.org/jira/browse/TINKERPOP-1824
Latest bug-fix release.
VOTE +1
You can merge this pull request into a Git
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/739
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/715
@mpollmeier Making it official. Please update the title to start with
`TINKERPOP-1822`
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/737
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/736
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/732
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/709
Looks good.
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/727
Thanks.
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/727
@boliza I created a JIRA issue. Please review it. Can you change the title
to include 'TINKERPOP-1796' and put the link
'https://issues.apache.org/jira/browse/TINKERPOP-179
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
That's fine. Now I know what to look for ;-)
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
@dkuppitz It was change 37a2471932229ae6a4c1f5e5f3f2d3d25bbf7fd4 that
introduced dotnet that required the need to rebuild the images.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
This makes reviewing so much easier!
VOTE +1
If anyone is interested, these are the times (in seconds) for building each
doc:
15 /usr/src/tinkermem/docs/src/recipes/duplicate
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
Ignore that. Somehow my branch was reset to master. Rebuilding...
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
Hmm.. even Reference Doc isn't local. Thought it was the first time I
looked at it.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
I ended up using a local copy of hadoop 2.7.2 to complete my docker rebuild.
Anyway, 'Reference Documentation' is now a local link but everything else
still
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
[Started a
thread](https://lists.apache.org/thread.html/4c8f832ce0640230614989f4d60bfd0078aa69a0e11cfd197015fde1@%3Cdev.tinkerpop.apache.org%3E)
to try to solve my issues.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
Couldn't build image tinkerpop:hadoop-2.7.2 because that version is no
longer on mirrors. Current version is 2.7.4.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
Docker images are building this morning. Yay.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
Do we need dotnet stuff now to build docs? I am confused by
http://tinkerpop.apache.org/docs/3.2.6/dev/developer/#dotnet-environment
How do I set this up in docker? Do I need to rebuild
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/724
Nice. VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/714
Tests in the jira ticket work as expected.
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/718
VOTE +1
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/720#discussion_r140465221
--- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc ---
@@ -95,6 +95,19 @@ In `gremlin-test` there is a new `GraphHelper` class
that has a
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/705
VOTE +1
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/705#discussion_r139378324
--- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc ---
@@ -88,6 +88,11 @@ to the list of locally computed clauses.
See
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/705
That dependency cycle is bad. It should probably be put in `gremlin-test`.
Maybe even make it a [Graph
Feature](http://tinkerpop.apache.org/docs/current/reference/#_features) -
Cloning.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/703
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/707
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/707
Did it fix https://issues.apache.org/jira/browse/TINKERPOP-1509 ?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/699
VOTE +1
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/699#discussion_r136983503
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_O_Traverser.java
---
@@ -62,10 +62,12 @@ public void
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/705
This doesn't look like a deep copy e.g. modifying a property would be
reflected in both graphs. Which may be fine. I think any limitations should be
noted in the clone method comment.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/702
`docker/build.sh -i -t -n` SUCCESS
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/701
`docker/build.sh -i -t -n` SUCCESS
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
All better now. Verified new index and cluster property settings.
VOTE +1 again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
I did a rebase to master and messed it up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
`docker/build.sh -i -t -n` SUCCESS
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/694
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/694
Ah, I see now. You've added line continuations `\` on the mid-traversals.
Excellent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/694
Looks like it works for some but not all.
The very first one on the reference page didn't work:
Graph graph = TinkerGraph.open(); (1)
Looks like there are ones with circle
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/692
@spmallette docs success
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/692
@spmallette Confirmed no new deps in zip.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/692
TINKERPOP-1749 Bump to Netty 4.0.50
https://issues.apache.org/jira/browse/TINKERPOP-1749
Many SSL updates, bug fixes.
`docker/build.sh -i -t -n` SUCCESS
VOTE +1
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/687
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/688
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
101 - 200 of 390 matches
Mail list logo
