[GitHub] tinkerpop pull request #875: TINKERPOP-1967 Add a connectedComponent() step ...

2018-06-13 Thread vtslab
Github user vtslab closed the pull request at: https://github.com/apache/tinkerpop/pull/875 ---

[GitHub] tinkerpop issue #875: TINKERPOP-1967 Add a connectedComponent() step - vtsla...

2018-06-13 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/875 PR is malformed due to problems in master. I close this one and prepare a new PR with the same commits. ---

[GitHub] tinkerpop pull request #877: Tinkerpop 1967 Add a connectedComponent() step ...

2018-06-13 Thread vtslab
GitHub user vtslab opened a pull request: https://github.com/apache/tinkerpop/pull/877 Tinkerpop 1967 Add a connectedComponent() step - vtslab contribution2 This merges the new OLAP step into a corrected version of the old recipe. I did not adapt the release-update file, which

[GitHub] tinkerpop pull request #875: TINKERPOP-1967 Add a connectedComponent() step ...

2018-06-10 Thread vtslab
GitHub user vtslab opened a pull request: https://github.com/apache/tinkerpop/pull/875 TINKERPOP-1967 Add a connectedComponent() step - vtslab contribution This merges the new OLAP step into a corrected version of the old recipe. I did not adapt the release-update file, which

[GitHub] tinkerpop pull request #:

2018-06-10 Thread vtslab
Github user vtslab commented on the pull request: https://github.com/apache/tinkerpop/commit/06fdb7d1ac319c7f8afc115a54aa535e8078039b#commitcomment-29309765 You might want to include the ConnectedComponentVertexProgram into the imports section of gremlin-console, as was done

[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...

2017-10-18 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 I am fine with the PR now. Build server needs a check, though. ---

[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...

2017-10-17 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 Please do not merge yet, I just noticed two wrong links. I will correct this later in the week together with the tp33/master branch. Marc ---

[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...

2017-10-16 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 Thanks @pluradj for going the extra mile. ---

[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...

2017-10-12 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 Hi @spmallette, No problem, but it is unclear to me whether JIRA will also add items to the list then, apart from adding the section headings. Where will my two change items appear, for which

[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...

2017-10-12 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 Your welcome. Thanks all for the initial suggestions on the dev list and the review comments above. ---

[GitHub] tinkerpop pull request #721: TINKERPOP-1786 Recipe and missing manifest item...

2017-10-02 Thread vtslab
Github user vtslab commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/721#discussion_r142223415 --- Diff: hadoop-gremlin/conf/hadoop-gryo.properties --- @@ -29,8 +29,8 @@ gremlin.hadoop.outputLocation=output spark.master=local[4

[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...

2017-09-26 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 Could I assume a pseudo-hadoop cluster present during the integration test phase? I thought only the asciidoc processing had that. Anyway, breaking the spark-yarn option will be noticed through

[GitHub] tinkerpop pull request #722: TINKERPOP-1786 Recipe and missing manifest item...

2017-09-24 Thread vtslab
GitHub user vtslab opened a pull request: https://github.com/apache/tinkerpop/pull/722 TINKERPOP-1786 Recipe and missing manifest items for Spark on Yarn (TP33) You can merge this pull request into a Git repository by running: $ git pull https://github.com/vtslab/incubator

[GitHub] tinkerpop pull request #721: TINKERPOP-1786 Recipe and missing manifest item...

2017-09-24 Thread vtslab
GitHub user vtslab opened a pull request: https://github.com/apache/tinkerpop/pull/721 TINKERPOP-1786 Recipe and missing manifest items for Spark on Yarn (TP32) You can merge this pull request into a Git repository by running: $ git pull https://github.com/vtslab/incubator

[GitHub] tinkerpop issue #534: TINKERPOP-1566 Kerberos authentication for gremlin-ser...

2017-02-25 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/534 A good catch by @robertdale indeed, about the bytecode requests. I was not even aware those were human readable. A proposal: include the audit logging of bytecode requests in a new Jira ticket

[GitHub] tinkerpop pull request #534: TINKERPOP-1566 Kerberos authentication for grem...

2017-02-21 Thread vtslab
Github user vtslab commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/534#discussion_r102313638 --- Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpBasicAuthenticationHandler.java --- @@ -92,6 +102,13 @@ public

[GitHub] tinkerpop pull request #534: TINKERPOP-1566 Kerberos authentication for grem...

2017-02-20 Thread vtslab
Github user vtslab commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/534#discussion_r102095814 --- Diff: docs/src/reference/gremlin-applications.asciidoc --- @@ -1035,6 +1035,7 @@ The following table describes the various YAML configuration options

[GitHub] tinkerpop issue #534: TINKERPOP-1566 Kerberos authentication for gremlin-ser...

2017-02-19 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/534 Thanks, Stephen, for guiding me through this so far. Once this gets merged, I'd like to take a look at authentication with the python driver. --- If your project is set up for it, you can reply

[GitHub] tinkerpop issue #534: TINKERPOP-1566 Kerberos authentication for gremlin-ser...

2017-02-02 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/534 I interpreted almosta week of silence as consensus on the gremlin-driver behavior, so I made the following changes: - restored gremlin-driver's Handler (checkout from master) - added a ToDo

gremlin-python test SimpleAuthenticator

2017-01-30 Thread vtslab
While trying to get gremlin-python to work with the proposed Kerberos authenticator for gremlin-server (https://github.com/apache/tinkerpop/pull/534), I noticed that gremlin-python's pom.xml starts a gremlin-server with SimpleAuthenticator (port 45941) but no tests seem to use it, nor are

[GitHub] tinkerpop issue #534: TINKERPOP-1566 Kerberos authentication for gremlin-ser...

2017-01-26 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/534 Hi @mike-tr-adamson, I am glad you entered the discussion. I think your main point is valid, namely that there are circumstances, pointed out by you, when gremlin-driver should select the GSSAPI

[GitHub] tinkerpop issue #534: TINKERPOP-1566 Kerberos authentication for gremlin-ser...

2017-01-20 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/534 OK, thanks, I'll see to it. The downside of the third option was implicit: it changes the driver code which is in production everywhere. But that´s why we do this work in the 3.3.x line and I

[GitHub] tinkerpop issue #534: TINKERPOP-1566 Kerberos authentication for gremlin-ser...

2017-01-20 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/534 Hi, I am working on the two failing integration tests. It can be fixed in three ways: 1. just hide the symptoms and also allow a GSSException for a test that should fail anyway: ugly

[GitHub] tinkerpop issue #534: TINKERPOP-1566 Kerberos authentication for gremlin-ser...

2017-01-18 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/534 Yes, I mentioned these failing tests in the PR text above. I suspect that the java security libs just pick up the krb5.conf file from the test resources "without asking". It means the

[GitHub] tinkerpop issue #533: TINKERPOP-1600 Added base64 encoded string to sasl cha...

2017-01-17 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/533 I agree with your explanation that a byte array returned from gremlin server as the result of a query does not crash gremlin driver (and I also checked it manually). Sorry for the confusion

[GitHub] tinkerpop issue #533: TINKERPOP-1600 Added base64 encoded string to sasl cha...

2017-01-17 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/533 Just undoing [this commit](https://github.com/apache/tinkerpop/pull/534/commits/62648242c6576b020d2dd2933b89b9d69e87fed0) in TINKERPOP-1566 and merging in TINKERPOP-1600 does not work for me, see

[GitHub] tinkerpop issue #533: TINKERPOP-1600 Added base64 encoded string to sasl cha...

2017-01-16 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/533 While this solves the issue for byte[] returned from Sasl, I can still crash the driver by adding a byte[] as a vertex property and ask for the result: gremlin> g.V(1).property('test1', 'te

[GitHub] tinkerpop issue #533: TINKERPOP-1600 Added base64 encoded string to sasl cha...

2017-01-16 Thread vtslab
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/533 This attacks the same issue as I had in PR TINKERPOP-1566 Kerberos: [https://github.com/apache/tinkerpop/pull/534/commits/62648242c6576b020d2dd2933b89b9d69e87fed0] I am fine with your

[GitHub] tinkerpop pull request #534: Tinkerpop 1566

2017-01-16 Thread vtslab
GitHub user vtslab opened a pull request: https://github.com/apache/tinkerpop/pull/534 Tinkerpop 1566 This PR includes three items (as stated in the changelog): 1 Added Kerberos authentication to `gremlin-server` for websockets and nio transport. 2 Added audit logging