[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...

2016-06-09 Thread SergeVil
Github user SergeVil commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/333 Sorry, I did not push it correct, I believe. Thank you for your help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...

2016-06-08 Thread SergeVil
Github user SergeVil commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/333 I copied the xml file to a new name and added the test that processes a new xml. Recompiled everything, and I see this file in three places: (incubator-tinkerpop)$ find ..

[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...

2016-06-07 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/333 Travis still seems to be having a problem. You can see the "red X" on the Travis job in github - just click the "Details" link next to it to see the problem being reported. --- If

[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...

2016-06-07 Thread SergeVil
Github user SergeVil commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/333 Will take a look On Tue, Jun 7, 2016 at 2:18 PM, stephen mallette wrote: > Note that your PR is failing for Travis: > >

[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...

2016-06-07 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/333 Note that your PR is failing for Travis: https://travis-ci.org/apache/incubator-tinkerpop/builds/135940598#L6936 Any idea what's wrong? --- If your project is set

[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...

2016-06-07 Thread SergeVil
Github user SergeVil commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/333 > Why waste the object creation using Optional? Instead, in one line, do: > edgeOutVertex.addEdge(null == edgeLabel ? Edge.DEFAULT_LABEL : edgeLabel, edgeInVertex, propsReady);