[GitHub] tinkerpop issue #336: TINKERPOP-1320 fix GremlinGroovyScriptEngineFileSandbo...

2016-07-06 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/336 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #336: TINKERPOP-1320 fix GremlinGroovyScriptEngineFileSandbo...

2016-06-30 Thread pluradj
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/336 @spmallette I'll get this finished up before the weekend --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] tinkerpop issue #336: TINKERPOP-1320 fix GremlinGroovyScriptEngineFileSandbo...

2016-06-16 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/336 `gremlin-core` just have tests that need the some of the same exact functions that are in `gremlin-test`, but the dependencies are such that `gremlin-core` can't use the `TestHelper` in

[GitHub] tinkerpop issue #336: TINKERPOP-1320 fix GremlinGroovyScriptEngineFileSandbo...

2016-06-16 Thread pluradj
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/336 Can you expand on that more, re: the duplication on `TestHelper.java`? I'd bumped into the two classes previously but haven't spent any time trying to figure out the reason why there are two of

[GitHub] tinkerpop issue #336: TINKERPOP-1320 fix GremlinGroovyScriptEngineFileSandbo...

2016-06-16 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/336 I didn't re-test this but both travis builds are good and the code looks right. Just a side note - @pluradj I didn't review this but note that we have a bit of an ugly reality where