[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-07 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/352 Code looks good, `docker/build.sh -t -i -n` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread ramzioueslati
Github user ramzioueslati commented on the issue: https://github.com/apache/tinkerpop/pull/352 Successful pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread ramzioueslati
Github user ramzioueslati commented on the issue: https://github.com/apache/tinkerpop/pull/352 Will do right away. For the record here is the stacktrace: ``` Running org.apache.tinkerpop.gremlin.server.GremlinServerAuthOldIntegrateTest [WARN]

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/352 nice find @robertdale - i pushed a fix that removed that assert. that whole test case is deprecated anyway, so i'm not too worried about it. @ramzioueslati care to pull the branch

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/352 Can you provide the stacktrace (from the surefire report)? What OS, java versions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread ramzioueslati
Github user ramzioueslati commented on the issue: https://github.com/apache/tinkerpop/pull/352 I tried 3 times with the same result --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/352 uh - i wasn't aware of any kerberos setup required. does that happen consistently? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread ramzioueslati
Github user ramzioueslati commented on the issue: https://github.com/apache/tinkerpop/pull/352 Hi Stephen I tried to run the test : ``` mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false ``` It failed : ``` Failed

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-01 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/352 nice @robertdale - thanks for taking the time to review. always a big help when folks look over the PRs and provide feedback. --- If your project is set up for it, you can reply to this email

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-01 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/352 Just pushed what I think is the final fixes for this issue. Note that this branch also contains the fix for https://issues.apache.org/jira/browse/TINKERPOP-1351 Please feel

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-06-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/352 wow - now this one is failing: ```text GremlinDriverIntegrateTest.shouldBeThreadSafeToUseOneClient:994 ``` only fails when run in maven - works in intellij on its own -

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-06-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/352 @robertdale i think i fixed the problem. i've been hunting that issue forever, but have never been able to witness it with any kind of consistent nature to unravel the problem. i guess my

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-06-30 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/352 Using (have to ignore hadoop/spark) mvn clean install -pl