Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/355
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/355
Clean changes. VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/355
Yea, lots of issues in this code area.
`enforceHomogenousCollectionIfPresent` also has the potential to throw NPE's
(if the first element of a non-empty collection is `null`). I will create
anot
Github user BrynCooke commented on the issue:
https://github.com/apache/tinkerpop/pull/355
Also the conversion of the collection to an array is dangerous. Who knows
what the collection is actually backed by? It should use an iterator and get
the first element if it exists.
---
If yo
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/355
I just implemented my proposed changes. Now we no longer get exceptions,
but unexpected results:
```
gremlin> g.V().hasId(within(new ArrayList()))
==>v[1]
==>v[2]
==>v[3]
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/355
I noticed a flaw while reading through the code. It was not introduced by
this PR, but it's probably a good time to get it from the table.
```
gremlin> g = TinkerFactory.createModern(