[GitHub] tinkerpop issue #440: TINKERPOP-1044: Gremlin server REST endpoint - Add Exc...

2016-10-06 Thread vrkrishn
Github user vrkrishn commented on the issue: https://github.com/apache/tinkerpop/pull/440 Would it be possible to push this change then and add the other functionality as a different ticket? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tinkerpop issue #440: TINKERPOP-1044: Gremlin server REST endpoint - Add Exc...

2016-10-06 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/440 We intend to freeze the code base for release of 3.2.3 (and 3.1.5) in a couple of days. If you'd like to see this merged in time for 3.2.3, we'd need to have your changes pretty soon for

[GitHub] tinkerpop issue #440: TINKERPOP-1044: Gremlin server REST endpoint - Add Exc...

2016-10-05 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/440 Glad that's working. Did you still intend to make the fix for the other channelizers in `AbstractEvalOpProcessor`? As for titan, i guess you would build this branch of tinkerpop with

[GitHub] tinkerpop issue #440: TINKERPOP-1044: Gremlin server REST endpoint - Add Exc...

2016-10-05 Thread vrkrishn
Github user vrkrishn commented on the issue: https://github.com/apache/tinkerpop/pull/440 Luckily I was able to spin up a Linux VM and run the integration tests Tests run: 31, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 162.807 sec - in

[GitHub] tinkerpop issue #440: TINKERPOP-1044: Gremlin server REST endpoint - Add Exc...

2016-10-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/440 Sorry for the trouble on running the tests. It's not terribly friendly to Windows as we don't have any core devs who use that OS. Hopefully you can figure out how to get the tests working.

[GitHub] tinkerpop issue #440: TINKERPOP-1044: Gremlin server REST endpoint - Add Exc...

2016-10-03 Thread vrkrishn
Github user vrkrishn commented on the issue: https://github.com/apache/tinkerpop/pull/440 I'm having trouble running the tests on my Windows Box (the tests fail on different modules so I don't think that this change caused the failures). I also see that the CI build passed which

[GitHub] tinkerpop issue #440: TINKERPOP-1044: Gremlin server REST endpoint - Add Exc...

2016-09-29 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/440 First of all, thanks for taking the time to do this. [TINKERPOP-1044](https://issues.apache.org/jira/browse/TINKERPOP-1044) was less about REST and more about the Gremlin Server protocol but

[GitHub] tinkerpop issue #440: TINKERPOP-1044: Gremlin server REST endpoint - Add Exc...

2016-09-28 Thread rjbriody
Github user rjbriody commented on the issue: https://github.com/apache/tinkerpop/pull/440 > there should be some common response between all channelizer methods that is defined in only one location Could be. I'm not familiar enough with the channelizers to know for sure. I'm

[GitHub] tinkerpop issue #440: TINKERPOP-1044: Gremlin server REST endpoint - Add Exc...

2016-09-28 Thread rjbriody
Github user rjbriody commented on the issue: https://github.com/apache/tinkerpop/pull/440 Nice work. Looks good for the REST endpoint. I'm wondering - what about other endpoints such as websocket - shouldn't they be consistent? Also, I would expect the same information to be