[GitHub] tinkerpop issue #554: TINKERPOP-1599 implement real gremlin-python driver

2017-02-28 Thread davebshow
Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/554 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #554: TINKERPOP-1599 implement real gremlin-python driver

2017-02-27 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/554 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #554: TINKERPOP-1599 implement real gremlin-python driver

2017-02-27 Thread davebshow
Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/554 I think this is ready. Anyone want to be a third reviewer for this? VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] tinkerpop issue #554: TINKERPOP-1599 implement real gremlin-python driver

2017-02-21 Thread davebshow
Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/554 Well, I've made my last review of this code and pushed a bit of cleanup and a small fix. IMHO, this is ready to be merged. I'll wait to see if there are any more comments or feedback before

[GitHub] tinkerpop issue #554: TINKERPOP-1599 implement real gremlin-python driver

2017-02-15 Thread davebshow
Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/554 Ok, I have now rebased ad added docs to both reference and upgrading. I also reviewed the old implementation and made a couple small fixes for consistency. I also added standard op processor

[GitHub] tinkerpop issue #554: TINKERPOP-1599 implement real gremlin-python driver

2017-02-15 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/554 I think that make sense - just add a "Connecting via Python" section perhaps. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] tinkerpop issue #554: TINKERPOP-1599 implement real gremlin-python driver

2017-02-15 Thread davebshow
Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/554 Yeah I figured we would need to add docs. Where should I add to the reference docs? Maybe in [Gremlin

[GitHub] tinkerpop issue #554: TINKERPOP-1599 implement real gremlin-python driver

2017-02-15 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/554 @davebshow now that code freeze is lifted i think you should probably rebase this PR. Also, two documentation related items: 1. This works needs a changelog entry - it was probably