[GitHub] tinkerpop issue #565: TINKERPOP-1612 Remove gremlin-groovy-test

2017-03-03 Thread davebshow
Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/565 `docker/build.sh -t -n -i` succeeded. VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] tinkerpop issue #565: TINKERPOP-1612 Remove gremlin-groovy-test

2017-03-02 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/565 This is an insane amount of work you did here. I like it. We now have put Gremlin-Groovy and the same standing as Gremlin-Python. They are both simply dialects (variants) of Gremlin. This is

[GitHub] tinkerpop issue #565: TINKERPOP-1612 Remove gremlin-groovy-test

2017-03-01 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/565 Test suite passes. Still doing a code review. Got stuck with the `ComputerVerificationStrategy` merge this afternoon... --- If your project is set up for it, you can reply to this email and have

[GitHub] tinkerpop issue #565: TINKERPOP-1612 Remove gremlin-groovy-test

2017-03-01 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/565 I just pushed a fix on `tp32` which has merged forward to this branch. That should allow it to build for you now @okram - can you give it another shot? --- If your project is set up for it,

[GitHub] tinkerpop issue #565: TINKERPOP-1612 Remove gremlin-groovy-test

2017-03-01 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/565 Gremlin-Python has failed twice for me locally now. :/ I'll keep reviewing the code aspects of Groovy. ``` [WARNING] Request for side-effect keys on