[GitHub] tinkerpop issue #716: TINKERPOP-1785 Added strong name signing for .NET comp...

2017-09-20 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/716 `dotnet pack gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj -c Release` generates the package containing with assembly with the intended attributes. VOTE +1 ---

[GitHub] tinkerpop issue #716: TINKERPOP-1785 Added strong name signing for .NET comp...

2017-09-20 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/716 We forgot to consider that, as we are strong named assembly, we must avoid changing the assembly version for patch versions to minimize the need of user-defined binding redirects. In

[GitHub] tinkerpop issue #716: TINKERPOP-1785 Added strong name signing for .NET comp...

2017-09-18 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/716 ohh - smart. no wonder the PR looks "wrong". ---

[GitHub] tinkerpop issue #716: TINKERPOP-1785 Added strong name signing for .NET comp...

2017-09-18 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/716 The strong name for Gremlin.Net.dll assembly (generated using Gremlin.Net.csproj) is missing, we should add it in the template as well. ---