Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/721
^
[solved](https://github.com/apache/tinkerpop/commit/a86097d0823397f0485566e8fd5def7a82fb32f3).
The `execute()` command was just missing a `waitFor()`, which sometimes led to
a missing or
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/721
I know, this PR was closed long ago, but I just ran into this issue when
building the docs using Docker:
```
* source: /usr/src/tinkerpop/docs/src/recipes/olap-spark-yarn.asciidoc
Github user vtslab commented on the issue:
https://github.com/apache/tinkerpop/pull/721
I am fine with the PR now. Build server needs a check, though.
---
Github user vtslab commented on the issue:
https://github.com/apache/tinkerpop/pull/721
Please do not merge yet, I just noticed two wrong links. I will correct
this later in the week together with the tp33/master branch.
Marc
---
Github user vtslab commented on the issue:
https://github.com/apache/tinkerpop/pull/721
Thanks @pluradj for going the extra mile.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/721
There are two aspects to CHANGELOG - (1) developer notes on what was done
and (2) JIRA tickets. You are really just responsible for (1) - it is typically
a more descriptive explanation of
Github user vtslab commented on the issue:
https://github.com/apache/tinkerpop/pull/721
Hi @spmallette,
No problem, but it is unclear to me whether JIRA will also add items to the
list then, apart from adding the section headings. Where will my two change
items appear, for which
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/721
Added a minor note about CHANGELOG, but pending that little fix:
VOTE +1
---
Github user vtslab commented on the issue:
https://github.com/apache/tinkerpop/pull/721
Your welcome. Thanks all for the initial suggestions on the dev list and
the review comments above.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/721
Would be nice to see this PR rebased on the current `tp32/` as it won't
build in Docker in its current state.
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/721
VOTE +1
---
Github user vtslab commented on the issue:
https://github.com/apache/tinkerpop/pull/721
Could I assume a pseudo-hadoop cluster present during the integration test
phase? I thought only the asciidoc processing had that. Anyway, breaking the
spark-yarn option will be noticed through
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/721
This is good stuff. Is it possible to write a test case for the work? Also,
can you fix your documentation so its `TinkerPop` not `Tinkerpop` (camel case).
---
13 matches
Mail list logo
