[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-12 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/767 VOTE: +1 ---

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-11 Thread krlohnes
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/767 I added in the CHANGELOG entry ---

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-11 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/767 VOTE +1 ---

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-10 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/767 I've seen this kind of thing happen before and we usually handle the dual exception the way that you have it there by catching either exception or catching generically and asserting either one

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-09 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/767 Is it just the wrong expected exception in the test? ---

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-09 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/767 Failed docker... ``` docker/build.sh -i -t [ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 13.448 s <<< FAILURE! - in

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-09 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/767 @dkuppitz or @robertdale could you guys give this a try? maybe it's just me for some reason? ---

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-09 Thread krlohnes
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/767 @spmallette I rebased on top of upstream/master and ran `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false` And it was successful ```

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-09 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/767 when i do: ```text $ mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false ``` i get this failure consistently: ```text [ERROR]

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-09 Thread krlohnes
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/767 @spmallette I'm not seeing any integration test failures. ``` [INFO] [INFO] --- maven-failsafe-plugin:2.20:verify (verify-integration-test) @ gremlin-server --- [INFO]

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-08 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/767 I'm getting test failures when running Gremlin Server integration tests. @krlohnes is that a problem for you? ---

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/767 Ok - thanks for your thoughts. I can't say we have a release date for 3.3.2 in mind yet. I'd say it was a couple of months away at least based on how we typically do releases. ---

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-04 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/767 VOTE +1 ---

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-04 Thread krlohnes
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/767 @spmallette As far as criticality, that's fairly dependent on the usage of custom authentication handlers in the wild. It's not impacting my current work or any of the work I did at IBM Compose

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/767 a bad merge - thanks. how bad/critical do you rate this problem? ---

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-04 Thread krlohnes
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/767 @spmallette Yeah, it looks like it happened with the `Merge branch TP32` commit. If you look

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

2018-01-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/767 Hi @krlohnes - thanks for this. Did you happen to research the point where this regression occurred? ---