Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/894
Thanks for handling the `.gitignore`. I also reviewed the code and it looks
good to me.
So: VOTE +1
---
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/894
Code & tests LGTM.
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/894
Yep, done. I added an entry in the root `.gitignore` file and added another
`.gitignore` file in `docker/hadoop/`. The two auto-generated `Dockerfile`s
will be ignored from now on.
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/894
Looks like I accidentally added that `Dockerfile`. I should have checked
more carefully what my commit added but shouldn't we prevent that from
happening again with an entry in the
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/894
By the way, the `Dockerfile`, that's removed by this PR, has nothing to do
with the PR, but the file is an autogenerated file that shouldn't be in the
repository.
---
