Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
PR for this is now on #952
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@mattallenuk I figured out what was going on. The `EnumValue` was being
interpreted as a `Map` when serializing to GraphSON. The change is pretty
trivial, but I have a bunch of other little
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
"gremlin-groovy" is fine. The server should default to that if the argument
isn't present.
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette I can confirm that this test works for bytecode submission so
possibly an issue in the way the bindings are being submitted? Should the
language parameter be gremlin-groovy or
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette Ok, have pushed the changes along with the documentation
changes we'd discussed. Hopefully it's an easy fix.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
It works with Java and GraphSON 2.0:
```text
gremlin> cluster = Cluster.build().serializer("GRAPHSON_V2D0").create()
==>localhost/127.0.0.1:8182
gremlin> client =
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette Ok so your above code runs fine and returns a value. It appears
that my call to g.V(1).property() is not liked.
My request looks like this now:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
`addProperty()` looks right. On `tp32` I guess the default is GraphSON 2.0
which has this form for `Cardinality` values:
http://tinkerpop.apache.org/docs/3.2.9/dev/io/#_cardinality
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
I've just tried it not parsing the bindings to strings and get the same
issue. So I'm wondering now if I do need to parse the parameters or if I'm just
calling the addProperty function wrong?
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette Doing better now thank you!
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@jorgebay @spmallette So I've written the following test, however I'm
getting a Provided key/value array length must be a multiple of two when
submitting. I am guessing this is due to
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
sorry to hear about the sickness. i hope your doing well now. you're right
about the documentation. i think we wanted to focus folks on bytecode based
traversals. we do have a section for
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette, my apologies I've been unwell the last week. I have done the
test but it showed that I need to parse the bindings so that the standard Op
processor can read them, it doesn't
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
hi @mattallenuk - Judging from the comments it seems like the only thing
missing here code-wise is an added test. Administratively, there's some
documentation (reference docs, upgrade docs,
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/922
> I haven't considered the impact of this upon Bytecode so this may need to
be changed or addressed on the Bytecode side, or Bytecode may already handle
parameter maps?
The Bytecode
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
Hiya guys,
I have moved the code out of the existing classes and have created a Client
class that can handle script sending and a Translator class that can convert
bytecode into a
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/922
Glad to see you working on this @mattallenuk !
In line with what @spmallette was mentioning, I think we need expose a
similar API as the rest of GLVs. Python GLV is a good example
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette thanks for the feedback. I'll wait on further input from
@jorgebay and implement it to be more closely aligned with the other GLVs based
on this and further feedback.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
Excellent - thanks for doing this. @jorgebay is the better person to handle
this review in full, but I'd like to offer a few points:
> Is it safe to assume that a returned value not
19 matches
Mail list logo
