[GitHub] tinkerpop pull request #952: TINKERPOP-1959 submit scripts in javascript

2018-10-05 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/952#discussion_r223009609 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js --- @@ -216,14 +219,18 @@ class DriverRemot

[GitHub] tinkerpop pull request #952: TINKERPOP-1959 submit scripts in javascript

2018-10-05 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/952#discussion_r223001408 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js --- @@ -216,14 +219,18 @@ class DriverRemot

[GitHub] tinkerpop pull request #952: TINKERPOP-1959 submit scripts in javascript

2018-10-05 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/952#discussion_r222996609 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js --- @@ -216,14 +219,18 @@ class DriverRemoteC

[GitHub] tinkerpop pull request #952: TINKERPOP-1959 submit scripts in javascript

2018-10-05 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/952 TINKERPOP-1959 submit scripts in javascript https://issues.apache.org/jira/browse/TINKERPOP-1959 Follow on PR to #922 - more details there. This branch now contains a fix for the test