[GitHub] incubator-tinkerpop pull request #333: if there is no edge label in the Grap...

2016-06-08 Thread SergeVil
Github user SergeVil commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/333#discussion_r66295517 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java --- @@ -721,14 +732,18 @@ public static void

[DISCUSS] Handling Lambdas in Gremlin Language Variants

2016-06-08 Thread Marko Rodriguez
Hello, So in TINKERPOP-1278 there is Gremlin-Python. [https://issues.apache.org/jira/browse/TINKERPOP-1278 ]. This is a full fledged version that is tested against both the ProcessComputerSuite and ProcessStandardSuite. How does

[GitHub] incubator-tinkerpop pull request #333: if there is no edge label in the Grap...

2016-06-08 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/333#discussion_r66296879 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java --- @@ -721,14 +732,18 @@ public static void

[GitHub] incubator-tinkerpop issue #330: TINKERPOP-1319: several FeatureRequirement a...

2016-06-08 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/330 @pluradj any reason you have this in your fork? do you mind creating a TinkerPop repo branch and merging to that then re-issuing the PR from there? --- If your project is set up

Re: [DISCUSS] How to Contribute docs

2016-06-08 Thread Marko Rodriguez
I like the “Considering Code Changes” section. That is exactly the thought process I go through with each and every “initiative.” … Marko. > On Jun 8, 2016, at 6:38 AM, Hadrian Zbarcea wrote: > > Excellent work Stephen! > > Hadrian > > On 06/07/2016 05:28 PM, Stephen

I just merged master into tp31... please don't touch the repo.

2016-06-08 Thread Marko Rodriguez
Hello, In a “da da” moment, I did “git rebase -v origin/master; git push” instead of “git rebase -v origin/tp31; git push” … now tp31 is hosed. Please don’t touch that branch till I figure out how to revert my mistake. I’ll ping this thread once its all straightened out. Thanks, Marko.

[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...

2016-06-08 Thread SergeVil
Github user SergeVil commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/333 I copied the xml file to a new name and added the test that processes a new xml. Recompiled everything, and I see this file in three places: (incubator-tinkerpop)$ find ..

Re: Follow-up on JIRA after merge

2016-06-08 Thread Marko Rodriguez
I didn’t know that JIRA’s would close automagically. I also manually close the JIRA after a PR merge. Huh. Marko. http://markorodriguez.com > On Jun 8, 2016, at 5:39 AM, Stephen Mallette wrote: > > I've noticed that sometimes Apache JIRA/GitHub integration doesn't

[GitHub] incubator-tinkerpop pull request #332: if there is no edge label in the Grap...

2016-06-08 Thread analytically
Github user analytically commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/332#discussion_r66219778 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLReader.java --- @@ -187,7 +187,9 @@ public

Re: [DISCUSS] How to Contribute docs

2016-06-08 Thread Daniel Kuppitz
Not much to say here, except: Solid! Nice work, I like it. Cheers, Daniel On Tue, Jun 7, 2016 at 11:28 PM, Stephen Mallette wrote: > We had some documentation on "how to contribute" but they were kinda weak. > I re-wrote it using the very good "how to contribute" docs

Follow-up on JIRA after merge

2016-06-08 Thread Stephen Mallette
I've noticed that sometimes Apache JIRA/GitHub integration doesn't always behave nicely. Sometimes the JIRA issue doesn't close when you close the PR. I ran into a bunch of those yesterday while reviewing some old branches and had to close the JIRAs manually. It seems it might have happened again

[jira] [Updated] (TINKERPOP-1318) java.lang.NoSuchMethodError: org/hamcrest/Matcher.describeMismatch

2016-06-08 Thread Jason Plurad (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Plurad updated TINKERPOP-1318: Fix Version/s: 3.2.1 3.1.3 > java.lang.NoSuchMethodError:

[jira] [Updated] (TINKERPOP-1317) IoGraphTest throws error: URI is not hierarchical

2016-06-08 Thread Jason Plurad (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Plurad updated TINKERPOP-1317: Fix Version/s: 3.2.1 3.1.3 > IoGraphTest throws error: URI is not

Re: [DISCUSS] How to Contribute docs

2016-06-08 Thread Hadrian Zbarcea
Excellent work Stephen! Hadrian On 06/07/2016 05:28 PM, Stephen Mallette wrote: We had some documentation on "how to contribute" but they were kinda weak. I re-wrote it using the very good "how to contribute" docs from Spark as a guide. I was kinda annoyed because their stuff was so good, it

[jira] [Closed] (TINKERPOP-1324) Better error for invalid args to addV()

2016-06-08 Thread Marko A. Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marko A. Rodriguez closed TINKERPOP-1324. - Resolution: Fixed Assignee: Marko A. Rodriguez Simple one line fix. I

Re: I just merged master into tp31... please don't touch the repo.

2016-06-08 Thread Marko Rodriguez
Hi, Stephen just forced commit his un-pulled version of tp31/. Phew…… git revert would have been a nightmare given the number of commits. Both tp31/ and master/ seem to be back in shape. Thanks — (and sorry), Marko. http://markorodriguez.com > On Jun 8, 2016, at 7:37 AM, Marko Rodriguez

[jira] [Commented] (TINKERPOP-1328) Provide [gremlin-python] as an code executor in docs

2016-06-08 Thread Marko A. Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320626#comment-15320626 ] Marko A. Rodriguez commented on TINKERPOP-1328: --- Also, can you do this work in

[jira] [Commented] (TINKERPOP-1329) Use Parameters in more steps than just the MutationStep library.

2016-06-08 Thread Daniel Kuppitz (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320661#comment-15320661 ] Daniel Kuppitz commented on TINKERPOP-1329: --- I think we talked about it before. This would

Re: I just merged master into tp31... please don't touch the repo.

2016-06-08 Thread Stephen Mallette
The --force was not ideal, but given the small time window where we had a problem it seemed unlikely that anyone would have had major losses as a result. Hope it didn't cause any inconvenience. On Wed, Jun 8, 2016 at 10:08 AM, Marko Rodriguez wrote: > Hi, > > Stephen just

Re: Documentation deprecation warning on Github Wikis

2016-06-08 Thread Dylan Bethune-Waddell
>> Everyone good with those changes? Significantly better than what I had in mind - the welcome message looks great Stephen. Nice one. From: Stephen Mallette Sent: Wednesday, June 8, 2016 8:20:15 AM To: dev@tinkerpop.apache.org Subject: