[GitHub] tinkerpop pull request #368: TINKERPOP-1394: fixed dev list and jira links

[robertdale]

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/368

TINKERPOP-1394: fixed dev list and jira links



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1394

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #368


commit 8e716238a91aa424b0c04c081fc94cd37f3ea33b
Author: Robert Dale 
Date:   2016-08-03T04:15:03Z

fixed dev list and jira links




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1394) Fix links in Recipes doc

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405282#comment-15405282
 ] 

ASF GitHub Bot commented on TINKERPOP-1394:
---

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/368

TINKERPOP-1394: fixed dev list and jira links



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1394

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #368


commit 8e716238a91aa424b0c04c081fc94cd37f3ea33b
Author: Robert Dale 
Date:   2016-08-03T04:15:03Z

fixed dev list and jira links




> Fix links in Recipes doc
> 
>
> Key: TINKERPOP-1394
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1394
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.2.1
>Reporter: Robert Dale
>Priority: Trivial
> Fix For: 3.2.2
>
>
> dev mailing list and jira links are broken



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TINKERPOP-1394) Fix links in Recipes doc

[Robert Dale (JIRA)]

Robert Dale created TINKERPOP-1394:
--

 Summary: Fix links in Recipes doc
 Key: TINKERPOP-1394
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1394
 Project: TinkerPop
  Issue Type: Improvement
  Components: documentation
Affects Versions: 3.2.1
Reporter: Robert Dale
Priority: Trivial
 Fix For: 3.2.2


dev mailing list and jira links are broken



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [DISCUSS] Download Page

[Stephen Mallette]

no - we don't have one for the main web site. i've wanted to suggest that
we change that though and generate the main web site from the github repo.
in that way we could easily accept pull requests and such. i don't think we
want to take a full asciidoc approach and the web site generation would
probably stay separate from the doc generation, but it would be nice if we
could bin/generate-web-site.sh for a local build of that that thing which
could then be published to the apache svn repo. anyone else like that idea?
if so, how would it best be done?



On Tue, Aug 2, 2016 at 5:05 PM, Robert Dale  wrote:

> Is there a git repo for this and the main website?  I would like to
> make pull requests to fix some things.
>
> On Fri, Jul 29, 2016 at 1:49 PM, Stephen Mallette 
> wrote:
> > The download page is now "live"
> >
> > On Thu, Jul 28, 2016 at 7:14 PM, Stephen Mallette 
> > wrote:
> >
> >> I assume everyone is cool with making the Download Page live at this
> point
> >> as there's been no other feedback in the last few days. I'll probably
> make
> >> some adjustments to the web site tomorrow to bring it online publicly.
> >>
> >> On Mon, Jul 25, 2016 at 7:33 AM, Stephen Mallette  >
> >> wrote:
> >>
> >>> I updated the downloads page some more:
> >>>
> >>> + tweaked the date format a bit to "really" match the rest of the site
> >>> (which is still inconsistent in other places like changelog - dah)
> >>> + added a "verifying downloads" section which talks about GPG/PGP/etc.
> >>>
> >>> http://tinkerpop.apache.org/downloads.html
> >>>
> >>>
> >>>
> >>>
> >>> On Fri, Jul 22, 2016 at 3:53 PM, Stephen Mallette <
> spmalle...@gmail.com>
> >>> wrote:
> >>>
>  Good feedback Robert/Jason.
> 
>  Updated:
> 
>  http://tinkerpop.apache.org/downloads.html
> 
>  Added documentation and included some descriptors to current releases.
>  Didn't change the date format for now - that's the format we use
> everywhere
>  around "release" so didn't want to muck with that at this point.
> 
> 
> 
>  On Fri, Jul 22, 2016 at 3:36 PM, Robert Dale 
> wrote:
> 
> > Stephen, I think what Sebb might be getting at is that some things
> > should be spelled out even if they are obvious to some. I agree with
> > this.
> >
> > 3.2.1 (latest, stable)
> > 3.1.3 (bug fixes only)
> >
> > I think the dates should be in ISO8601 format.  -MM-DD
> >
> > Otherwise, I think it looks very good.
> >
> > --
> > Robert Dale
> >
> > On Fri, Jul 22, 2016 at 2:51 PM, Jason Plurad 
> > wrote:
> > > +1 looks great.
> > >
> > > Link to the documentation, maybe next to the release notes link,
> > would be
> > > useful too.
> > >
> > > -- Jason
> > >
> > > On Fri, Jul 22, 2016 at 2:07 PM, Stephen Mallette <
> > spmalle...@gmail.com>
> > > wrote:
> > >
> > >> I think it might be a good idea to include a "Download Page" on
> our
> > web
> > >> site. It would let us better list the versions we have out there
> and
> > would
> > >> get us better in line with Apache Infrastructure - for example:
> > >>
> > >> https://issues.apache.org/jira/browse/TINKERPOP-1255
> > >>
> > >> I'm also seeing that we yet have spots where we dont' link to the
> > mirror
> > >> system. And finally, it would be nice to have a "generic" download
> > page
> > >> where we could point external links to - like the new
> "documentation"
> > >> feature in StackOverflow (right now it's sorta hardcoded to the
> > mirror
> > >> which isn't so good because we'll have to change that all the
> time).
> > >>
> > >> I quickly took a swipe at such a page:
> > >>
> > >> http://tinkerpop.apache.org/downloads.html
> > >>
> > >> It is NOT "linked to" by anything at this point so it is
> "hidden". I
> > just
> > >> wanted to have something that everyone could look at to get the
> idea
> > of
> > >> what such a page might look like.
> > >>
> > >> Thoughts?
> > >>
> > >> Thanks,
> > >>
> > >> Stephen
> > >>
> >
> 
> 
> >>>
> >>
>
>
>
> --
> Robert Dale
>

Re: [DISCUSS] Download Page

[Robert Dale]

Is there a git repo for this and the main website?  I would like to
make pull requests to fix some things.

On Fri, Jul 29, 2016 at 1:49 PM, Stephen Mallette  wrote:
> The download page is now "live"
>
> On Thu, Jul 28, 2016 at 7:14 PM, Stephen Mallette 
> wrote:
>
>> I assume everyone is cool with making the Download Page live at this point
>> as there's been no other feedback in the last few days. I'll probably make
>> some adjustments to the web site tomorrow to bring it online publicly.
>>
>> On Mon, Jul 25, 2016 at 7:33 AM, Stephen Mallette 
>> wrote:
>>
>>> I updated the downloads page some more:
>>>
>>> + tweaked the date format a bit to "really" match the rest of the site
>>> (which is still inconsistent in other places like changelog - dah)
>>> + added a "verifying downloads" section which talks about GPG/PGP/etc.
>>>
>>> http://tinkerpop.apache.org/downloads.html
>>>
>>>
>>>
>>>
>>> On Fri, Jul 22, 2016 at 3:53 PM, Stephen Mallette 
>>> wrote:
>>>
 Good feedback Robert/Jason.

 Updated:

 http://tinkerpop.apache.org/downloads.html

 Added documentation and included some descriptors to current releases.
 Didn't change the date format for now - that's the format we use everywhere
 around "release" so didn't want to muck with that at this point.



 On Fri, Jul 22, 2016 at 3:36 PM, Robert Dale  wrote:

> Stephen, I think what Sebb might be getting at is that some things
> should be spelled out even if they are obvious to some. I agree with
> this.
>
> 3.2.1 (latest, stable)
> 3.1.3 (bug fixes only)
>
> I think the dates should be in ISO8601 format.  -MM-DD
>
> Otherwise, I think it looks very good.
>
> --
> Robert Dale
>
> On Fri, Jul 22, 2016 at 2:51 PM, Jason Plurad 
> wrote:
> > +1 looks great.
> >
> > Link to the documentation, maybe next to the release notes link,
> would be
> > useful too.
> >
> > -- Jason
> >
> > On Fri, Jul 22, 2016 at 2:07 PM, Stephen Mallette <
> spmalle...@gmail.com>
> > wrote:
> >
> >> I think it might be a good idea to include a "Download Page" on our
> web
> >> site. It would let us better list the versions we have out there and
> would
> >> get us better in line with Apache Infrastructure - for example:
> >>
> >> https://issues.apache.org/jira/browse/TINKERPOP-1255
> >>
> >> I'm also seeing that we yet have spots where we dont' link to the
> mirror
> >> system. And finally, it would be nice to have a "generic" download
> page
> >> where we could point external links to - like the new "documentation"
> >> feature in StackOverflow (right now it's sorta hardcoded to the
> mirror
> >> which isn't so good because we'll have to change that all the time).
> >>
> >> I quickly took a swipe at such a page:
> >>
> >> http://tinkerpop.apache.org/downloads.html
> >>
> >> It is NOT "linked to" by anything at this point so it is "hidden". I
> just
> >> wanted to have something that everyone could look at to get the idea
> of
> >> what such a page might look like.
> >>
> >> Thoughts?
> >>
> >> Thanks,
> >>
> >> Stephen
> >>
>


>>>
>>



-- 
Robert Dale

[jira] [Commented] (TINKERPOP-1350) Server locks when submitting parallel requests on session

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404681#comment-15404681
 ] 

ASF GitHub Bot commented on TINKERPOP-1350:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/367

TINKERPOP-1350 was never quite fixed in 3.1.3.

Unfortunately, more testing revealed that the fix for the problem was only 
masked by the changes in 3.1.3. 

Changed response encoding to not use the session executor when the session 
has an error condition it is trying to serialize. This should be fine as there 
is no need to serialized an error condition as part of a transaction and thus 
no need to have the session thread to do it. That in turn frees up the worker 
executor to serialize and cancel long run jobs in the session. Removed 
recommendations for submitting parallel requests on a session from docs.

Works in full with `mvn clean install && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1350

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/367.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #367


commit 57ef449ded52e5c11072e7a626eebcfcc13889c4
Author: Stephen Mallette 
Date:   2016-08-02T19:59:19Z

TINKERPOP-1350 was never quite fixed in 3.1.3.

Changed response encoding to not use the session executor when the session 
has an error condition it is trying to serialize. This should be fine as there 
is no need to serialized an error condition as part of a transaction and thus 
no need to have the session thread to do it. That in turn frees up the worker 
executor to serialize and cancel long run jobs in the session. Removed 
recommendations for submitting parallel requests on a session from docs.




> Server locks when submitting parallel requests on session
> -
>
> Key: TINKERPOP-1350
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1350
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Critical
> Fix For: 3.1.4, 3.2.2
>
>
> This really is only a problem when there is some form of long blocking script 
> submitted and only on a session when done in parallel, like:
> {code}
> final ResultSet first = client.submit(
> "Object mon1 = 'mon1';\n" +
> "synchronized (mon1) {\n" +
> "mon1.wait();\n" +
> "} ");
> final ResultSet second = client.submit(
> "Object mon2 = 'mon2';\n" +
> "synchronized (mon2) {\n" +
> "mon2.wait();\n" +
> "}");
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop pull request #367: TINKERPOP-1350 was never quite fixed in 3.1.3.

[spmallette]

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/367

TINKERPOP-1350 was never quite fixed in 3.1.3.

Unfortunately, more testing revealed that the fix for the problem was only 
masked by the changes in 3.1.3. 

Changed response encoding to not use the session executor when the session 
has an error condition it is trying to serialize. This should be fine as there 
is no need to serialized an error condition as part of a transaction and thus 
no need to have the session thread to do it. That in turn frees up the worker 
executor to serialize and cancel long run jobs in the session. Removed 
recommendations for submitting parallel requests on a session from docs.

Works in full with `mvn clean install && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1350

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/367.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #367


commit 57ef449ded52e5c11072e7a626eebcfcc13889c4
Author: Stephen Mallette 
Date:   2016-08-02T19:59:19Z

TINKERPOP-1350 was never quite fixed in 3.1.3.

Changed response encoding to not use the session executor when the session 
has an error condition it is trying to serialize. This should be fine as there 
is no need to serialized an error condition as part of a transaction and thus 
no need to have the session thread to do it. That in turn frees up the worker 
executor to serialize and cancel long run jobs in the session. Removed 
recommendations for submitting parallel requests on a session from docs.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TINKERPOP-1350) Server locks when submitting parallel requests on session

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1350:

Fix Version/s: (was: 3.2.1)
   (was: 3.1.3)
   3.2.2
   3.1.4

> Server locks when submitting parallel requests on session
> -
>
> Key: TINKERPOP-1350
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1350
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Critical
> Fix For: 3.1.4, 3.2.2
>
>
> This really is only a problem when there is some form of long blocking script 
> submitted and only on a session when done in parallel, like:
> {code}
> final ResultSet first = client.submit(
> "Object mon1 = 'mon1';\n" +
> "synchronized (mon1) {\n" +
> "mon1.wait();\n" +
> "} ");
> final ResultSet second = client.submit(
> "Object mon2 = 'mon2';\n" +
> "synchronized (mon2) {\n" +
> "mon2.wait();\n" +
> "}");
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (TINKERPOP-1350) Server locks when submitting parallel requests on session

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette reopened TINKERPOP-1350:
-

This one didn't appear to be quite fixed. Additional testing showed that it was 
fixed only because the test assumed two parallel requests when the problem 
actually showed when the number of parallel requests was greater than the 
number of threads in the gremlin server worker pool.

> Server locks when submitting parallel requests on session
> -
>
> Key: TINKERPOP-1350
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1350
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Critical
> Fix For: 3.1.3, 3.2.1
>
>
> This really is only a problem when there is some form of long blocking script 
> submitted and only on a session when done in parallel, like:
> {code}
> final ResultSet first = client.submit(
> "Object mon1 = 'mon1';\n" +
> "synchronized (mon1) {\n" +
> "mon1.wait();\n" +
> "} ");
> final ResultSet second = client.submit(
> "Object mon2 = 'mon2';\n" +
> "synchronized (mon2) {\n" +
> "mon2.wait();\n" +
> "}");
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop pull request #:

[spmallette]

Github user spmallette commented on the pull request:


https://github.com/apache/tinkerpop/commit/6ed7edc0b4ad2abf933e917812d49ad92230c8d1#commitcomment-18490043
  
In 
gremlin-variant/src/main/groovy/org/apache/tinkerpop/gremlin/python/GremlinPythonGenerator.groovy:
In 
gremlin-variant/src/main/groovy/org/apache/tinkerpop/gremlin/python/GremlinPythonGenerator.groovy
 on line 101:
@aholmberg thanks for the offer to help out. feel free to submit pull 
requests if you have the time to do so. @okram did most of the python work here 
and should be back from vacation soon to review your comments here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #:

[spmallette]

Github user spmallette commented on the pull request:


https://github.com/apache/tinkerpop/commit/6ed7edc0b4ad2abf933e917812d49ad92230c8d1#commitcomment-18489820
  
In 
gremlin-variant/src/main/groovy/org/apache/tinkerpop/gremlin/python/GremlinPythonGenerator.groovy:
In 
gremlin-variant/src/main/groovy/org/apache/tinkerpop/gremlin/python/GremlinPythonGenerator.groovy
 on line 95:
Since that is the general python style guideline then it makes sense to me 
that we should follow that pattern to keep this natural looking to python devs. 
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1393) RepeatUnrollStrategy alters traversal behavior

[Dan LaRocque (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404151#comment-15404151
 ] 

Dan LaRocque commented on TINKERPOP-1393:
-

Thanks for pointing me at that issue.  It looks like we may have even followed 
the same crumb trail ({{"String result = 
g.V().repeat(both()).times(3).tail(7).count().next().toString();"}}).  I don't 
understand the relevant code well enough to comment on the fix right now, but 
it definitely looks like the problem statements overlap.  I'll link this as a 
duplicate of your issue and close it.

> RepeatUnrollStrategy alters traversal behavior
> --
>
> Key: TINKERPOP-1393
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1393
> Project: TinkerPop
>  Issue Type: Bug
>Affects Versions: 3.2.1
>Reporter: Dan LaRocque
>
> I think 
> https://github.com/apache/tinkerpop/commit/6208b90b2ca297186b4f75f356e0093d4b6ed280
>  may contain a bug.
> Consider this normal-looking gremlin-console session from the immediately 
> preceding commit (not 6208b but the commit right before):
> {noformat}
> tinkerpop$ git checkout 6208b90b2ca297186b4f75f356e0093d4b6ed280~
> tinkerpop$ mvn clean install -DskipTests=true
> tinkerpop$ gremlin-console/bin/gremlin.sh 
>  \,,,/
>  (o o)
> -oOOo-(3)-oOOo-
> plugin activated: tinkerpop.server
> plugin activated: tinkerpop.utilities
> plugin activated: tinkerpop.tinkergraph
> gremlin> tg = TinkerGraph.open()
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> ego = tg.addVertex('vertex')
> ==>v[0]
> gremlin> p1 = tg.addVertex('vertex')
> ==>v[1]
> gremlin> p2 = tg.addVertex('vertex')
> ==>v[2]
> gremlin> p3 = tg.addVertex('vertex')
> ==>v[3]
> gremlin> ego.addEdge('knows', p1)
> ==>e[4][0-knows->1]
> gremlin> ego.addEdge('knows', p2)
> ==>e[5][0-knows->2]
> gremlin> ego.addEdge('knows', p3)
> ==>e[6][0-knows->3]
> gremlin> tg.traversal().V().repeat(both()).times(3).tail(7)
> ==>v[0]
> ==>v[0]
> ==>v[0]
> ==>v[0]
> ==>v[0]
> ==>v[0]
> ==>v[0]
> gremlin> tg.traversal().V().both().both().both().count()
> ==>18
> gremlin> tg.traversal().V().repeat(both()).times(3).tail(7).count()
> ==>7
> gremlin>
> {noformat}
> So far so good.
> However, 6208b changes the last traversal result from 7 to 6:
> {noformat}
> tinkerpop$ git checkout 6208b90b2ca297186b4f75f356e0093d4b6ed280
> tinkerpop$ mvn clean install -DskipTests=true
> tinkerpop$ gremlin-console/bin/gremlin.sh 
>  \,,,/
>  (o o)
> -oOOo-(3)-oOOo-
> plugin activated: tinkerpop.server
> plugin activated: tinkerpop.utilities
> plugin activated: tinkerpop.tinkergraph
> gremlin> tg = TinkerGraph.open()
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> ego = tg.addVertex('vertex')
> ==>v[0]
> gremlin> p1 = tg.addVertex('vertex')
> ==>v[1]
> gremlin> p2 = tg.addVertex('vertex')
> ==>v[2]
> gremlin> p3 = tg.addVertex('vertex')
> ==>v[3]
> gremlin> ego.addEdge('knows', p1)
> ==>e[4][0-knows->1]
> gremlin> ego.addEdge('knows', p2)
> ==>e[5][0-knows->2]
> gremlin> ego.addEdge('knows', p3)
> ==>e[6][0-knows->3]
> gremlin> tg.traversal().V().repeat(both()).times(3).tail(7)
> ==>v[0]
> ==>v[0]
> ==>v[0]
> ==>v[0]
> ==>v[0]
> ==>v[0]
> gremlin> tg.traversal().V().both().both().both().count()
> ==>18
> gremlin> tg.traversal().V().repeat(both()).times(3).tail(7).count()
> ==>6
> {noformat}
> Confusingly, {{mvn -pl tinkergraph-gremlin 
> -Dtest=TinkerGraphProcessStandardTest clean verify}} passes.  That test 
> includes {{TailTest$Traversals.g_V_repeatXbothX_timesX3X_tailX7X}}, which 
> seems like it would catch this kind of bug, but said test succeeds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TINKERPOP-1393) RepeatUnrollStrategy alters traversal behavior

[Dan LaRocque (JIRA)]

Dan LaRocque created TINKERPOP-1393:
---

 Summary: RepeatUnrollStrategy alters traversal behavior
 Key: TINKERPOP-1393
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1393
 Project: TinkerPop
  Issue Type: Bug
Affects Versions: 3.2.1
Reporter: Dan LaRocque


I think 
https://github.com/apache/tinkerpop/commit/6208b90b2ca297186b4f75f356e0093d4b6ed280
 may contain a bug.

Consider this normal-looking gremlin-console session from the immediately 
preceding commit (not 6208b but the commit right before):

{noformat}
tinkerpop$ git checkout 6208b90b2ca297186b4f75f356e0093d4b6ed280~
tinkerpop$ mvn clean install -DskipTests=true
tinkerpop$ gremlin-console/bin/gremlin.sh 

 \,,,/
 (o o)
-oOOo-(3)-oOOo-
plugin activated: tinkerpop.server
plugin activated: tinkerpop.utilities
plugin activated: tinkerpop.tinkergraph
gremlin> tg = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> ego = tg.addVertex('vertex')
==>v[0]
gremlin> p1 = tg.addVertex('vertex')
==>v[1]
gremlin> p2 = tg.addVertex('vertex')
==>v[2]
gremlin> p3 = tg.addVertex('vertex')
==>v[3]
gremlin> ego.addEdge('knows', p1)
==>e[4][0-knows->1]
gremlin> ego.addEdge('knows', p2)
==>e[5][0-knows->2]
gremlin> ego.addEdge('knows', p3)
==>e[6][0-knows->3]
gremlin> tg.traversal().V().repeat(both()).times(3).tail(7)
==>v[0]
==>v[0]
==>v[0]
==>v[0]
==>v[0]
==>v[0]
==>v[0]
gremlin> tg.traversal().V().both().both().both().count()
==>18
gremlin> tg.traversal().V().repeat(both()).times(3).tail(7).count()
==>7
gremlin>
{noformat}

So far so good.

However, 6208b changes the last traversal result from 7 to 6:

{noformat}
tinkerpop$ git checkout 6208b90b2ca297186b4f75f356e0093d4b6ed280
tinkerpop$ mvn clean install -DskipTests=true
tinkerpop$ gremlin-console/bin/gremlin.sh 

 \,,,/
 (o o)
-oOOo-(3)-oOOo-
plugin activated: tinkerpop.server
plugin activated: tinkerpop.utilities
plugin activated: tinkerpop.tinkergraph
gremlin> tg = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> ego = tg.addVertex('vertex')
==>v[0]
gremlin> p1 = tg.addVertex('vertex')
==>v[1]
gremlin> p2 = tg.addVertex('vertex')
==>v[2]
gremlin> p3 = tg.addVertex('vertex')
==>v[3]
gremlin> ego.addEdge('knows', p1)
==>e[4][0-knows->1]
gremlin> ego.addEdge('knows', p2)
==>e[5][0-knows->2]
gremlin> ego.addEdge('knows', p3)
==>e[6][0-knows->3]
gremlin> tg.traversal().V().repeat(both()).times(3).tail(7)
==>v[0]
==>v[0]
==>v[0]
==>v[0]
==>v[0]
==>v[0]
gremlin> tg.traversal().V().both().both().both().count()
==>18
gremlin> tg.traversal().V().repeat(both()).times(3).tail(7).count()
==>6
{noformat}

Confusingly, {{mvn -pl tinkergraph-gremlin 
-Dtest=TinkerGraphProcessStandardTest clean verify}} passes.  That test 
includes {{TailTest$Traversals.g_V_repeatXbothX_timesX3X_tailX7X}}, which seems 
like it would catch this kind of bug, but said test succeeds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)