[jira] [Commented] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188875#comment-16188875
 ] 

ASF GitHub Bot commented on TINKERPOP-1795:
---

GitHub user okram opened a pull request:

https://github.com/apache/tinkerpop/pull/726

TINKERPOP-1795: Getting Lambda comparator message for .profile() step

https://issues.apache.org/jira/browse/TINKERPOP-1795

Some objects are hard to check for "lambdaness" and require a `toString()` 
analysis. We checked for `@` but that doesn't work for named steps within 
`order()` (when using `profile()`). That is, its error prone. I came up with a 
new way to check for lambdas that works for Java, Groovy, and Python/Jython. 

@spmallette -- can you please verify that a "toString()" of a lambda in C# 
will hold as well for the pattern.

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1795

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #726


commit beae74c43505d1f7732f92a500dc58fc4b142af1
Author: Marko A. Rodriguez 
Date:   2017-10-02T21:23:33Z

fixed a bug in LambdaRestrictionStrategy where named @ steps were 
considered lambda. Came up with a different way to check lambdas in 
.toString(). Works for Groovy, Java, and Python.




> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Assignee: Marko A. Rodriguez
>Priority: Minor
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop pull request #726: TINKERPOP-1795: Getting Lambda comparator messa...

[okram]

GitHub user okram opened a pull request:

https://github.com/apache/tinkerpop/pull/726

TINKERPOP-1795: Getting Lambda comparator message for .profile() step

https://issues.apache.org/jira/browse/TINKERPOP-1795

Some objects are hard to check for "lambdaness" and require a `toString()` 
analysis. We checked for `@` but that doesn't work for named steps within 
`order()` (when using `profile()`). That is, its error prone. I came up with a 
new way to check for lambdas that works for Java, Groovy, and Python/Jython. 

@spmallette -- can you please verify that a "toString()" of a lambda in C# 
will hold as well for the pattern.

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1795

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #726


commit beae74c43505d1f7732f92a500dc58fc4b142af1
Author: Marko A. Rodriguez 
Date:   2017-10-02T21:23:33Z

fixed a bug in LambdaRestrictionStrategy where named @ steps were 
considered lambda. Came up with a different way to check lambdas in 
.toString(). Works for Groovy, Java, and Python.




---

[jira] [Assigned] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

[Marko A. Rodriguez (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marko A. Rodriguez reassigned TINKERPOP-1795:
-

Assignee: Marko A. Rodriguez

> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Assignee: Marko A. Rodriguez
>Priority: Minor
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

[Marko A. Rodriguez (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188818#comment-16188818
 ] 

Marko A. Rodriguez commented on TINKERPOP-1795:
---

I was able to reproduce this with TinkerGraph.

{code}
gremlin> 
gremlin> g = TinkerGraph.open().traversal()
==>graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
gremlin> g = g.withStrategies(LambdaRetrictionStrategy.instance())
gremlin> 
g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
The provided step contains a lambda comparator: 
OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
Type ':help' or ':h' for help.
Display stack trace? [yN]
{code}

> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Priority: Minor
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

[Marko A. Rodriguez (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188818#comment-16188818
 ] 

Marko A. Rodriguez edited comment on TINKERPOP-1795 at 10/2/17 8:57 PM:


I was able to reproduce this with TinkerGraph.

{code}
gremlin> 
gremlin> g = TinkerGraph.open().traversal()
==>graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
gremlin> g = g.withStrategies(LambdaRestrictionStrategy.instance())
gremlin> 
g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
The provided step contains a lambda comparator: 
OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
Type ':help' or ':h' for help.
Display stack trace? [yN]
{code}


was (Author: okram):
I was able to reproduce this with TinkerGraph.

{code}
gremlin> 
gremlin> g = TinkerGraph.open().traversal()
==>graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
gremlin> g = g.withStrategies(LambdaRetrictionStrategy.instance())
gremlin> 
g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
The provided step contains a lambda comparator: 
OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
Type ':help' or ':h' for help.
Display stack trace? [yN]
{code}

> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Priority: Minor
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

[Robert Dale (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188720#comment-16188720
 ] 

Robert Dale commented on TINKERPOP-1795:


What graph is this on? Couldn't reproduce on TinkerGraph...

{noformat}
gremlin> 
g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
==>Traversal Metrics
Step   Count  
Traversers   Time (ms)% Dur
=
TinkerGraphStep(vertex,[~label.eq(Question), qu... 1
   1   0.050 7.36
VertexStep(IN,[has_question],vertex)   1
   1   0.058 8.57
OrderGlobalStep([[[VertexStep(IN,[reviewed],edg... 1
   1   0.57384.07
  VertexStep(IN,[reviewed],edge)   1
   1   0.016
  PropertiesStep([rating],value)   1
   1   0.384
  MeanGlobalStep   1
   1   0.083
>TOTAL -
   -   0.681-
{noformat}


> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Priority: Minor
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

[Shaunak Das (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaunak Das updated TINKERPOP-1795:
---
Description: 
Ran into this message when adding a .profile() step, even though Gremlin query 
does not have any lambda steps:
{code}
gremlin> 
g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
The provided step contains a lambda comparator: 
OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
Type ':help' or ':h' for help.
Display stack trace? [yN]
{code}

  was:
Ran into this message, even though Gremlin query does not have any lambda steps:
{code}
gremlin> 
g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
The provided step contains a lambda comparator: 
OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
Type ':help' or ':h' for help.
Display stack trace? [yN]
{code}


> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Priority: Minor
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1795:

Component/s: process

> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Priority: Minor
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

[Shaunak Das (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaunak Das updated TINKERPOP-1795:
---
Affects Version/s: 3.2.6

> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Priority: Minor
>
> Ran into this message, even though Gremlin query does not have any lambda 
> steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

[Shaunak Das (JIRA)]

Shaunak Das created TINKERPOP-1795:
--

 Summary: Getting Lambda  comparator message for .profile() step
 Key: TINKERPOP-1795
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
 Project: TinkerPop
  Issue Type: Bug
Reporter: Shaunak Das


Ran into this message, even though Gremlin query does not have any lambda steps:
{code}
gremlin> 
g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
The provided step contains a lambda comparator: 
OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
Type ':help' or ':h' for help.
Display stack trace? [yN]
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

[Shaunak Das (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaunak Das updated TINKERPOP-1795:
---
Priority: Minor  (was: Major)

> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>Reporter: Shaunak Das
>Priority: Minor
>
> Ran into this message, even though Gremlin query does not have any lambda 
> steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1786) Recipe and missing manifest items for Spark on Yarn

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188613#comment-16188613
 ] 

ASF GitHub Bot commented on TINKERPOP-1786:
---

Github user vtslab commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/721#discussion_r142223415
  
--- Diff: hadoop-gremlin/conf/hadoop-gryo.properties ---
@@ -29,8 +29,8 @@ gremlin.hadoop.outputLocation=output
 spark.master=local[4]
 spark.executor.memory=1g
 
spark.serializer=org.apache.tinkerpop.gremlin.spark.structure.io.gryo.GryoSerializer
+gremlin.spark.persistContext=true
--- End diff --

Good question, I had not justified this yet. My original reason was that 
stopping both the SparkContext and the gremlin console as in the docs 
generation, can lead to race conditions in spark-yarn with random connection 
exceptions showing up in the console output in the docs. But as a bonus, 
follow-up OLAP queries get answered much faster as you skip the overhead for 
getting resources from yarn. This is what is also done in Apache Zeppelin, 
Spark shell and the like.

The alternative is to set the property in the console together with the 
other properties. This would require some more explanation and configuration 
work afterwards to/from the recipe users, but would leave the properties file 
untouched. I like the current proposal better, but I am fine with both.


> Recipe and missing manifest items for Spark on Yarn
> ---
>
> Key: TINKERPOP-1786
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1786
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: hadoop
>Affects Versions: 3.3.0, 3.1.8, 3.2.6
> Environment: gremlin-console
>Reporter: Marc de Lignie
>Priority: Minor
> Fix For: 3.2.7, 3.3.1
>
>
> Thorough documentation for running OLAP queries on Spark on Yarn has been 
> missing, keeping some users from getting the benefits of this nice feature of 
> the Tinkerpop stack and resulting in a significant number of questions on the 
> gremlin users list.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop pull request #721: TINKERPOP-1786 Recipe and missing manifest item...

[vtslab]

Github user vtslab commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/721#discussion_r142223415
  
--- Diff: hadoop-gremlin/conf/hadoop-gryo.properties ---
@@ -29,8 +29,8 @@ gremlin.hadoop.outputLocation=output
 spark.master=local[4]
 spark.executor.memory=1g
 
spark.serializer=org.apache.tinkerpop.gremlin.spark.structure.io.gryo.GryoSerializer
+gremlin.spark.persistContext=true
--- End diff --

Good question, I had not justified this yet. My original reason was that 
stopping both the SparkContext and the gremlin console as in the docs 
generation, can lead to race conditions in spark-yarn with random connection 
exceptions showing up in the console output in the docs. But as a bonus, 
follow-up OLAP queries get answered much faster as you skip the overhead for 
getting resources from yarn. This is what is also done in Apache Zeppelin, 
Spark shell and the like.

The alternative is to set the property in the console together with the 
other properties. This would require some more explanation and configuration 
work afterwards to/from the recipe users, but would leave the properties file 
untouched. I like the current proposal better, but I am fine with both.


---

[GitHub] tinkerpop issue #725: TINKERPOP-1661 Docker-built documentation does not alw...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
That's fine. Now I know what to look for ;-)


---

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188542#comment-16188542
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
That's fine. Now I know what to look for ;-)


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #725: TINKERPOP-1661 Docker-built documentation does not alw...

[dkuppitz]

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
I know, Stephen and I talked briefly about it and we came to the conclusion 
that the Docker stuff is really just a developer / contributor thing and we 
shouldn't care too much about "breaking" changes within minor releases. Perhaps 
we should just send a short mail to dev@ if we make changes in the Docker image 
setups.


---

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188507#comment-16188507
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
I know, Stephen and I talked briefly about it and we came to the conclusion 
that the Docker stuff is really just a developer / contributor thing and we 
shouldn't care too much about "breaking" changes within minor releases. Perhaps 
we should just send a short mail to dev@ if we make changes in the Docker image 
setups.


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188482#comment-16188482
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
@dkuppitz It was change 37a2471932229ae6a4c1f5e5f3f2d3d25bbf7fd4 that 
introduced dotnet that required the need to rebuild the images. 


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #725: TINKERPOP-1661 Docker-built documentation does not alw...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
@dkuppitz It was change 37a2471932229ae6a4c1f5e5f3f2d3d25bbf7fd4 that 
introduced dotnet that required the need to rebuild the images. 


---

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188428#comment-16188428
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
@robertdale FYI: I just fixed the download in `tp32/` and `master/` and 
rebased this PR. Rebuilding the images should no longer be an issue.


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #725: TINKERPOP-1661 Docker-built documentation does not alw...

[dkuppitz]

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
@robertdale FYI: I just fixed the download in `tp32/` and `master/` and 
rebased this PR. Rebuilding the images should no longer be an issue.


---

[jira] [Commented] (TINKERPOP-1632) Create a set of default functions

[Marko A. Rodriguez (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188415#comment-16188415
 ] 

Marko A. Rodriguez commented on TINKERPOP-1632:
---

Here are two concepts we will have to deal with.

1. Manipulating numbers directly. (e.g. {{math(add).by(3)}})
2. Manipulating numbers indirectly. (e.g. {{math(add).by("a")}})

For predicates we have two types of steps: {{is()}} (direct) and {{where()}} 
(indirect). I do not like this distinction and something we should rectify in 
TinkerPop4. For instance, {{is(var("a"))}} vs. {{is("a")}}. Do we go down the 
route of having two types of {{math()}} functions? I don't think we should do 
that. Thus, how do we distinguish the string "a" and the variable "a" ?

> Create a set of default functions
> -
>
> Key: TINKERPOP-1632
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1632
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.3.0
>Reporter: Daniel Kuppitz
>
> We already have a a set of default BiFunctions / operators, that are not 
> treated as lambdas. We should also have a bunch of simple functions, that can 
> then be used in {{map()}} or {{sack()}} and that can be serialized as 
> bytecode. For example:
> {noformat}
> ...map(sqrt)
> ...map(log)
> ...sack(sigmoid) // compute sigmoid of the current sack and update the 
> sack
> ...sack(cos).by("x") // compute the cosine of the current element's "x" and 
> assign / overwrite the current sack value
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1388) Make ExpandableStepIterator non-final

[Marko A. Rodriguez (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188339#comment-16188339
 ] 

Marko A. Rodriguez commented on TINKERPOP-1388:
---

Is this still a desired change? If not, please close.

> Make ExpandableStepIterator non-final
> -
>
> Key: TINKERPOP-1388
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1388
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.1.3
>Reporter: Matthias Broecheler
>Assignee: Marko A. Rodriguez
>Priority: Minor
>
> to allow TinkerPop implementations to extend it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187981#comment-16187981
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
This makes reviewing so much easier!
VOTE +1

If anyone is interested, these are the times (in seconds) for building each 
doc:
15 /usr/src/tinkermem/docs/src/recipes/duplicate-vertex.asciidoc
16 /usr/src/tinkermem/docs/src/recipes/connected-components.asciidoc
17 /usr/src/tinkermem/docs/src/recipes/shortest-path.asciidoc
18 /usr/src/tinkermem/docs/src/recipes/if-then-based-grouping.asciidoc
18 /usr/src/tinkermem/docs/src/recipes/style-guide.asciidoc
20 /usr/src/tinkermem/docs/src/recipes/between-vertices.asciidoc
20 /usr/src/tinkermem/docs/src/recipes/pagination.asciidoc
21 /usr/src/tinkermem/docs/src/recipes/traversal-component-reuse.asciidoc
22 /usr/src/tinkermem/docs/src/recipes/cycle-detection.asciidoc
23 /usr/src/tinkermem/docs/src/recipes/duplicate-edge.asciidoc
26 
/usr/src/tinkermem/docs/src/reference/implementations-tinkergraph.asciidoc
28 /usr/src/tinkermem/docs/src/recipes/centrality.asciidoc
29 
/usr/src/tinkermem/docs/src/reference/implementations-hadoop-start.asciidoc
31 /usr/src/tinkermem/docs/src/recipes/tree.asciidoc
35 /usr/src/tinkermem/docs/src/recipes/recommendation.asciidoc
35 /usr/src/tinkermem/docs/src/recipes/traversal-induced-values.asciidoc
41 /usr/src/tinkermem/docs/src/recipes/appendix.asciidoc
42 /usr/src/tinkermem/docs/src/reference/implementations-spark.asciidoc
43 /usr/src/tinkermem/docs/src/reference/gremlin-variants.asciidoc
47 /usr/src/tinkermem/docs/src/reference/implementations-hadoop-end.asciidoc
53 /usr/src/tinkermem/docs/src/reference/intro.asciidoc
56 /usr/src/tinkermem/docs/src/reference/implementations-neo4j.asciidoc
83 /usr/src/tinkermem/docs/src/reference/the-graphcomputer.asciidoc
94 /usr/src/tinkermem/docs/src/reference/the-graph.asciidoc
96 /usr/src/tinkermem/docs/src/tutorials/getting-started/index.asciidoc
98 /usr/src/tinkermem/docs/src/tutorials/the-gremlin-console/index.asciidoc
139 /usr/src/tinkermem/docs/src/dev/provider/index.asciidoc
174 /usr/src/tinkermem/docs/src/reference/implementations-giraph.asciidoc
326 /usr/src/tinkermem/docs/src/reference/gremlin-applications.asciidoc
578 /usr/src/tinkermem/docs/src/reference/the-traversal.asciidoc



> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #725: TINKERPOP-1661 Docker-built documentation does not alw...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
This makes reviewing so much easier!
VOTE +1

If anyone is interested, these are the times (in seconds) for building each 
doc:
15 /usr/src/tinkermem/docs/src/recipes/duplicate-vertex.asciidoc
16 /usr/src/tinkermem/docs/src/recipes/connected-components.asciidoc
17 /usr/src/tinkermem/docs/src/recipes/shortest-path.asciidoc
18 /usr/src/tinkermem/docs/src/recipes/if-then-based-grouping.asciidoc
18 /usr/src/tinkermem/docs/src/recipes/style-guide.asciidoc
20 /usr/src/tinkermem/docs/src/recipes/between-vertices.asciidoc
20 /usr/src/tinkermem/docs/src/recipes/pagination.asciidoc
21 /usr/src/tinkermem/docs/src/recipes/traversal-component-reuse.asciidoc
22 /usr/src/tinkermem/docs/src/recipes/cycle-detection.asciidoc
23 /usr/src/tinkermem/docs/src/recipes/duplicate-edge.asciidoc
26 
/usr/src/tinkermem/docs/src/reference/implementations-tinkergraph.asciidoc
28 /usr/src/tinkermem/docs/src/recipes/centrality.asciidoc
29 
/usr/src/tinkermem/docs/src/reference/implementations-hadoop-start.asciidoc
31 /usr/src/tinkermem/docs/src/recipes/tree.asciidoc
35 /usr/src/tinkermem/docs/src/recipes/recommendation.asciidoc
35 /usr/src/tinkermem/docs/src/recipes/traversal-induced-values.asciidoc
41 /usr/src/tinkermem/docs/src/recipes/appendix.asciidoc
42 /usr/src/tinkermem/docs/src/reference/implementations-spark.asciidoc
43 /usr/src/tinkermem/docs/src/reference/gremlin-variants.asciidoc
47 /usr/src/tinkermem/docs/src/reference/implementations-hadoop-end.asciidoc
53 /usr/src/tinkermem/docs/src/reference/intro.asciidoc
56 /usr/src/tinkermem/docs/src/reference/implementations-neo4j.asciidoc
83 /usr/src/tinkermem/docs/src/reference/the-graphcomputer.asciidoc
94 /usr/src/tinkermem/docs/src/reference/the-graph.asciidoc
96 /usr/src/tinkermem/docs/src/tutorials/getting-started/index.asciidoc
98 /usr/src/tinkermem/docs/src/tutorials/the-gremlin-console/index.asciidoc
139 /usr/src/tinkermem/docs/src/dev/provider/index.asciidoc
174 /usr/src/tinkermem/docs/src/reference/implementations-giraph.asciidoc
326 /usr/src/tinkermem/docs/src/reference/gremlin-applications.asciidoc
578 /usr/src/tinkermem/docs/src/reference/the-traversal.asciidoc



---

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187880#comment-16187880
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
Ignore that.  Somehow my branch was reset to master.  Rebuilding...


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #725: TINKERPOP-1661 Docker-built documentation does not alw...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
Ignore that.  Somehow my branch was reset to master.  Rebuilding...


---

[GitHub] tinkerpop issue #725: TINKERPOP-1661 Docker-built documentation does not alw...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
Hmm.. even Reference Doc isn't local.  Thought it was the first time I 
looked at it.


---

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187869#comment-16187869
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
I ended up using a local copy of hadoop 2.7.2 to complete my docker rebuild.

Anyway, 'Reference Documentation' is now a local link but everything else 
still points to 'tinkerpop.apache.org'



> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #725: TINKERPOP-1661 Docker-built documentation does not alw...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
I ended up using a local copy of hadoop 2.7.2 to complete my docker rebuild.

Anyway, 'Reference Documentation' is now a local link but everything else 
still points to 'tinkerpop.apache.org'



---

Re: [DISCUSS] Add Ferma to "Community Contributions" Listing

[Stephen Mallette]

Looks fine to me.

On Sun, Oct 1, 2017 at 12:40 PM, Jeffrey Freeman <
jeffrey.free...@syncleus.com> wrote:

> OK so I changed the reference in the README and the docs as you requested.
> Please let me know if that is sufficient or if you need me to change it
> everywhere the word tinkerpop is used (including phrases like "Tinkerpop3"
>
> On Sun, Oct 1, 2017 at 12:33 PM, Jeffrey Freeman <
> jeffrey.free...@syncleus.com> wrote:
>
> > One question. In some places i reference the specific version as
> > "Tinkerpop3" can those references remain as-is, if they are to be
> reworded
> > whats the proper format for those?
> >
> > On Sun, Oct 1, 2017 at 12:32 PM, Jeffrey Freeman <
> > jeffrey.free...@syncleus.com> wrote:
> >
> >> Happy to make those changed. If I understand you correct the issue is
> >> just with naming "Tinkerpop" to "Apache TinkerPop™" to make the
> >> trademark more clear? I'm happy to do that, assuming markdown can
> support
> >> the tm mark, if not ill add it as (tm).
> >>
> >> On Sun, Oct 1, 2017 at 11:23 AM, Stephen Mallette  >
> >> wrote:
> >>
> >>> +1 from me - pending some fixes in initial references to "TinkerPop" in
> >>> Ferma README and web site/docs to become "Apache TinkerPop™". Other
> than
> >>> that it looks good to me.
> >>>
> >>> We'll give this 72 hours to see if anyone else has comments - assuming
> no
> >>> objections we can get Ferma into the listing after that. Thanks for
> your
> >>> continued contribution in this area.
> >>>
> >>> On Sun, Oct 1, 2017 at 11:11 AM, Jeffrey Freeman <
> >>> jeffrey.free...@syncleus.com> wrote:
> >>>
> >>> > Ferma should be listed in the "Community Contributions" section of
> the
> >>> main
> >>> > tinkerpop3 apache site ( http://tinkerpop.apache.org )
> >>> >
> >>> > Their project/github link: https://github.com/Syncleus/Ferma
> >>> > Their website and documentation: http://syncleus.com/Ferma
> >>> >
> >>> > They meet all requirements in the policy document (
> >>> > http://tinkerpop.apache.org/policy.html ) including full support for
> >>> > Tinkerpop3, their own website, many releases, and documentation.
> >>> >
> >>> > I've also created the following ticket to help speed this along:
> >>> > https://issues.apache.org/jira/browse/TINKERPOP-1794
> >>> >
> >>> > (FYI I know i sent a similar email earlier, this new e-mail is in a
> >>> format
> >>> > as suggested from a member of the community in that thread)
> >>> >
> >>>
> >>
> >>
> >
>