[jira] [Commented] (TINKERPOP-1333) Create a new toy graph with its own serializations and IORegistry.

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425323#comment-16425323 ] stephen mallette commented on TINKERPOP-1333: - Just realized that this would have to now

[jira] [Commented] (TINKERPOP-1933) gremlin-python maximum recursion depth exceeded on large responses

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425316#comment-16425316 ] stephen mallette commented on TINKERPOP-1933: - can you please provide some more details?

Re: [VOTE] TinkerPop 3.2.8 Release

2018-04-04 Thread Stephen Mallette
ugh - not to be sloppy but do we need to kill the artifacts we've already built over that? how bad would it be if we simply remembered to make that change at time of deployment? would that cause problems? On Wed, Apr 4, 2018 at 5:44 AM, Jorge Bay Gondra wrote: > It

[jira] [Updated] (TINKERPOP-1934) Bump to latest version of httpclient

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1934: Fix Version/s: 3.3.3 3.4.0 > Bump to latest version of

[GitHub] tinkerpop issue #829: TINKERPOP-1888 Extend max and min to all Comparable pr...

2018-04-04 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/829 I thought about the upgrade docs, but felt like it's not necessary as existing working scenarios didn't change, we just allow more now. But, well, I can add something. ---

[jira] [Closed] (TINKERPOP-1722) Allow graph implementations to supply their own implementation of StarGraph

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1722. --- Resolution: Won't Do spoke to bryn on the side - he's agreed that this is no

[jira] [Commented] (TINKERPOP-1888) Extend max and min to all Comparable properties, not just Numbers

2018-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425575#comment-16425575 ] ASF GitHub Bot commented on TINKERPOP-1888: --- Github user dkuppitz commented on a diff in the

[GitHub] tinkerpop pull request #829: TINKERPOP-1888 Extend max and min to all Compar...

2018-04-04 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/829#discussion_r179155101 --- Diff: CHANGELOG.asciidoc --- @@ -25,6 +25,7 @@ NEED AND IMAGE This release also includes changes from <>.

[GitHub] tinkerpop issue #829: TINKERPOP-1888 Extend max and min to all Comparable pr...

2018-04-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/829 yeah - i tend to think of upgrade docs as extending to more than just breaking changes. it should also include any new features that people might like to know about and that we want to call

Re: [VOTE] TinkerPop 3.2.8 Release

2018-04-04 Thread Stephen Mallette
If everyone else is ok with the little hack job to get this first deployment out, I think I am. On Wed, Apr 4, 2018 at 7:55 AM, Jorge Bay Gondra wrote: > Whatever you feel more comfortable, as the only risk is publishing it under > the name gremlin-javascript which is

[jira] [Commented] (TINKERPOP-1888) Extend max and min to all Comparable properties, not just Numbers

2018-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425547#comment-16425547 ] ASF GitHub Bot commented on TINKERPOP-1888: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop pull request #829: TINKERPOP-1888 Extend max and min to all Compar...

2018-04-04 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/829#discussion_r179146832 --- Diff: CHANGELOG.asciidoc --- @@ -25,6 +25,7 @@ NEED AND IMAGE This release also includes changes from <>.

[jira] [Commented] (TINKERPOP-1888) Extend max and min to all Comparable properties, not just Numbers

2018-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425538#comment-16425538 ] ASF GitHub Bot commented on TINKERPOP-1888: --- Github user spmallette commented on a diff in

[jira] [Commented] (TINKERPOP-1933) gremlin-python maximum recursion depth exceeded on large responses

2018-04-04 Thread Branden Moore (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425581#comment-16425581 ] Branden Moore commented on TINKERPOP-1933: -- Using bytecode-based traversals, if I issue any

[jira] [Updated] (TINKERPOP-1934) Bump to latest version of httpclient

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1934: Fix Version/s: 3.2.9 > Bump to latest version of httpclient >

[jira] [Commented] (TINKERPOP-1888) Extend max and min to all Comparable properties, not just Numbers

2018-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425591#comment-16425591 ] ASF GitHub Bot commented on TINKERPOP-1888: --- Github user spmallette commented on a diff in

[jira] [Commented] (TINKERPOP-1888) Extend max and min to all Comparable properties, not just Numbers

2018-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425587#comment-16425587 ] ASF GitHub Bot commented on TINKERPOP-1888: --- Github user dkuppitz commented on the issue:

Re: [VOTE] TinkerPop 3.2.8 Release

2018-04-04 Thread Jorge Bay Gondra
Whatever you feel more comfortable, as the only risk is publishing it under the name gremlin-javascript which is going to be deprecated anyways. If you are going to manually execute "npm publish" in your terminal, you have to only change the package name in package.json. If you are planning to

Re: [VOTE] TinkerPop 3.2.8 Release

2018-04-04 Thread Ted Wilmes
Thanks for catching that Jorge. I'm okay with the hack. I'll setup an npms.js and nuget account. --Ted On Wed, Apr 4, 2018 at 7:29 AM, Stephen Mallette wrote: > If everyone else is ok with the little hack job to get this first > deployment out, I think I am. > > > On Wed,

[jira] [Created] (TINKERPOP-1934) Bump to latest version of httpclient

2018-04-04 Thread stephen mallette (JIRA)
stephen mallette created TINKERPOP-1934: --- Summary: Bump to latest version of httpclient Key: TINKERPOP-1934 URL: https://issues.apache.org/jira/browse/TINKERPOP-1934 Project: TinkerPop

[GitHub] tinkerpop issue #829: TINKERPOP-1888 Extend max and min to all Comparable pr...

2018-04-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/829 Perhaps this needs upgrade docs for 3.4.0 as well? I think it would be good to call attention to this change in behavior. ---

[jira] [Commented] (TINKERPOP-519) Create a security strategy to ship with TP3

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425727#comment-16425727 ] stephen mallette commented on TINKERPOP-519: I'm feeling like we shouldn't add any more of

[jira] [Assigned] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette reassigned TINKERPOP-1143: --- Assignee: stephen mallette > Remove deprecated TraversalSource.Builder

[jira] [Updated] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1143: Fix Version/s: 3.4.0 > Remove deprecated TraversalSource.Builder and

[jira] [Updated] (TINKERPOP-1707) Remove deprecated AuthenticationSettings.className option

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1707: Fix Version/s: 3.4.0 > Remove deprecated AuthenticationSettings.className

[jira] [Assigned] (TINKERPOP-1707) Remove deprecated AuthenticationSettings.className option

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette reassigned TINKERPOP-1707: --- Assignee: stephen mallette > Remove deprecated

[jira] [Closed] (TINKERPOP-1674) Traversals reference elements after deletion

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1674. --- Resolution: Cannot Reproduce closing pending additional information (i.e. an

[jira] [Updated] (TINKERPOP-1817) OLAP loses vertex labels

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1817: Issue Type: Improvement (was: Bug) My understanding here is that we never

[jira] [Updated] (TINKERPOP-831) How should OLAP treat Collection objects? No contract is specified.

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-831: --- Issue Type: Improvement (was: Bug) > How should OLAP treat Collection objects? No

[jira] [Updated] (TINKERPOP-1831) Refactor EventStrategy

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1831: Fix Version/s: 3.4.0 > Refactor EventStrategy > --- > >

[jira] [Updated] (TINKERPOP-1705) Remove deprecated rebindings option

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1705: Fix Version/s: 3.4.0 > Remove deprecated rebindings option >

[jira] [Commented] (TINKERPOP-1888) Extend max and min to all Comparable properties, not just Numbers

2018-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425631#comment-16425631 ] ASF GitHub Bot commented on TINKERPOP-1888: --- Github user robertdale commented on a diff in

[GitHub] tinkerpop pull request #829: TINKERPOP-1888 Extend max and min to all Compar...

2018-04-04 Thread robertdale
Github user robertdale commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/829#discussion_r179166260 --- Diff: docs/src/reference/the-traversal.asciidoc --- @@ -1515,16 +1516,17 @@

[GitHub] tinkerpop pull request #829: TINKERPOP-1888 Extend max and min to all Compar...

2018-04-04 Thread robertdale
Github user robertdale commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/829#discussion_r179166002 --- Diff: docs/src/reference/the-traversal.asciidoc --- @@ -1471,16 +1471,17 @@

[jira] [Commented] (TINKERPOP-1888) Extend max and min to all Comparable properties, not just Numbers

2018-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425632#comment-16425632 ] ASF GitHub Bot commented on TINKERPOP-1888: --- Github user robertdale commented on a diff in

[jira] [Commented] (TINKERPOP-1757) GiraphGraphComputer does not start Zookeeper in local mode

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425681#comment-16425681 ] stephen mallette commented on TINKERPOP-1757: - Given that we haven't dropped Giraph in

[jira] [Commented] (TINKERPOP-1757) GiraphGraphComputer does not start Zookeeper in local mode

2018-04-04 Thread Marc de Lignie (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426019#comment-16426019 ] Marc de Lignie commented on TINKERPOP-1757: --- I am afraid that not the fix is trivial but

[jira] [Closed] (TINKERPOP-1757) GiraphGraphComputer does not start Zookeeper in local mode

2018-04-04 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1757. --- Resolution: Won't Fix closing per discussion above > GiraphGraphComputer does

[jira] [Commented] (TINKERPOP-1933) gremlin-python maximum recursion depth exceeded on large responses

2018-04-04 Thread David M. Brown (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426003#comment-16426003 ] David M. Brown commented on TINKERPOP-1933: --- Looks like this is being caused by recursive

[jira] [Commented] (TINKERPOP-1888) Extend max and min to all Comparable properties, not just Numbers

2018-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426083#comment-16426083 ] ASF GitHub Bot commented on TINKERPOP-1888: --- Github user robertdale commented on the issue:

Re: [VOTE] TinkerPop 3.3.2 Release

2018-04-04 Thread Daniel Kuppitz
The PGP signature check fails for me. daniel@cube /projects/apache/tinkerpop (tp33) $ bin/validate-distribution.sh 3.3.2 Validating binary distributions * downloading Apache TinkerPop Gremlin (apache-tinkerpop-gremlin-console-3.3.2-bin.zip)... OK * validating signatures and checksums ... *

Re: [VOTE] TinkerPop 3.3.2 Release

2018-04-04 Thread Stephen Mallette
I haven't changed anything - i wonder why this is suddenly an issue. I guess it worked for me locally because i was the person who signed it? On Wed, Apr 4, 2018 at 4:47 PM, Daniel Kuppitz wrote: > gpg: Signature made Tue 03 Apr 2018 12:53:16 PM MST > gpg:

[GitHub] tinkerpop issue #829: TINKERPOP-1888 Extend max and min to all Comparable pr...

2018-04-04 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/829 VOTE +1 ---

Re: [VOTE] TinkerPop 3.3.2 Release

2018-04-04 Thread Daniel Kuppitz
gpg: Signature made Tue 03 Apr 2018 12:53:16 PM MST gpg:using RSA key EA53A99854EAB0E6 gpg: Good signature from "Stephen Mallette " [unknown] gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the

Re: [VOTE] TinkerPop 3.3.2 Release

2018-04-04 Thread Daniel Kuppitz
Either this or I might have a newer gpg version which changed the output slightly. We already ignore the suffix for Ted and Jason, so I guess we should just use the same pattern for everyone. I can CTR this change into all main branches; it's just that: -[ `gpg ${ZIP_FILENAME}.asc 2>&1 | grep -c

Re: [VOTE] TinkerPop 3.3.2 Release

2018-04-04 Thread Stephen Mallette
out of curiosity - what gpg version do you have? i'm on: $ gpg --version gpg (GnuPG) 1.4.16 is that ancient or something? i'd be curious if anyone else has this problem. it's also semi-concerning that this doesn't work because we'd want to the verification to behave right with the instructions

Re: [VOTE] TinkerPop 3.3.2 Release

2018-04-04 Thread Daniel Kuppitz
Much newer. $ gpg --version gpg (GnuPG) 2.1.15 libgcrypt 1.7.8 Copyright (C) 2016 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later < https://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent

Re: [VOTE] TinkerPop 3.3.2 Release

2018-04-04 Thread Daniel Kuppitz
With the suffix ignored it all looks good. Validating binary distributions * downloading Apache TinkerPop Gremlin (apache-tinkerpop-gremlin-console-3.3.2-bin.zip)... OK * validating signatures and checksums ... * PGP signature ... OK * MD5 checksum ... OK * SHA1 checksum ... OK * unzipping

[DISCUSS] gpg check in validate-distribution.sh [Was: [VOTE] TinkerPop 3.3.2 Release]

2018-04-04 Thread Stephen Mallette
Kuppitz, just thought I'd start a fresh thread for this gpg issue. Reading about how to validate the authenticity of a key a bit and it seems like a reasonable level of validation would be to verify the key against the list of apache committers: https://people.apache.org/keys/committer/ I guess

Re: [DISCUSS] gpg check in validate-distribution.sh [Was: [VOTE] TinkerPop 3.3.2 Release]

2018-04-04 Thread Daniel Kuppitz
I guess we could use the link above, but we would still have to have a hard coded list of committers, unless we want to allow any Apache committer to sign the artifacts. But it still sounds more secure to do it this way, I'll give it a try tomorrow. On Wed, Apr 4, 2018, 2:21 PM Stephen Mallette

[jira] [Commented] (TINKERPOP-1933) gremlin-python maximum recursion depth exceeded on large responses

2018-04-04 Thread Branden Moore (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426207#comment-16426207 ] Branden Moore commented on TINKERPOP-1933: -- Please go for it.  Thanks! > gremlin-python

Re: [VOTE] TinkerPop 3.2.8 Release

2018-04-04 Thread Jorge Bay Gondra
It looks like the JavaScript package still points to "gremlin-javascript", instead of "gremlin" https://github.com/apache/tinkerpop/blob/3.2.8/gremlin-javascript/src/main/javascript/gremlin-javascript/package.json#L2 We should change that on both 3.2 and 3.3 branches. Also, if you are planning