GRAPHSON 3.0 serializing, IO Ref, and parent map exception
Hey guys,
Just been working on implementing GRAPHSON 3.0 into the php world. (testing
against gremlin-server 3.3.2)
I noticed that the following request message fails:
{
"@type":"g:Map",
"@value":[
"requestId","f990037e-3b55-49a4-a108-2f0e8c162715",
"processor","",
"op","eval",
"args",{"@type":"g:Map","@value":["gremlin","5+5"]}
]
}
While this one doesn't:
{
"requestId":"bf26426b-ba27-475f-aafa-527ce0b0116c",
"processor":"",
"op":"eval",
"args":{"@type":"g:Map","@value":["gremlin","5+5"]}
}
}
Seems like the parent map should not be serialized using GRAPHSON 3.0
standards. This isn't readily apparent because going through the code I
noticed both gremlin-javascript and gremlin-python seem to simply fall back
to JSON natives for this task and don't define the map type? PHP is very
much the same and I could fall back to JSON natives, but is this an
oversight? You would expect the entire "message" portion of the
Websocket RequestMessage
to be serialized by the same standard.
I've overall done a decent job of staying up to date with the mailing list
(even though I haven't participated) but I may have overlooked this already
being discussed. If anyone has a tldr regarding this that would be great?
Thanks!
FYI : error message for the first one, it seems to choke on the @value
List.
[WARN] AbstractGraphSONMessageSerializerV2d0 - Request
[PooledUnsafeDirectByteBuf(ridx: 158, widx: 158, cap: 175)] could not be
deserialized by org.apache.tinkerpop.gremlin.driver.ser.
AbstractGraphSONMessageSerializerV2d0.
org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException: Could
not deserialize the JSON value as required. Nested exception:
java.lang.InstantiationException:
Cannot deserialize the value with the detected type contained in the JSON
('g:Map') to the type specified in parameter to the object mapper (class
org.apache.tinkerpop.gremlin.driver.message.RequestMessage). Those types
are incompatible.
at [Source: (byte[])"{"@type":"g:Map","@value":["requestId","f990037e-
3b55-49a4-a108-2f0e8c162715","processor","","op","eval","
args",{"@type":"g:Map","@value":["gremlin","5+5"]}]}"; line: 1, column: 27]
[jira] [Commented] (TINKERPOP-1897) Provide Docker images of Gremlin Server and Console
[ https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438706#comment-16438706 ] ASF GitHub Bot commented on TINKERPOP-1897: --- Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/802 > move that entire configuration to the root pom.xml Good point @spmallette, I just pushed a commit for that and also rebased the PR. > Provide Docker images of Gremlin Server and Console > --- > > Key: TINKERPOP-1897 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1897 > Project: TinkerPop > Issue Type: Improvement > Components: console, server >Affects Versions: 3.2.7 >Reporter: Florian Hockmann >Assignee: Florian Hockmann >Priority: Major > > TinkerPop should provide Docker images of Gremlin Server and Gremlin Console > that are deployed together with each release. > This originated from the mailing list: > [https://lists.apache.org/thread.html/744ae19afa9b2fd1984c1e4dddc588e98786d9c21b633aab8bfa@%3Cdev.tinkerpop.apache.org%3E] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #802: Add docker images for console and server TINKERPOP-189...
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/802 > move that entire configuration to the root pom.xml Good point @spmallette, I just pushed a commit for that and also rebased the PR. ---
[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search
[ https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438684#comment-16438684 ] ASF GitHub Bot commented on TINKERPOP-1822: --- Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/838 @mpollmeier I was running `mvn clean install` locally, and had the same issue with that test stalling out. A few builds before this had different errors in Travis, not just stalling out, so it looks like some of the changes i pushed EOD took care of those. I can take care of the js issue and the .net stuff. I'm not sure about the `TinkerGraphProcessComputerTest` stalling out though or the Travis stuff stalling out. I'll take a swing at the js and .net stuff and see how that plays out for now. > Repeat should depth first search > > > Key: TINKERPOP-1822 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1822 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.3.0, 3.2.6 >Reporter: Robert Dale >Priority: Major > > Perhaps optionally. > See also: > * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE > * https://github.com/apache/tinkerpop/pull/715 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/838 @mpollmeier I was running `mvn clean install` locally, and had the same issue with that test stalling out. A few builds before this had different errors in Travis, not just stalling out, so it looks like some of the changes i pushed EOD took care of those. I can take care of the js issue and the .net stuff. I'm not sure about the `TinkerGraphProcessComputerTest` stalling out though or the Travis stuff stalling out. I'll take a swing at the js and .net stuff and see how that plays out for now. ---
