[GitHub] tinkerpop pull request #451: Tinkerpop 1458 Gremlin Server doesn't return co...

2016-10-05 Thread davebshow
Github user davebshow commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/451#discussion_r82095012 --- Diff: gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffects.java --- @@ -54,22 +57,30 @@ public D

[DISCUSS] gremlin-python 3.2.3 GA

2016-10-05 Thread Stephen Mallette
So, I inadvertently released gremlin-python as a release candidate in 3.2.2. As it turned out, that wasn't "bad" as we were still sorta tweaking things and wanted to be sure the APIs were solid. I didn't see us rethinking anything in any serious way, so I would have to say that for 3.2.3 we will go

[jira] [Commented] (TINKERPOP-1458) Gremlin Server doesn't return confirmation upon Traversal OpProcessor "close" op

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550153#comment-15550153 ] ASF GitHub Bot commented on TINKERPOP-1458: --- GitHub user davebshow opened a

[GitHub] tinkerpop pull request #451: Tinkerpop 1458 Gremlin Server doesn't return co...

2016-10-05 Thread davebshow
GitHub user davebshow opened a pull request: https://github.com/apache/tinkerpop/pull/451 Tinkerpop 1458 Gremlin Server doesn't return confirmation upon Traversal OpProcessor "close" op https://issues.apache.org/jira/browse/TINKERPOP-1458 This PR updates the Gremlin Server

[jira] [Commented] (TINKERPOP-1455) Provide String-based withStrategy()/withoutStrategy() for language variant usage

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549797#comment-15549797 ] ASF GitHub Bot commented on TINKERPOP-1455: --- Github user dkuppitz commented

[GitHub] tinkerpop issue #447: TINKERPOP-1455: Provide String-based withStrategy()/wi...

2016-10-05 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/447 Cool. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[jira] [Commented] (TINKERPOP-1044) ResponseMessage should contain server-side exception name.

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549730#comment-15549730 ] ASF GitHub Bot commented on TINKERPOP-1044: --- Github user vrkrishn commented

[GitHub] tinkerpop issue #440: TINKERPOP-1044: Gremlin server REST endpoint - Add Exc...

2016-10-05 Thread vrkrishn
Github user vrkrishn commented on the issue: https://github.com/apache/tinkerpop/pull/440 Yeah I can take care of the AbstractEvalOpProcessor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[jira] [Closed] (TINKERPOP-1486) Improve API of RemoteConnection

2016-10-05 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1486. --- Resolution: Done Fix Version/s: 3.2.3 There was some discussion on the mail

[jira] [Commented] (TINKERPOP-1044) ResponseMessage should contain server-side exception name.

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549719#comment-15549719 ] ASF GitHub Bot commented on TINKERPOP-1044: --- Github user spmallette commente

[GitHub] tinkerpop issue #440: TINKERPOP-1044: Gremlin server REST endpoint - Add Exc...

2016-10-05 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/440 Glad that's working. Did you still intend to make the fix for the other channelizers in `AbstractEvalOpProcessor`? As for titan, i guess you would build this branch of tinkerpop with t

[GitHub] tinkerpop issue #440: TINKERPOP-1044: Gremlin server REST endpoint - Add Exc...

2016-10-05 Thread vrkrishn
Github user vrkrishn commented on the issue: https://github.com/apache/tinkerpop/pull/440 Luckily I was able to spin up a Linux VM and run the integration tests Tests run: 31, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 162.807 sec - in org.apache.tinkerpop.gremlin.serve

[jira] [Commented] (TINKERPOP-1044) ResponseMessage should contain server-side exception name.

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549697#comment-15549697 ] ASF GitHub Bot commented on TINKERPOP-1044: --- Github user vrkrishn commented

[jira] [Commented] (TINKERPOP-1455) Provide String-based withStrategy()/withoutStrategy() for language variant usage

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549644#comment-15549644 ] ASF GitHub Bot commented on TINKERPOP-1455: --- Github user spmallette commente

[GitHub] tinkerpop issue #447: TINKERPOP-1455: Provide String-based withStrategy()/wi...

2016-10-05 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/447 no problem from me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (TINKERPOP-1455) Provide String-based withStrategy()/withoutStrategy() for language variant usage

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549634#comment-15549634 ] ASF GitHub Bot commented on TINKERPOP-1455: --- Github user okram commented on

[GitHub] tinkerpop issue #447: TINKERPOP-1455: Provide String-based withStrategy()/wi...

2016-10-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/447 If you guys don't mind, I'm going to change the method signatures (the NEW methods added -- nothing from before changed). {code} withStrategy(String, Object...) -> withStrategies(Map...)

[jira] [Commented] (TINKERPOP-1455) Provide String-based withStrategy()/withoutStrategy() for language variant usage

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549597#comment-15549597 ] ASF GitHub Bot commented on TINKERPOP-1455: --- Github user spmallette commente

[GitHub] tinkerpop issue #447: TINKERPOP-1455: Provide String-based withStrategy()/wi...

2016-10-05 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/447 This is a great PR. Didn't think we'd have this for 3.2.3. Nice All tests pass with `docker/build.sh -t -i` - final "todo" would be to add a JIRA to track the deprecation for future rem

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549471#comment-15549471 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user okram commented on

[GitHub] tinkerpop issue #450: TINKERPOP-1489 Javascript GLV

2016-10-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/450 I just created this ticket: https://issues.apache.org/jira/browse/TINKERPOP-1490 @jorgebay -- can you review that ticket in terms of the `one()`, `list()` callback model you are using here

[jira] [Created] (TINKERPOP-1490) Provider a Future based Traversal.async(Function) terminal step

2016-10-05 Thread Marko A. Rodriguez (JIRA)
Marko A. Rodriguez created TINKERPOP-1490: - Summary: Provider a Future based Traversal.async(Function) terminal step Key: TINKERPOP-1490 URL: https://issues.apache.org/jira/browse/TINKERPOP-1490

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549453#comment-15549453 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user okram commented on

[GitHub] tinkerpop issue #450: TINKERPOP-1489 Javascript GLV

2016-10-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/450 I did a preliminary review of the code and it looks good. Primarily because it mimics the structure and content of Gremlin-Python. Ensuring consistency between all variants is important from a maint

[GitHub] tinkerpop issue #450: Javascript GLV

2016-10-05 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/450 @jorgebay thanks for this. I have a feeling it will take a some time to review this work and get community input. hopefully @jbmusso will have time to get involved. in the mean time co

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549216#comment-15549216 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user spmallette commente

[GitHub] tinkerpop issue #450: Javascript GLV

2016-10-05 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/450 Thanks @PommeVerte for getting a first look at it so fast. About `list()` and `one()`: - `next()` is a method exposed by the [Iterator protocol][1] which in newer versions of Ecm

[GitHub] tinkerpop issue #450: Javascript GLV

2016-10-05 Thread PommeVerte
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/450 Nice PR @jorgebay Can you elaborate on why you went for `list()` and `one()` rather than keeping the original method names of `toList()` and `next()`? I understand that they would still ha

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548890#comment-15548890 ] ASF GitHub Bot commented on TINKERPOP-1489: --- GitHub user jorgebay opened a p

[GitHub] tinkerpop pull request #450: Javascript GLV

2016-10-05 Thread jorgebay
GitHub user jorgebay opened a pull request: https://github.com/apache/tinkerpop/pull/450 Javascript GLV For [TINKERPOP-1489](https://issues.apache.org/jira/browse/TINKERPOP-1489). - Should work with any ES5 engine that supports CommonJs: tested with Nashorn and Node.js. - Ma

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2016-10-05 Thread Jorge Bay (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548867#comment-15548867 ] Jorge Bay commented on TINKERPOP-1489: -- I'll submit a pull request shortly for a

[jira] [Created] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2016-10-05 Thread Jorge Bay (JIRA)
Jorge Bay created TINKERPOP-1489: Summary: Provide a Javascript Gremlin Language Variant Key: TINKERPOP-1489 URL: https://issues.apache.org/jira/browse/TINKERPOP-1489 Project: TinkerPop Issue

[jira] [Commented] (TINKERPOP-1455) Provide String-based withStrategy()/withoutStrategy() for language variant usage

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548817#comment-15548817 ] ASF GitHub Bot commented on TINKERPOP-1455: --- Github user dkuppitz commented

[GitHub] tinkerpop issue #447: TINKERPOP-1455: Provide String-based withStrategy()/wi...

2016-10-05 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/447 Code looks good, `docker/build.sh -t -i` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] tinkerpop issue #444: TINKERPOP-1158 gremlin.sh -v emits log4j initializatio...

2016-10-05 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/444 The gist was that you could live without the 2 additional files, but your life would be affected by an everlasting sadness. Hence we concluded that we keep the symbolic links. However, I

[jira] [Commented] (TINKERPOP-1158) gremlin.sh -v emits log4j initialization errors

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548689#comment-15548689 ] ASF GitHub Bot commented on TINKERPOP-1158: --- Github user dkuppitz commented

[jira] [Commented] (TINKERPOP-1455) Provide String-based withStrategy()/withoutStrategy() for language variant usage

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548660#comment-15548660 ] ASF GitHub Bot commented on TINKERPOP-1455: --- Github user okram commented on

[jira] [Commented] (TINKERPOP-1158) gremlin.sh -v emits log4j initialization errors

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548656#comment-15548656 ] ASF GitHub Bot commented on TINKERPOP-1158: --- Github user okram commented on

[GitHub] tinkerpop issue #447: TINKERPOP-1455: Provide String-based withStrategy()/wi...

2016-10-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/447 ``` [INFO] [INFO] BUILD SUCCESS [INFO]

[GitHub] tinkerpop issue #444: TINKERPOP-1158 gremlin.sh -v emits log4j initializatio...

2016-10-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/444 Already did. Told @dkuppitz what he wanted to know... I forget what he deduced from that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[jira] [Commented] (TINKERPOP-1158) gremlin.sh -v emits log4j initialization errors

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548474#comment-15548474 ] ASF GitHub Bot commented on TINKERPOP-1158: --- Github user spmallette commente

[GitHub] tinkerpop issue #444: TINKERPOP-1158 gremlin.sh -v emits log4j initializatio...

2016-10-05 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/444 @okram can you please re-test? i personally never use the "convenience" `gremlin.sh` files as i don't like my `ext/` not getting cleaned between builds. it wouldn't bother me if they