[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...

2017-04-03 Thread mpollmeier
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/589 @robertdale thanks for checking. Must have happened during rebase. Here they are again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (TINKERPOP-891) Re-examine Sandboxing Abstractions

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954179#comment-15954179 ] ASF GitHub Bot commented on TINKERPOP-891: -- Github user dpitera commented on the issue:

[GitHub] tinkerpop issue #179: TINKERPOP-891 Refactored the sandboxing abstractions f...

2017-04-03 Thread dpitera
Github user dpitera commented on the issue: https://github.com/apache/tinkerpop/pull/179 I will have to investigate what you've just claimed, but if this is true, then yes you are right... I'll get back to you when I've confirmed. Thanks for the suggestion! --- If your project is

[jira] [Commented] (TINKERPOP-891) Re-examine Sandboxing Abstractions

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954163#comment-15954163 ] ASF GitHub Bot commented on TINKERPOP-891: -- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #179: TINKERPOP-891 Refactored the sandboxing abstractions f...

2017-04-03 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/179 That's a reasonable example. Could someone not just "blacklist" by whitelisting though? I just mean that the whitelisting system is all regex based. You could add negation to the whitelist and

[jira] [Commented] (TINKERPOP-891) Re-examine Sandboxing Abstractions

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954122#comment-15954122 ] ASF GitHub Bot commented on TINKERPOP-891: -- Github user dpitera commented on the issue:

[GitHub] tinkerpop issue #179: TINKERPOP-891 Refactored the sandboxing abstractions f...

2017-04-03 Thread dpitera
Github user dpitera commented on the issue: https://github.com/apache/tinkerpop/pull/179 > Whitelisting tends to work best in cases like this as it assumes everything is bad except for this small, easy to maintain list. Agreed. Which is what leads me to find myself in a

[jira] [Commented] (TINKERPOP-891) Re-examine Sandboxing Abstractions

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954092#comment-15954092 ] ASF GitHub Bot commented on TINKERPOP-891: -- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #179: TINKERPOP-891 Refactored the sandboxing abstractions f...

2017-04-03 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/179 I don't see a reference to `methodBlackList` in this PR, but if we were to just reduce the question to why do we have whitelisting and no blacklisting then I think I could probably answer

[jira] [Commented] (TINKERPOP-891) Re-examine Sandboxing Abstractions

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954051#comment-15954051 ] ASF GitHub Bot commented on TINKERPOP-891: -- Github user dpitera commented on the issue:

[GitHub] tinkerpop issue #179: TINKERPOP-891 Refactored the sandboxing abstractions f...

2017-04-03 Thread dpitera
Github user dpitera commented on the issue: https://github.com/apache/tinkerpop/pull/179 @spmallette I am curious why this Pull Request got rid of the `methodBlackList`? I ask because I want to extend the `FileSandboxExtension` here to support blacklisting-- would you prefer I did

[jira] [Commented] (TINKERPOP-1657) Provide abstraction to easily allow different HttpAuth schemes

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953887#comment-15953887 ] ASF GitHub Bot commented on TINKERPOP-1657: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop pull request #583: TINKERPOP-1657 Provide abstraction to easily al...

2017-04-03 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/583#discussion_r109478243 --- Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/Settings.java --- @@ -384,9 +384,25 @@ public SerializerSettings() {}

[DISCUSS] Remove deprecated fields/methods in Gremlin Server

2017-04-03 Thread Stephen Mallette
Every once in a while I peruse JIRA and I take notice of the large body of tickets around removing deprecated fields and methods in Gremlin Server. Some of this deprecation occurred along the 3.1.x line of code - I think it's time to just go through and clean all that up at this point. Here's the

[jira] [Commented] (TINKERPOP-1438) Consider GraphManager as an interface

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953726#comment-15953726 ] ASF GitHub Bot commented on TINKERPOP-1438: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #569: TINKERPOP-1438: GraphManager becomes a customizable in...

2017-04-03 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/569 Ran Gremlin Server integration tests locally to success - VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tinkerpop issue #583: TINKERPOP-1657 Provide abstraction to easily allow dif...

2017-04-03 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/583 @robertdale i'm glad you're thinking at that level wrt to security aspects of Gremlin Server. My understanding of SSL beyond what I've implemented so far is pretty weak, so if you have

[jira] [Commented] (TINKERPOP-1657) Provide abstraction to easily allow different HttpAuth schemes

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953681#comment-15953681 ] ASF GitHub Bot commented on TINKERPOP-1657: --- Github user spmallette commented on the issue:

[jira] [Commented] (TINKERPOP-1664) StarVertexProperty#property should throw an NPE if the value is null

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953572#comment-15953572 ] ASF GitHub Bot commented on TINKERPOP-1664: --- Github user robertdale commented on the issue:

[GitHub] tinkerpop issue #590: TINKERPOP-1664 StarVertexProperty will check meta-prop...

2017-04-03 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/590 Looks like a candidate for tp31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tinkerpop pull request #590: TINKERPOP-1664 StarVertexProperty will check me...

2017-04-03 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/590#discussion_r109411238 --- Diff: CHANGELOG.asciidoc --- @@ -64,6 +64,7 @@ TinkerPop 3.2.5 (Release Date: NOT OFFICIALLY RELEASED YET) * Improved error handling of

[GitHub] tinkerpop issue #590: TINKERPOP-1664 StarVertexProperty will check meta-prop...

2017-04-03 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/590 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (TINKERPOP-1664) StarVertexProperty#property should throw an NPE if the value is null

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953436#comment-15953436 ] ASF GitHub Bot commented on TINKERPOP-1664: --- Github user okram commented on the issue:

[jira] [Commented] (TINKERPOP-1664) StarVertexProperty#property should throw an NPE if the value is null

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953435#comment-15953435 ] ASF GitHub Bot commented on TINKERPOP-1664: --- Github user okram commented on a diff in the

[jira] [Commented] (TINKERPOP-1663) Validate a maximum for the number of parameters passed to Gremlin Server

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953329#comment-15953329 ] ASF GitHub Bot commented on TINKERPOP-1663: --- GitHub user spmallette opened a pull request:

[jira] [Commented] (TINKERPOP-1664) StarVertexProperty#property should throw an NPE if the value is null

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953302#comment-15953302 ] ASF GitHub Bot commented on TINKERPOP-1664: --- GitHub user BrynCooke opened a pull request:

[GitHub] tinkerpop pull request #590: TINKERPOP-1664 StarVertexProperty will check me...

2017-04-03 Thread BrynCooke
GitHub user BrynCooke opened a pull request: https://github.com/apache/tinkerpop/pull/590 TINKERPOP-1664 StarVertexProperty will check meta-properties are valid. StarVertexProperty will check meta-properties are valid. You can merge this pull request into a Git repository by

[jira] [Created] (TINKERPOP-1664) StarVertexProperty#property should throw an NPE if the value is null

2017-04-03 Thread Bryn Cooke (JIRA)
Bryn Cooke created TINKERPOP-1664: - Summary: StarVertexProperty#property should throw an NPE if the value is null Key: TINKERPOP-1664 URL: https://issues.apache.org/jira/browse/TINKERPOP-1664