[jira] [Closed] (TINKERPOP-1787) Allow :remote command to accept a user defined Cluster instance

2017-09-22 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1787. --- Resolution: Done Fix Version/s: 3.3.1 3.2.7 > Allow :rem

[jira] [Commented] (TINKERPOP-1752) Gremlin.Net: Generate completely type-safe methods

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176768#comment-16176768 ] ASF GitHub Bot commented on TINKERPOP-1752: --- Github user spmallette commente

[GitHub] tinkerpop issue #712: TINKERPOP-1752: Gremlin.Net: Generate completely type-...

2017-09-22 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/712 Changes look generally ok to me, but I'll let @jorgebay do a more technical review of the code itself as i'm still trying to get my head back into .NET. Getting rid of the `params object[] args

[jira] [Closed] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1731. --- Resolution: Fixed > Docker build does not appear to work for gremlin-dotnet >

[jira] [Closed] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1731. --- Resolution: Fixed Assignee: stephen mallette Fix Version/s: 3.3.1

[jira] [Reopened] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette reopened TINKERPOP-1731: - > Docker build does not appear to work for gremlin-dotnet > --

[jira] [Updated] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1731: Issue Type: Bug (was: Improvement) > Docker build does not appear to work for g

[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176717#comment-16176717 ] ASF GitHub Bot commented on TINKERPOP-1731: --- Github user asfgit closed the p

[GitHub] tinkerpop pull request #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/719 ---

[GitHub] tinkerpop issue #714: TINKERPOP-1782 RangeByIsCountStrategy doesn't handle f...

2017-09-22 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/714 Tests in the jira ticket work as expected. VOTE +1 ---

[jira] [Commented] (TINKERPOP-1782) RangeByIsCountStrategy doesn't handle floating point numbers properly

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176683#comment-16176683 ] ASF GitHub Bot commented on TINKERPOP-1782: --- Github user robertdale commente

[jira] [Commented] (TINKERPOP-1787) Allow :remote command to accept a user defined Cluster instance

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176608#comment-16176608 ] ASF GitHub Bot commented on TINKERPOP-1787: --- Github user robertdale commente

[GitHub] tinkerpop issue #718: TINKERPOP-1787 Add syntax for :remote to accept a Clus...

2017-09-22 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/718 VOTE +1 ---

[jira] [Commented] (TINKERPOP-1692) Bump to Neo4j 3.2.3

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176600#comment-16176600 ] ASF GitHub Bot commented on TINKERPOP-1692: --- Github user asfgit closed the p

[GitHub] tinkerpop pull request #674: Neo4j upgrade to 3.2.2 - TINKERPOP-1692

2017-09-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/674 ---

[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176596#comment-16176596 ] ASF GitHub Bot commented on TINKERPOP-1731: --- Github user jorgebay commented

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/719 dotnet tests pass on docker 🎉 Relevant lines: ``` Test run for /usr/src/tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/bin/Release/netcoreapp1.0/Gremlin.Net.In

[jira] [Commented] (TINKERPOP-1783) PageRank gives incorrect results for graphs with sinks

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176530#comment-16176530 ] ASF GitHub Bot commented on TINKERPOP-1783: --- Github user asfgit closed the p

[jira] [Closed] (TINKERPOP-1783) PageRank gives incorrect results for graphs with sinks

2017-09-22 Thread Marko A. Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marko A. Rodriguez closed TINKERPOP-1783. - Resolution: Fixed Fix Version/s: 3.3.1 > PageRank gives incorrect resul

[GitHub] tinkerpop pull request #717: TINKERPOP-1783: PageRank gives incorrect result...

2017-09-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/717 ---

[jira] [Commented] (TINKERPOP-1783) PageRank gives incorrect results for graphs with sinks

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176529#comment-16176529 ] ASF GitHub Bot commented on TINKERPOP-1783: --- Github user spmallette commente

[jira] [Commented] (TINKERPOP-1789) Reference elements should be represented by id and label

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176526#comment-16176526 ] ASF GitHub Bot commented on TINKERPOP-1789: --- Github user okram commented on

[GitHub] tinkerpop issue #717: TINKERPOP-1783: PageRank gives incorrect results for g...

2017-09-22 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/717 All tests pass with `docker/build.sh -t -i` VOTE +1 ---

[GitHub] tinkerpop pull request #720: TINKERPOP-1789: Reference elements should be re...

2017-09-22 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/720#discussion_r140513636 --- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc --- @@ -95,6 +95,19 @@ In `gremlin-test` there is a new `GraphHelper` class that has a `cloneEl

[jira] [Created] (TINKERPOP-1791) GremlinDsl custom step with generic end type produces invalid code in __.java

2017-09-22 Thread Severin Stampler (JIRA)
Severin Stampler created TINKERPOP-1791: --- Summary: GremlinDsl custom step with generic end type produces invalid code in __.java Key: TINKERPOP-1791 URL: https://issues.apache.org/jira/browse/TINKERPOP-1791

Re: [DISCUSS] GLV Test Suite

2017-09-22 Thread Stephen Mallette
Thanks for the update. I'm trying to keep the test language as simple as possible so that we don't need an overly complicated test implementation. Hopefully that will help make the .NET approach as easy as possible. On Fri, Sep 22, 2017 at 8:20 AM, Jorge Bay Gondra wrote: > I've been looking int

Re: [DISCUSS] GLV Test Suite

2017-09-22 Thread Jorge Bay Gondra
I've been looking into Gherkin support for .NET: SpecFlow, the cucumber implementation for .NET , does not support .NET Core platform (we use .NET Core build tools for the .NET GLV) and only supports .NET Framework. >From what I can see

[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176291#comment-16176291 ] ASF GitHub Bot commented on TINKERPOP-1731: --- Github user spmallette commente

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/719 yes - you gotta remove the old image ---

[jira] [Commented] (TINKERPOP-1789) Reference elements should be represented by id and label

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176290#comment-16176290 ] ASF GitHub Bot commented on TINKERPOP-1789: --- Github user spmallette commente

[GitHub] tinkerpop pull request #720: TINKERPOP-1789: Reference elements should be re...

2017-09-22 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/720#discussion_r140470761 --- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc --- @@ -95,6 +95,19 @@ In `gremlin-test` there is a new `GraphHelper` class that has a `cl

Re: GraphSON3 collections and subtypes

2017-09-22 Thread Robert Dale
This seems like a special case. If you use valueMap(true), then you do get back . I still don't understand what this really has to do with the GraphSON format and less to do with the GLV API. Shouldn't the GLV API have a typed return? Robert Dale On Fri, Sep 22, 2017 at 6:17 AM, Stephen Mallette

[jira] [Created] (TINKERPOP-1790) GraphSON 3.0 doc updates

2017-09-22 Thread Robert Dale (JIRA)
Robert Dale created TINKERPOP-1790: -- Summary: GraphSON 3.0 doc updates Key: TINKERPOP-1790 URL: https://issues.apache.org/jira/browse/TINKERPOP-1790 Project: TinkerPop Issue Type: Bug

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/719 Recreating `tinkerpop:base`now... ---

[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176275#comment-16176275 ] ASF GitHub Bot commented on TINKERPOP-1731: --- Github user jorgebay commented

[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176266#comment-16176266 ] ASF GitHub Bot commented on TINKERPOP-1731: --- Github user jorgebay commented

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/719 Maybe I have to remove the previous tinkerpop:base image? ---

[jira] [Commented] (TINKERPOP-1789) Reference elements should be represented by id and label

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176263#comment-16176263 ] ASF GitHub Bot commented on TINKERPOP-1789: --- Github user robertdale commente

[GitHub] tinkerpop pull request #720: TINKERPOP-1789: Reference elements should be re...

2017-09-22 Thread robertdale
Github user robertdale commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/720#discussion_r140465221 --- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc --- @@ -95,6 +95,19 @@ In `gremlin-test` there is a new `GraphHelper` class that has a `cl

[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176257#comment-16176257 ] ASF GitHub Bot commented on TINKERPOP-1731: --- Github user jorgebay commented

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/719 I've got a failure on Gremlin Python: ``` [INFO] --- maven-antrun-plugin:1.8:run (setup-py-env) @ gremlin-python --- [WARNING] Parameter tasks is deprecated, use target instead

Re: GraphSON3 collections and subtypes

2017-09-22 Thread Stephen Mallette
I can't quite think of how this might work on the server side where the serialization takes place. You mentioned that maybe: > the graph processor could optimize by returning a specific type of traverser as a result of the execution of a certain traversal (in the example, when the valueMap is the