[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search
[ https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438183#comment-16438183 ] ASF GitHub Bot commented on TINKERPOP-1822: --- Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/838 If I run `mvn clean test` I also get heaps of compilation errors, but that's the same with master for me. E.g. ``` [ERROR] symbol: class JsonGenerator [ERROR] location: class org.apache.tinkerpop.gremlin.structure.io.graphson.TraversalSerializersV3d0.TraversalJacksonSerializer [ERROR] /home/mp/Projects/tinkerpop/tinkerpop3/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/TraversalSerializersV3d0.java:[74,99] cannot find symbol [ERROR] symbol: class SerializerProvider [ERROR] location: class org.apache.tinkerpop.gremlin.structure.io.graphson.TraversalSerializersV3d0.TraversalJacksonSerializer [ERROR] -> [Help 1] ``` Is that the same you're getting @krlohnes? If you just run `mvn clean install` as per http://tinkerpop.apache.org/docs/current/dev/developer/#building-testing it compiles fine (for me) and also runs tests which all pass, but then it stalls at `TinkerGraphProcessComputerTest`. [Travis](https://travis-ci.org/apache/tinkerpop/builds/366306070) reports four failed builds. Two of them time out, no idea what's going on there. The other two fail for a missing integration into .net and JS. Not really my cup of tea... Note: I also had to comment out `false` in `gremlin-core/pom.xml`. No idea what that is, but it runs into a NPE for me. @robertdale how do you normally run the tests, and how can we fix the .net/JS stuff? > Repeat should depth first search > > > Key: TINKERPOP-1822 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1822 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.3.0, 3.2.6 >Reporter: Robert Dale >Priority: Major > > Perhaps optionally. > See also: > * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE > * https://github.com/apache/tinkerpop/pull/715 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/838 If I run `mvn clean test` I also get heaps of compilation errors, but that's the same with master for me. E.g. ``` [ERROR] symbol: class JsonGenerator [ERROR] location: class org.apache.tinkerpop.gremlin.structure.io.graphson.TraversalSerializersV3d0.TraversalJacksonSerializer [ERROR] /home/mp/Projects/tinkerpop/tinkerpop3/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/TraversalSerializersV3d0.java:[74,99] cannot find symbol [ERROR] symbol: class SerializerProvider [ERROR] location: class org.apache.tinkerpop.gremlin.structure.io.graphson.TraversalSerializersV3d0.TraversalJacksonSerializer [ERROR] -> [Help 1] ``` Is that the same you're getting @krlohnes? If you just run `mvn clean install` as per http://tinkerpop.apache.org/docs/current/dev/developer/#building-testing it compiles fine (for me) and also runs tests which all pass, but then it stalls at `TinkerGraphProcessComputerTest`. [Travis](https://travis-ci.org/apache/tinkerpop/builds/366306070) reports four failed builds. Two of them time out, no idea what's going on there. The other two fail for a missing integration into .net and JS. Not really my cup of tea... Note: I also had to comment out `false` in `gremlin-core/pom.xml`. No idea what that is, but it runs into a NPE for me. @robertdale how do you normally run the tests, and how can we fix the .net/JS stuff? ---
[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search
[ https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438167#comment-16438167 ] ASF GitHub Bot commented on TINKERPOP-1822: --- Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/715 superseded by https://github.com/apache/tinkerpop/pull/838 > Repeat should depth first search > > > Key: TINKERPOP-1822 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1822 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.3.0, 3.2.6 >Reporter: Robert Dale >Priority: Major > > Perhaps optionally. > See also: > * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE > * https://github.com/apache/tinkerpop/pull/715 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search
[ https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438168#comment-16438168 ] ASF GitHub Bot commented on TINKERPOP-1822: --- Github user mpollmeier closed the pull request at: https://github.com/apache/tinkerpop/pull/715 > Repeat should depth first search > > > Key: TINKERPOP-1822 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1822 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.3.0, 3.2.6 >Reporter: Robert Dale >Priority: Major > > Perhaps optionally. > See also: > * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE > * https://github.com/apache/tinkerpop/pull/715 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #715: TINKERPOP-1822: change behaviour of repeat step...
Github user mpollmeier closed the pull request at: https://github.com/apache/tinkerpop/pull/715 ---
[GitHub] tinkerpop issue #715: TINKERPOP-1822: change behaviour of repeat step to be ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/715 superseded by https://github.com/apache/tinkerpop/pull/838 ---
[jira] [Closed] (TINKERPOP-1912) Remove MD5 checksums
[ https://issues.apache.org/jira/browse/TINKERPOP-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Kuppitz closed TINKERPOP-1912. - Resolution: Fixed Fix Version/s: 3.3.3 3.2.9 3.4.0 > Remove MD5 checksums > > > Key: TINKERPOP-1912 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1912 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.2.7 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Minor > Fix For: 3.4.0, 3.2.9, 3.3.3 > > > Apache is asking to remove MD5 checksums from releases. > *Old policy:* > * MUST provide a MD5-file > * SHOULD provide a SHA-file [SHA-512 recommended] > *New policy:* > * MUST provide a SHA- or MD5-file > * SHOULD provide a SHA-file > * SHOULD NOT provide a MD5-file > Providing MD5 checksum files is now discouraged for new releases, but still > allowed for past releases. > *Why this change:* > * MD5 is broken for many purposes ; we should move away from it. > [https://en.wikipedia.org/wiki/MD5#Overview_of_security_issues] > *Impact for PMCs:* > * _*for new releases:*_ > ** please do provide a SHA-file (one or more, if you like) > ** do NOT provide a MD5-file -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1912) Remove MD5 checksums
[ https://issues.apache.org/jira/browse/TINKERPOP-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438120#comment-16438120 ] ASF GitHub Bot commented on TINKERPOP-1912: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/837 > Remove MD5 checksums > > > Key: TINKERPOP-1912 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1912 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.2.7 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Minor > > Apache is asking to remove MD5 checksums from releases. > *Old policy:* > * MUST provide a MD5-file > * SHOULD provide a SHA-file [SHA-512 recommended] > *New policy:* > * MUST provide a SHA- or MD5-file > * SHOULD provide a SHA-file > * SHOULD NOT provide a MD5-file > Providing MD5 checksum files is now discouraged for new releases, but still > allowed for past releases. > *Why this change:* > * MD5 is broken for many purposes ; we should move away from it. > [https://en.wikipedia.org/wiki/MD5#Overview_of_security_issues] > *Impact for PMCs:* > * _*for new releases:*_ > ** please do provide a SHA-file (one or more, if you like) > ** do NOT provide a MD5-file -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1912) Remove MD5 checksums
[ https://issues.apache.org/jira/browse/TINKERPOP-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438121#comment-16438121 ] ASF GitHub Bot commented on TINKERPOP-1912: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/836 > Remove MD5 checksums > > > Key: TINKERPOP-1912 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1912 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.2.7 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Minor > > Apache is asking to remove MD5 checksums from releases. > *Old policy:* > * MUST provide a MD5-file > * SHOULD provide a SHA-file [SHA-512 recommended] > *New policy:* > * MUST provide a SHA- or MD5-file > * SHOULD provide a SHA-file > * SHOULD NOT provide a MD5-file > Providing MD5 checksum files is now discouraged for new releases, but still > allowed for past releases. > *Why this change:* > * MD5 is broken for many purposes ; we should move away from it. > [https://en.wikipedia.org/wiki/MD5#Overview_of_security_issues] > *Impact for PMCs:* > * _*for new releases:*_ > ** please do provide a SHA-file (one or more, if you like) > ** do NOT provide a MD5-file -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #836: TINKERPOP-1912 Remove MD5 checksums
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/836 ---
[GitHub] tinkerpop pull request #837: TINKERPOP-1912 Remove MD5 checksums (tp33)
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/837 ---
[GitHub] tinkerpop issue #837: TINKERPOP-1912 Remove MD5 checksums (tp33)
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/837 VOTE +1 ---
[jira] [Commented] (TINKERPOP-1912) Remove MD5 checksums
[ https://issues.apache.org/jira/browse/TINKERPOP-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438116#comment-16438116 ] ASF GitHub Bot commented on TINKERPOP-1912: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/837 VOTE +1 > Remove MD5 checksums > > > Key: TINKERPOP-1912 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1912 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.2.7 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Minor > > Apache is asking to remove MD5 checksums from releases. > *Old policy:* > * MUST provide a MD5-file > * SHOULD provide a SHA-file [SHA-512 recommended] > *New policy:* > * MUST provide a SHA- or MD5-file > * SHOULD provide a SHA-file > * SHOULD NOT provide a MD5-file > Providing MD5 checksum files is now discouraged for new releases, but still > allowed for past releases. > *Why this change:* > * MD5 is broken for many purposes ; we should move away from it. > [https://en.wikipedia.org/wiki/MD5#Overview_of_security_issues] > *Impact for PMCs:* > * _*for new releases:*_ > ** please do provide a SHA-file (one or more, if you like) > ** do NOT provide a MD5-file -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #831: TINKERPOP-1410 Removed test artifact of hadoop-gremlin
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/831 VOTE +1 ---
[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine
[
https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437981#comment-16437981
]
ASF GitHub Bot commented on TINKERPOP-1410:
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/831
VOTE +1
> mvn install -Dmaven.test.skip=true doesn't work on a clean machine
> --
>
> Key: TINKERPOP-1410
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1410
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Minor
> Labels: breaking
> Fix For: 3.4.0
>
>
> {noformat}mvn install -Dmaven.test.skip=true{noformat}
> gives
> {noformat}
> Failed to execute goal on project spark-gremlin: Could not resolve
> dependencies for project
> org.apache.tinkerpop:spark-gremlin:jar:3.2.2-SNAPSHOT: Could not find
> artifact org.apache.tinkerpop:hadoop-gremlin:jar:tests:3.2.2-SNAPSHOT in
> apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
> [ERROR] {noformat}
> The reason for this is that skipping tests also skips creating the test jar
> artefact for hadoop-gremlin.
> https://issues.apache.org/jira/browse/MJAR-138
> Really the prefferred way for creating test jars is to have them as a
> separate project:
> https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.
[ https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437979#comment-16437979 ] ASF GitHub Bot commented on TINKERPOP-1143: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/830 VOTE +1 > Remove deprecated TraversalSource.Builder and TraversalEngine. > -- > > Key: TINKERPOP-1143 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1143 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.2.0-incubating >Reporter: Marko A. Rodriguez >Assignee: stephen mallette >Priority: Minor > Labels: breaking > Fix For: 3.4.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #830: TINKERPOP-1143 Moved TraversalEngine to gremlin-test
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/830 VOTE +1 ---
[jira] [Commented] (TINKERPOP-1903) Credentials DSL should use the Java annotation processor
[ https://issues.apache.org/jira/browse/TINKERPOP-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437978#comment-16437978 ] ASF GitHub Bot commented on TINKERPOP-1903: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/833 VOTE +1 > Credentials DSL should use the Java annotation processor > > > Key: TINKERPOP-1903 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1903 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.2.7 >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Major > Labels: deprecation > Fix For: 3.3.3 > > > This content is a bit outdated - > http://tinkerpop.apache.org/docs/current/reference/#credentials-dsl > uses the old method of DSL development prior to when we established the > annotation processor - need to fix both the code itself and the documentation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #833: TINKERPOP-1903 Migrated Credential DSL to annotation p...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/833 VOTE +1 ---
[GitHub] tinkerpop issue #832: TINKERPOP-1934 Bumped httpclient to 4.5.5
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/832 VOTE +1 ---
[jira] [Commented] (TINKERPOP-1705) Remove deprecated rebindings option
[ https://issues.apache.org/jira/browse/TINKERPOP-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437972#comment-16437972 ] ASF GitHub Bot commented on TINKERPOP-1705: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/835 VOTE +1 > Remove deprecated rebindings option > --- > > Key: TINKERPOP-1705 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1705 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.2.5 >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Major > Labels: breaking > Fix For: 3.4.0 > > > "rebinding" as an argument was deprecated a long time ago in favor of > "aliases". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #835: TINKERPOP-1705 Removed rebindings API from java driver
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/835 VOTE +1 ---
[jira] [Commented] (TINKERPOP-1912) Remove MD5 checksums
[ https://issues.apache.org/jira/browse/TINKERPOP-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437967#comment-16437967 ] ASF GitHub Bot commented on TINKERPOP-1912: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/836 VOTE +1 > Remove MD5 checksums > > > Key: TINKERPOP-1912 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1912 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.2.7 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Minor > > Apache is asking to remove MD5 checksums from releases. > *Old policy:* > * MUST provide a MD5-file > * SHOULD provide a SHA-file [SHA-512 recommended] > *New policy:* > * MUST provide a SHA- or MD5-file > * SHOULD provide a SHA-file > * SHOULD NOT provide a MD5-file > Providing MD5 checksum files is now discouraged for new releases, but still > allowed for past releases. > *Why this change:* > * MD5 is broken for many purposes ; we should move away from it. > [https://en.wikipedia.org/wiki/MD5#Overview_of_security_issues] > *Impact for PMCs:* > * _*for new releases:*_ > ** please do provide a SHA-file (one or more, if you like) > ** do NOT provide a MD5-file -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1934) Bump to latest version of httpclient
[ https://issues.apache.org/jira/browse/TINKERPOP-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437965#comment-16437965 ] ASF GitHub Bot commented on TINKERPOP-1934: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/832 VOTE +1 > Bump to latest version of httpclient > > > Key: TINKERPOP-1934 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1934 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.2.7 >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Major > Fix For: 3.4.0, 3.2.9, 3.3.3 > > > Should probably go to 4.5.5 which will cleanly get us away from: > https://nvd.nist.gov/vuln/detail/CVE-2013-4366 > We seem to reference httpclient in a bunch of places - should probably unify > the version if possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1912) Remove MD5 checksums
[ https://issues.apache.org/jira/browse/TINKERPOP-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437966#comment-16437966 ] ASF GitHub Bot commented on TINKERPOP-1912: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/837 VOTE +1 > Remove MD5 checksums > > > Key: TINKERPOP-1912 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1912 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.2.7 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Minor > > Apache is asking to remove MD5 checksums from releases. > *Old policy:* > * MUST provide a MD5-file > * SHOULD provide a SHA-file [SHA-512 recommended] > *New policy:* > * MUST provide a SHA- or MD5-file > * SHOULD provide a SHA-file > * SHOULD NOT provide a MD5-file > Providing MD5 checksum files is now discouraged for new releases, but still > allowed for past releases. > *Why this change:* > * MD5 is broken for many purposes ; we should move away from it. > [https://en.wikipedia.org/wiki/MD5#Overview_of_security_issues] > *Impact for PMCs:* > * _*for new releases:*_ > ** please do provide a SHA-file (one or more, if you like) > ** do NOT provide a MD5-file -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #837: TINKERPOP-1912 Remove MD5 checksums (tp33)
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/837 VOTE +1 ---
[GitHub] tinkerpop issue #836: TINKERPOP-1912 Remove MD5 checksums
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/836 VOTE +1 ---
[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search
[ https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437962#comment-16437962 ] ASF GitHub Bot commented on TINKERPOP-1822: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/838 Look at the Serializers in `./gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/` > Repeat should depth first search > > > Key: TINKERPOP-1822 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1822 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.3.0, 3.2.6 >Reporter: Robert Dale >Priority: Major > > Perhaps optionally. > See also: > * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE > * https://github.com/apache/tinkerpop/pull/715 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/838 Look at the Serializers in `./gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/` ---
[GitHub] tinkerpop pull request #838: TINKERPOP-1822: Add Depth First Search repeat s...
Github user krlohnes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r181511880
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +314,37 @@ public RepeatEndStep(final Traversal.Admin traversal)
{
super(traversal);
}
+final LinkedList> stashedStarts = new
LinkedList<>();
+
+private Traverser.Admin nextStart(RepeatStep repeatStep) {
+if (repeatStep.searchAlgo.equals(SearchAlgo.BFS)) {
+return this.starts.next();
+} else {
+if (this.starts.hasNext()) {
+return this.starts.next();
+} else {
+return this.stashedStarts.pop();
+}
+}
+}
+
+@Override
+public boolean hasNext() {
+return super.hasNext() || this.stashedStarts.peek() != null;
--- End diff --
Good catch. Fixed that.
---
[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search
[
https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437936#comment-16437936
]
ASF GitHub Bot commented on TINKERPOP-1822:
---
Github user krlohnes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r181511880
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +314,37 @@ public RepeatEndStep(final Traversal.Admin traversal)
{
super(traversal);
}
+final LinkedList> stashedStarts = new
LinkedList<>();
+
+private Traverser.Admin nextStart(RepeatStep repeatStep) {
+if (repeatStep.searchAlgo.equals(SearchAlgo.BFS)) {
+return this.starts.next();
+} else {
+if (this.starts.hasNext()) {
+return this.starts.next();
+} else {
+return this.stashedStarts.pop();
+}
+}
+}
+
+@Override
+public boolean hasNext() {
+return super.hasNext() || this.stashedStarts.peek() != null;
--- End diff --
Good catch. Fixed that.
> Repeat should depth first search
>
>
> Key: TINKERPOP-1822
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1822
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.3.0, 3.2.6
>Reporter: Robert Dale
>Priority: Major
>
> Perhaps optionally.
> See also:
> * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE
> * https://github.com/apache/tinkerpop/pull/715
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/838 I'm definitely still missing something around serialization. All of the traversals that are failing in the gryo side of things work in the console. I'm fairly unfamiliar with that part of the code, but I'll look a bit this weekend if I have some time. If someone more familiar with it sees something obvious I've missed, let me know and I'm happy to add it. ---
[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search
[ https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437935#comment-16437935 ] ASF GitHub Bot commented on TINKERPOP-1822: --- Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/838 I'm definitely still missing something around serialization. All of the traversals that are failing in the gryo side of things work in the console. I'm fairly unfamiliar with that part of the code, but I'll look a bit this weekend if I have some time. If someone more familiar with it sees something obvious I've missed, let me know and I'm happy to add it. > Repeat should depth first search > > > Key: TINKERPOP-1822 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1822 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.3.0, 3.2.6 >Reporter: Robert Dale >Priority: Major > > Perhaps optionally. > See also: > * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE > * https://github.com/apache/tinkerpop/pull/715 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #832: TINKERPOP-1934 Bumped httpclient to 4.5.5
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/832 VOTE: +1 ---
[jira] [Commented] (TINKERPOP-1934) Bump to latest version of httpclient
[ https://issues.apache.org/jira/browse/TINKERPOP-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437838#comment-16437838 ] ASF GitHub Bot commented on TINKERPOP-1934: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/832 VOTE: +1 > Bump to latest version of httpclient > > > Key: TINKERPOP-1934 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1934 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.2.7 >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Major > Fix For: 3.4.0, 3.2.9, 3.3.3 > > > Should probably go to 4.5.5 which will cleanly get us away from: > https://nvd.nist.gov/vuln/detail/CVE-2013-4366 > We seem to reference httpclient in a bunch of places - should probably unify > the version if possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1903) Credentials DSL should use the Java annotation processor
[
https://issues.apache.org/jira/browse/TINKERPOP-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437647#comment-16437647
]
ASF GitHub Bot commented on TINKERPOP-1903:
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/833#discussion_r181456678
--- Diff: docs/src/upgrade/release-3.3.x.asciidoc ---
@@ -23,6 +23,33 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
== TinkerPop 3.3.2
+*Release Date: NOT OFFICIALLY RELEASED YET*
+
+Please see the
link:https://github.com/apache/tinkerpop/blob/3.3.3/CHANGELOG.asciidoc#release-3-3-3[changelog]
for a complete list of all the modifications that are part of this release.
+
+=== Upgrading for Users
+
+ Credential DSL Changes
+
+The Credential DSL has been modified to work as a standard Java-based
Gremlin DSL. The now deprecated old approach
+used a "graph wrapping" style that was developed long before the
+link:http://tinkerpop.apache.org/docs/current/reference/#gremlin-java-dsl[recommended
method] for building DSLs was
+published. Under this new model, the DSL is initialized via traversal as
follows:
+
+[source,java]
+
+CredentialTraversalSource credentials =
graph.traversal(CredentialTraversalSource.class)
+credentials.user("stephen","password").iterate()
+credentials.users("stephen").valueMap().next()
+credentials.users().count().next()
+credentials.user("stephen").drop().iterate()
--- End diff --
```
credentials.users("stephen").drop().iterate()
```
> Credentials DSL should use the Java annotation processor
>
>
> Key: TINKERPOP-1903
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1903
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
> Labels: deprecation
> Fix For: 3.3.3
>
>
> This content is a bit outdated -
> http://tinkerpop.apache.org/docs/current/reference/#credentials-dsl
> uses the old method of DSL development prior to when we established the
> annotation processor - need to fix both the code itself and the documentation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1903) Credentials DSL should use the Java annotation processor
[
https://issues.apache.org/jira/browse/TINKERPOP-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437645#comment-16437645
]
ASF GitHub Bot commented on TINKERPOP-1903:
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/833#discussion_r181456003
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -1365,15 +1365,22 @@ Please see the example usage as follows:
graph = TinkerGraph.open()
graph.createIndex("username",Vertex.class)
-credentials = credentials(graph)
-credentials.createUser("stephen","password")
-credentials.createUser("daniel","better-password")
-credentials.createUser("marko","rainbow-dash")
-credentials.findUser("marko").properties()
-credentials.countUsers()
-credentials.removeUser("daniel")
-credentials.countUsers()
-
+credentials = graph.traversal(CredentialTraversalSource.class)
+credentials.user("stephen","password")
+credentials.user("daniel","better-password")
+credentials.user("marko","rainbow-dash")
+credentials.users("marko").valueMap()
+credentials.users().count()
+credentials.user("daniel").drop()
--- End diff --
Ignoring that simply dropping my user account is probably not in line with
the current GDPR, this should be `credentials.users("daniel").drop()`.
> Credentials DSL should use the Java annotation processor
>
>
> Key: TINKERPOP-1903
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1903
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
> Labels: deprecation
> Fix For: 3.3.3
>
>
> This content is a bit outdated -
> http://tinkerpop.apache.org/docs/current/reference/#credentials-dsl
> uses the old method of DSL development prior to when we established the
> annotation processor - need to fix both the code itself and the documentation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1903) Credentials DSL should use the Java annotation processor
[
https://issues.apache.org/jira/browse/TINKERPOP-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437646#comment-16437646
]
ASF GitHub Bot commented on TINKERPOP-1903:
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/833#discussion_r181460071
--- Diff:
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/dsl/credential/CredentialTraversalDsl.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.groovy.jsr223.dsl.credential;
+
+import org.apache.tinkerpop.gremlin.process.traversal.dsl.GremlinDsl;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal;
+import org.apache.tinkerpop.gremlin.structure.Vertex;
+import org.mindrot.jbcrypt.BCrypt;
+
+import static
org.apache.tinkerpop.gremlin.groovy.jsr223.dsl.credential.CredentialGraphTokens.PROPERTY_PASSWORD;
+import static
org.apache.tinkerpop.gremlin.groovy.jsr223.dsl.credential.CredentialGraphTokens.PROPERTY_USERNAME;
+import static
org.apache.tinkerpop.gremlin.groovy.jsr223.dsl.credential.CredentialGraphTokens.VERTEX_LABEL_USER;
+
+/**
+ * A DSL for managing a "credentials graph" used by Gremlin Server for
simple authentication functions.
+ *
+ * @author Stephen Mallette (http://stephen.genoprime.com)
+ */
+@GremlinDsl(traversalSource =
"org.apache.tinkerpop.gremlin.groovy.jsr223.dsl.credential.CredentialTraversalSourceDsl")
+public interface CredentialTraversalDsl extends
GraphTraversal.Admin {
+static final int BCRYPT_ROUNDS = 4;
+
+/**
+ * Finds all users.
+ */
+public default GraphTraversal users() {
+return (CredentialTraversal)
hasLabel(VERTEX_LABEL_USER);
+}
+
+/**
+ * Finds users by name.
+ */
+public default GraphTraversal users(final String username) {
--- End diff --
Since this method is called `users` and not `user`, it should look more
like this:
```java
public GraphTraversal users(final String username,
final String... more) {
if (more.length == 0) {
return this.clone().V().has(VERTEX_LABEL_USER,
PROPERTY_USERNAME, username);
}
final int lastIndex;
final String[] usernames = Arrays.copyOf(more, (lastIndex =
more.length) + 1);
usernames[lastIndex] = username;
return this.clone().V().has(VERTEX_LABEL_USER, PROPERTY_USERNAME,
P.within(usernames));
}
```
Likewise in `CredentialTraversalSourceDsl`.
> Credentials DSL should use the Java annotation processor
>
>
> Key: TINKERPOP-1903
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1903
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
> Labels: deprecation
> Fix For: 3.3.3
>
>
> This content is a bit outdated -
> http://tinkerpop.apache.org/docs/current/reference/#credentials-dsl
> uses the old method of DSL development prior to when we established the
> annotation processor - need to fix both the code itself and the documentation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #833: TINKERPOP-1903 Migrated Credential DSL to annot...
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/833#discussion_r181460071
--- Diff:
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/dsl/credential/CredentialTraversalDsl.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.groovy.jsr223.dsl.credential;
+
+import org.apache.tinkerpop.gremlin.process.traversal.dsl.GremlinDsl;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal;
+import org.apache.tinkerpop.gremlin.structure.Vertex;
+import org.mindrot.jbcrypt.BCrypt;
+
+import static
org.apache.tinkerpop.gremlin.groovy.jsr223.dsl.credential.CredentialGraphTokens.PROPERTY_PASSWORD;
+import static
org.apache.tinkerpop.gremlin.groovy.jsr223.dsl.credential.CredentialGraphTokens.PROPERTY_USERNAME;
+import static
org.apache.tinkerpop.gremlin.groovy.jsr223.dsl.credential.CredentialGraphTokens.VERTEX_LABEL_USER;
+
+/**
+ * A DSL for managing a "credentials graph" used by Gremlin Server for
simple authentication functions.
+ *
+ * @author Stephen Mallette (http://stephen.genoprime.com)
+ */
+@GremlinDsl(traversalSource =
"org.apache.tinkerpop.gremlin.groovy.jsr223.dsl.credential.CredentialTraversalSourceDsl")
+public interface CredentialTraversalDsl extends
GraphTraversal.Admin {
+static final int BCRYPT_ROUNDS = 4;
+
+/**
+ * Finds all users.
+ */
+public default GraphTraversal users() {
+return (CredentialTraversal)
hasLabel(VERTEX_LABEL_USER);
+}
+
+/**
+ * Finds users by name.
+ */
+public default GraphTraversal users(final String username) {
--- End diff --
Since this method is called `users` and not `user`, it should look more
like this:
```java
public GraphTraversal users(final String username,
final String... more) {
if (more.length == 0) {
return this.clone().V().has(VERTEX_LABEL_USER,
PROPERTY_USERNAME, username);
}
final int lastIndex;
final String[] usernames = Arrays.copyOf(more, (lastIndex =
more.length) + 1);
usernames[lastIndex] = username;
return this.clone().V().has(VERTEX_LABEL_USER, PROPERTY_USERNAME,
P.within(usernames));
}
```
Likewise in `CredentialTraversalSourceDsl`.
---
[GitHub] tinkerpop pull request #833: TINKERPOP-1903 Migrated Credential DSL to annot...
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/833#discussion_r181456003
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -1365,15 +1365,22 @@ Please see the example usage as follows:
graph = TinkerGraph.open()
graph.createIndex("username",Vertex.class)
-credentials = credentials(graph)
-credentials.createUser("stephen","password")
-credentials.createUser("daniel","better-password")
-credentials.createUser("marko","rainbow-dash")
-credentials.findUser("marko").properties()
-credentials.countUsers()
-credentials.removeUser("daniel")
-credentials.countUsers()
-
+credentials = graph.traversal(CredentialTraversalSource.class)
+credentials.user("stephen","password")
+credentials.user("daniel","better-password")
+credentials.user("marko","rainbow-dash")
+credentials.users("marko").valueMap()
+credentials.users().count()
+credentials.user("daniel").drop()
--- End diff --
Ignoring that simply dropping my user account is probably not in line with
the current GDPR, this should be `credentials.users("daniel").drop()`.
---
[GitHub] tinkerpop pull request #833: TINKERPOP-1903 Migrated Credential DSL to annot...
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/833#discussion_r181456678
--- Diff: docs/src/upgrade/release-3.3.x.asciidoc ---
@@ -23,6 +23,33 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
== TinkerPop 3.3.2
+*Release Date: NOT OFFICIALLY RELEASED YET*
+
+Please see the
link:https://github.com/apache/tinkerpop/blob/3.3.3/CHANGELOG.asciidoc#release-3-3-3[changelog]
for a complete list of all the modifications that are part of this release.
+
+=== Upgrading for Users
+
+ Credential DSL Changes
+
+The Credential DSL has been modified to work as a standard Java-based
Gremlin DSL. The now deprecated old approach
+used a "graph wrapping" style that was developed long before the
+link:http://tinkerpop.apache.org/docs/current/reference/#gremlin-java-dsl[recommended
method] for building DSLs was
+published. Under this new model, the DSL is initialized via traversal as
follows:
+
+[source,java]
+
+CredentialTraversalSource credentials =
graph.traversal(CredentialTraversalSource.class)
+credentials.user("stephen","password").iterate()
+credentials.users("stephen").valueMap().next()
+credentials.users().count().next()
+credentials.user("stephen").drop().iterate()
--- End diff --
```
credentials.users("stephen").drop().iterate()
```
---
[jira] [Created] (TINKERPOP-1937) Pass bytecode through ScriptEngine if Bindings are present
stephen mallette created TINKERPOP-1937:
---
Summary: Pass bytecode through ScriptEngine if Bindings are present
Key: TINKERPOP-1937
URL: https://issues.apache.org/jira/browse/TINKERPOP-1937
Project: TinkerPop
Issue Type: Improvement
Components: server
Affects Versions: 3.2.8
Reporter: stephen mallette
Assignee: stephen mallette
Fix For: 3.4.0, 3.2.9, 3.3.3
We currently only pass bytecode through the {{ScriptEngine}} if it has a
lambda, but it seems to make sense to do the same with bytecode that has
{{Bindings}} as then caching will kick in and there should be a performance
improvement when using parameters just as we get with scripts.
I've looked into ways to get the {{JavaTranslator}} to optimize based on
{{Bindings}} but I think we've coded ourselves into a corner with there insofar
as trying to make this enhancement without breaking changes. 3.4.0 might be the
first chance to make fixes in this regard.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #835: TINKERPOP-1705 Removed rebindings API from java driver
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/835 VOTE: +1 ---
[jira] [Commented] (TINKERPOP-1705) Remove deprecated rebindings option
[ https://issues.apache.org/jira/browse/TINKERPOP-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437521#comment-16437521 ] ASF GitHub Bot commented on TINKERPOP-1705: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/835 VOTE: +1 > Remove deprecated rebindings option > --- > > Key: TINKERPOP-1705 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1705 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.2.5 >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Major > Labels: breaking > Fix For: 3.4.0 > > > "rebinding" as an argument was deprecated a long time ago in favor of > "aliases". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search
[
https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437370#comment-16437370
]
ASF GitHub Bot commented on TINKERPOP-1822:
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r181408164
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +314,37 @@ public RepeatEndStep(final Traversal.Admin traversal)
{
super(traversal);
}
+final LinkedList> stashedStarts = new
LinkedList<>();
+
+private Traverser.Admin nextStart(RepeatStep repeatStep) {
+if (repeatStep.searchAlgo.equals(SearchAlgo.BFS)) {
+return this.starts.next();
+} else {
+if (this.starts.hasNext()) {
+return this.starts.next();
+} else {
+return this.stashedStarts.pop();
+}
+}
+}
+
+@Override
+public boolean hasNext() {
+return super.hasNext() || this.stashedStarts.peek() != null;
--- End diff --
`this.stashedStarts.peek() != null` would be equivalent to
`!this.stashedStarts.isEmpty()`, no?
> Repeat should depth first search
>
>
> Key: TINKERPOP-1822
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1822
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.3.0, 3.2.6
>Reporter: Robert Dale
>Priority: Major
>
> Perhaps optionally.
> See also:
> * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE
> * https://github.com/apache/tinkerpop/pull/715
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #838: TINKERPOP-1822: Add Depth First Search repeat s...
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r181408164
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +314,37 @@ public RepeatEndStep(final Traversal.Admin traversal)
{
super(traversal);
}
+final LinkedList> stashedStarts = new
LinkedList<>();
+
+private Traverser.Admin nextStart(RepeatStep repeatStep) {
+if (repeatStep.searchAlgo.equals(SearchAlgo.BFS)) {
+return this.starts.next();
+} else {
+if (this.starts.hasNext()) {
+return this.starts.next();
+} else {
+return this.stashedStarts.pop();
+}
+}
+}
+
+@Override
+public boolean hasNext() {
+return super.hasNext() || this.stashedStarts.peek() != null;
--- End diff --
`this.stashedStarts.peek() != null` would be equivalent to
`!this.stashedStarts.isEmpty()`, no?
---
[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search
[ https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437364#comment-16437364 ] ASF GitHub Bot commented on TINKERPOP-1822: --- Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/838 I figured out the errors that I was getting with serialization. I think I just missed registering `SearchAlgo` in a spots. I have some legitimate test failures now I think, which makes fixing things quite a bit easier, I can take a swing at those over the weekend. @mpollmeier I do like the test you're suggesting, I was trying to come up with a test case for an existing dataset in the test infrastructure to make sure things worked there for now. I think testing on a k-ary tree might be worth while too. A lot of bugs I found when I was testing the general idea were found in that case. As far as making DFS the default, my only concern would be breaking existing traversals. I don't know if there are traversals out there that depend on `repeat` being BFS that would need to be fixed with a change for the default. I'd think there would be a desire to not change that behavior default until the next minor version bump. I'd want to give users a bit of time to know this exists, and make the switch after there's some awareness of the option to toggle between the two. > Repeat should depth first search > > > Key: TINKERPOP-1822 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1822 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.3.0, 3.2.6 >Reporter: Robert Dale >Priority: Major > > Perhaps optionally. > See also: > * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE > * https://github.com/apache/tinkerpop/pull/715 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/838 I figured out the errors that I was getting with serialization. I think I just missed registering `SearchAlgo` in a spots. I have some legitimate test failures now I think, which makes fixing things quite a bit easier, I can take a swing at those over the weekend. @mpollmeier I do like the test you're suggesting, I was trying to come up with a test case for an existing dataset in the test infrastructure to make sure things worked there for now. I think testing on a k-ary tree might be worth while too. A lot of bugs I found when I was testing the general idea were found in that case. As far as making DFS the default, my only concern would be breaking existing traversals. I don't know if there are traversals out there that depend on `repeat` being BFS that would need to be fixed with a change for the default. I'd think there would be a desire to not change that behavior default until the next minor version bump. I'd want to give users a bit of time to know this exists, and make the switch after there's some awareness of the option to toggle between the two. ---
[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search
[
https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437349#comment-16437349
]
ASF GitHub Bot commented on TINKERPOP-1822:
---
Github user krlohnes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r181402263
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +314,37 @@ public RepeatEndStep(final Traversal.Admin traversal)
{
super(traversal);
}
+final LinkedList> stashedStarts = new
LinkedList<>();
+
+private Traverser.Admin nextStart(RepeatStep repeatStep) {
+if (repeatStep.searchAlgo.equals(SearchAlgo.BFS)) {
+return this.starts.next();
+} else {
+if (this.starts.hasNext()) {
+return this.starts.next();
+} else {
+return this.stashedStarts.pop();
+}
+}
+}
+
+@Override
+public boolean hasNext() {
+return super.hasNext() || this.stashedStarts.peek() != null;
--- End diff --
Fixed
> Repeat should depth first search
>
>
> Key: TINKERPOP-1822
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1822
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.3.0, 3.2.6
>Reporter: Robert Dale
>Priority: Major
>
> Perhaps optionally.
> See also:
> * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE
> * https://github.com/apache/tinkerpop/pull/715
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search
[
https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437348#comment-16437348
]
ASF GitHub Bot commented on TINKERPOP-1822:
---
Github user krlohnes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r181402232
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java
---
@@ -496,6 +497,19 @@
return this.asAdmin().addStep(scope.equals(Scope.global) ? new
OrderGlobalStep<>(this.asAdmin()) : new OrderLocalStep<>(this.asAdmin()));
}
+/**
+ * Order the repeat step by depth first or breadth first
+ *
+ * @param algo either DFS or BFS
+ *
+ * @see http://tinkerpop.apache.org/docs/${project.version}/reference/#order-step";
target="_blank">Reference Documentation - Order Step
+ * @since 3.0.0-incubating
--- End diff --
Fixed
> Repeat should depth first search
>
>
> Key: TINKERPOP-1822
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1822
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.3.0, 3.2.6
>Reporter: Robert Dale
>Priority: Major
>
> Perhaps optionally.
> See also:
> * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE
> * https://github.com/apache/tinkerpop/pull/715
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #838: TINKERPOP-1822: Add Depth First Search repeat s...
Github user krlohnes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r181402263
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +314,37 @@ public RepeatEndStep(final Traversal.Admin traversal)
{
super(traversal);
}
+final LinkedList> stashedStarts = new
LinkedList<>();
+
+private Traverser.Admin nextStart(RepeatStep repeatStep) {
+if (repeatStep.searchAlgo.equals(SearchAlgo.BFS)) {
+return this.starts.next();
+} else {
+if (this.starts.hasNext()) {
+return this.starts.next();
+} else {
+return this.stashedStarts.pop();
+}
+}
+}
+
+@Override
+public boolean hasNext() {
+return super.hasNext() || this.stashedStarts.peek() != null;
--- End diff --
Fixed
---
[GitHub] tinkerpop pull request #838: TINKERPOP-1822: Add Depth First Search repeat s...
Github user krlohnes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r181402232
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java
---
@@ -496,6 +497,19 @@
return this.asAdmin().addStep(scope.equals(Scope.global) ? new
OrderGlobalStep<>(this.asAdmin()) : new OrderLocalStep<>(this.asAdmin()));
}
+/**
+ * Order the repeat step by depth first or breadth first
+ *
+ * @param algo either DFS or BFS
+ *
+ * @see http://tinkerpop.apache.org/docs/${project.version}/reference/#order-step";
target="_blank">Reference Documentation - Order Step
+ * @since 3.0.0-incubating
--- End diff --
Fixed
---
