[jira] [Commented] (TINKERPOP-1987) Bump to Netty 4.1.x
[ https://issues.apache.org/jira/browse/TINKERPOP-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547062#comment-16547062 ] ASF GitHub Bot commented on TINKERPOP-1987: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/886 > Bump to Netty 4.1.x > --- > > Key: TINKERPOP-1987 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1987 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.4.0 >Reporter: Robert Dale >Assignee: stephen mallette >Priority: Major > Fix For: 3.4.0 > > > Netty 4.0.x is EOL: > https://twitter.com/normanmaurer/status/960798363695435778 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (TINKERPOP-1993) Bump to Spark 2.3.1
[ https://issues.apache.org/jira/browse/TINKERPOP-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1993. --- Resolution: Done > Bump to Spark 2.3.1 > --- > > Key: TINKERPOP-1993 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1993 > Project: TinkerPop > Issue Type: Improvement > Components: hadoop >Affects Versions: 3.3.3 >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Major > Fix For: 3.4.0 > > > Since we want to bump to Netty 4.1.x on TINKERPOP-1987 we have to go to Spark > 2.3.x. Spark 3.1.x is bound to netty 4.0.x and the upgrade doesn't work > without it. Previous attempts were made at pom.xml exclusion tactics and none > seemed to get things to compile right. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (TINKERPOP-1987) Bump to Netty 4.1.x
[ https://issues.apache.org/jira/browse/TINKERPOP-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1987. --- Resolution: Done Fix Version/s: 3.4.0 > Bump to Netty 4.1.x > --- > > Key: TINKERPOP-1987 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1987 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.4.0 >Reporter: Robert Dale >Assignee: stephen mallette >Priority: Major > Fix For: 3.4.0 > > > Netty 4.0.x is EOL: > https://twitter.com/normanmaurer/status/960798363695435778 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #886: TINKERPOP-1987 Bump to Spark 2.3.1 and Netty 4....
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/886 ---
[GitHub] tinkerpop issue #889: Tinkerpop 1977 - Sasl Authentication
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/889 @mattallenuk if there are errors you can share from your build, i might be able to direct you further. ---
[jira] [Closed] (TINKERPOP-1864) Gremlin Python tests for GraphSON 2.0 and 3.0
[ https://issues.apache.org/jira/browse/TINKERPOP-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1864. --- Resolution: Done Assignee: stephen mallette Fix Version/s: 3.3.4 3.4.0 > Gremlin Python tests for GraphSON 2.0 and 3.0 > - > > Key: TINKERPOP-1864 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1864 > Project: TinkerPop > Issue Type: Improvement > Components: python >Affects Versions: 3.3.1 >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Minor > Fix For: 3.4.0, 3.3.4 > > > With TINKERPOP-1844 gremlin-python tests no longer run against GraphSON 2.0. > They only run against 3.0. It would be good to include runs against 2.0 as > well - that will come with some challenges because there are tests that > simply can't run against 2.0 given its limitations. To some degree, we do get > some confidence that 2.0 still works as the 3.2.x tests still run 2.0 and > will continue to do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #890: Expose Pick in module.exports
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/890 VOTE +1 ---
[jira] [Commented] (TINKERPOP-1864) Gremlin Python tests for GraphSON 2.0 and 3.0
[ https://issues.apache.org/jira/browse/TINKERPOP-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546926#comment-16546926 ] ASF GitHub Bot commented on TINKERPOP-1864: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/883 > Gremlin Python tests for GraphSON 2.0 and 3.0 > - > > Key: TINKERPOP-1864 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1864 > Project: TinkerPop > Issue Type: Improvement > Components: python >Affects Versions: 3.3.1 >Reporter: stephen mallette >Priority: Minor > Fix For: 3.4.0, 3.3.4 > > > With TINKERPOP-1844 gremlin-python tests no longer run against GraphSON 2.0. > They only run against 3.0. It would be good to include runs against 2.0 as > well - that will come with some challenges because there are tests that > simply can't run against 2.0 given its limitations. To some degree, we do get > some confidence that 2.0 still works as the 3.2.x tests still run 2.0 and > will continue to do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #883: TINKERPOP-1864 Run python glv tests on GraphSON...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/883 ---
[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures
[
https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546905#comment-16546905
]
ASF GitHub Bot commented on TINKERPOP-967:
--
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/876
> Support nested-repeat() structures
> --
>
> Key: TINKERPOP-967
> URL: https://issues.apache.org/jira/browse/TINKERPOP-967
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.1.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
>Priority: Major
>
> All the internal plumbing is staged for this to happen, we just haven't gone
> all the way. In short, a {{NESTED_LOOP}} traverser has an internal
> {{loopStack}} where {{repeat(repeat())}} will have a {{loopStack}} of two.
> The {{it.loops()}} checks of the internal repeat will always check the top of
> the stack and when its done repeating will delete its counter off the top of
> the stack.
> [~dkuppitz]'s work on {{LoopStep}} will be backwards compatible. In
> {{RepeatStep}} we will support:
> {code}
> repeat('a',out('knows').repeat('b',out('parent')))
> {code}
> and thus, things like {{loops('a')}} as well as {{times('a',2)}}. Note that
> naming the loop stack will be a super rare case as most people will just
> assume standard nested looping semantics with a push/pop stack.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/876 ---
[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures
[
https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546749#comment-16546749
]
ASF GitHub Bot commented on TINKERPOP-967:
--
Github user GCHQResearcher1337 commented on the issue:
https://github.com/apache/tinkerpop/pull/876
@spmallette Yep. Awesome - thanks for all your input + reviews!
> Support nested-repeat() structures
> --
>
> Key: TINKERPOP-967
> URL: https://issues.apache.org/jira/browse/TINKERPOP-967
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.1.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
>Priority: Major
>
> All the internal plumbing is staged for this to happen, we just haven't gone
> all the way. In short, a {{NESTED_LOOP}} traverser has an internal
> {{loopStack}} where {{repeat(repeat())}} will have a {{loopStack}} of two.
> The {{it.loops()}} checks of the internal repeat will always check the top of
> the stack and when its done repeating will delete its counter off the top of
> the stack.
> [~dkuppitz]'s work on {{LoopStep}} will be backwards compatible. In
> {{RepeatStep}} we will support:
> {code}
> repeat('a',out('knows').repeat('b',out('parent')))
> {code}
> and thus, things like {{loops('a')}} as well as {{times('a',2)}}. Note that
> naming the loop stack will be a super rare case as most people will just
> assume standard nested looping semantics with a push/pop stack.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #876: TINKERPOP-967 Support nested-repeat() structures
Github user GCHQResearcher1337 commented on the issue: https://github.com/apache/tinkerpop/pull/876 @spmallette Yep. Awesome - thanks for all your input + reviews! ---
[jira] [Updated] (TINKERPOP-2007) GraphML serialization shall by default be ordered and have an improved ordering
[ https://issues.apache.org/jira/browse/TINKERPOP-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-2007: Component/s: io > GraphML serialization shall by default be ordered and have an improved > ordering > --- > > Key: TINKERPOP-2007 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2007 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.3.3 >Reporter: Svante Schubert >Priority: Minor > > To ease readability and regression tests based on GraphML files (especially > used for loading Graphs into Gephi) I suggest to > a) order (or normalize) the GraphML by default (e.g. from Gremlin console) > b) improve the ordering if numbers are involved, oppose to String only: > Currently, in the reference test file for normalized GraphML > ["tinkerpop-classic-normalized.xml"|https://github.com/apache/tinkerpop/blob/master/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/structure/io/graphml/tinkerpop-classic-normalized.xml], > the ordering of edge IDs goes like > 10 > 11 > 12 > 7 > 8 > 9 > instead of > 7 > 8 > 9 > 10 > 11 > 12 > It goes even jumpier if hundred or thousand of edges are involved. > > I am going to provide a GitHub pull request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (TINKERPOP-2006) GraphML serialization invalid if a vertex and edge have similar named property
[ https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-2006: Component/s: io > GraphML serialization invalid if a vertex and edge have similar named property > -- > > Key: TINKERPOP-2006 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2006 > Project: TinkerPop > Issue Type: Bug > Components: io >Affects Versions: 3.3.3 >Reporter: Svante Schubert >Priority: Trivial > > I have created a graph using the Tinkerpop Graph and required for Gephi > visualization a property called color on edges and vertices to be coloured. > The current gremlin-core serialization creates the following two key elements > in GraphML > > > the id attribute is an internal name, but have to be different. > I would suggest a patch to check for an intersection of the edge & vertices > keys and add for those keys an additional differentiating letter like: > > > > Going to provide a pullrequest on GitHub. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (TINKERPOP-2008) GraphML import / export causing duplicated edge IDs
[
https://issues.apache.org/jira/browse/TINKERPOP-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette updated TINKERPOP-2008:
Component/s: io
> GraphML import / export causing duplicated edge IDs
> ---
>
> Key: TINKERPOP-2008
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2008
> Project: TinkerPop
> Issue Type: Bug
> Components: io
>Affects Versions: 3.3.3
>Reporter: Svante Schubert
>Priority: Major
> Attachments: input_table_table.graphml, input_table_table.kryo,
> output__in_table-table_graphml.graphml, output__in_table-table_kyro.graphml
>
>
> I could only reproduce the problem of duplicated IDs in the graph output
> after a query on the Gremlin console if it was a larger/complex input file
> and only if both GraphML import and export were being used.
> If I loaded the file as identical Gryo file the export was without
> duplication.
> I assume there are some thresholds/memory dumps where you might compare the
> RTM.
> There 7 edges with duplicate IDs in the following lines of the attached file
> 'output__in_table-table_graphml.graphml'
> Line 736: Duplicate unique value [370] declared for identity constraint
> "edge_id_unique" of element "graph".
> Line 758: Duplicate unique value [374] declared for identity constraint
> "edge_id_unique" of element "graph".
> Line 783: Duplicate unique value [378] declared for identity constraint
> "edge_id_unique" of element "graph".
> Line 797: Duplicate unique value [382] declared for identity constraint
> "edge_id_unique" of element "graph".
> Line 818: Duplicate unique value [386] declared for identity constraint
> "edge_id_unique" of element "graph".
> Line 854: Duplicate unique value [390] declared for identity constraint
> "edge_id_unique" of element "graph".
> Line 887: Duplicate unique value [400] declared for identity constraint
> "edge_id_unique" of element "graph".
> In addition, the problem is related to the query. If I load and save the
> Graph immediately no edge problem occurs.
> See mail thread:
> https://groups.google.com/forum/#!searchin/gremlin-users/svante%7Csort:date/gremlin-users/P8MdzzlFtng/vYqYlukJAgAJ
> {quote}\,,,/
> (o o)
> -oOOo-(3)-oOOo-
> plugin activated: tinkerpop.server
> plugin activated: tinkerpop.utilities
> plugin activated: tinkerpop.tinkergraph
> gremlin> graph = TinkerGraph.open()
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> graph.io(IoCore.graphml()).readGraph("f:" + File.separator + "tmp" +
> File.separator + "table_table.graphml");
> ==>null
> gremlin> g = graph.traversal()
> ==>graphtraversalsource[tinkergraph[vertices:184 edges:183], standard]
> gremlin> g.V().has('label', "EPSILON").as('epsilonV').inE().as('e1').outV().
> ..1> where(__.outE().count().is(eq(2))).as('choiceV').
> ..2> outE().where(neq('e1')).as('e2').inV().as('optionalV').
> ..3> select('choiceV').inE().as('srcE').outV().as('srcV').
> ..4> addE('optional').to('optionalV').as('newE').
> ..5> sideEffect(select('srcE').properties().unfold().as('p').
> ..6> select('newE').property(select('p').key(), select('p').value())).
> ..7> union(select('srcE').drop(),
> ..8> select('e1').drop(),
> ..9> select('e2').drop(),
> .10> select('epsilonV').drop(),
> .11> select('choiceV').drop())
> gremlin> graph.io(IoCore.graphml()).writeGraph("f:" + File.separator + "tmp"
> + File.separator + "output__in_table-table_graphml.graphml");
> ==>null
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (TINKERPOP-2011) Use NumberHelper on choose()
stephen mallette created TINKERPOP-2011:
---
Summary: Use NumberHelper on choose()
Key: TINKERPOP-2011
URL: https://issues.apache.org/jira/browse/TINKERPOP-2011
Project: TinkerPop
Issue Type: Improvement
Components: process
Affects Versions: 3.2.9
Reporter: stephen mallette
Assignee: Daniel Kuppitz
The {{choose()} step could use {{NumberHelper}} to make this easier:
{code}
gremlin> g.V(1).choose(values('b')).option(b,
constant(true)).option(none,constant(false))
==>true
gremlin> g.V(1).choose(values('b')).option(1,
constant(true)).option(none,constant(false))
==>false
gremlin> g.V(1).choose(values('b')).option(1 as byte,
constant(true)).option(none,constant(false))
==>true
{code}
as discussed here:
https://groups.google.com/d/msg/gremlin-users/4pjH7AOM72s/ohIEdABfBQAJ
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (TINKERPOP-2010) Generate jsdoc for gremlin-javascript
stephen mallette created TINKERPOP-2010:
---
Summary: Generate jsdoc for gremlin-javascript
Key: TINKERPOP-2010
URL: https://issues.apache.org/jira/browse/TINKERPOP-2010
Project: TinkerPop
Issue Type: Improvement
Components: build-release, documentation, javascript
Affects Versions: 3.2.9
Reporter: stephen mallette
Assignee: Jorge Bay
Fix For: 3.4.0, 3.3.4, 3.2.10
There are two parts to this...first we need to automate jsdoc generation with
maven and then second we need to take that output and publish it as part of
{{bin/publish-docs.sh}}. Perhaps [~jorgebg] can handle the first part and
[~dkuppitz] can look into the second part?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (TINKERPOP-1365) Log the seed used to initialize Random in tests
[
https://issues.apache.org/jira/browse/TINKERPOP-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1365.
---
Resolution: Done
Assignee: stephen mallette
Fix Version/s: 3.2.10
3.3.4
3.4.0
> Log the seed used to initialize Random in tests
> ---
>
> Key: TINKERPOP-1365
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1365
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
>Affects Versions: 3.2.0-incubating, 3.1.2-incubating
>Reporter: Jason Plurad
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> {{HadoopGraphProvider}} and {{SparkHadoopGraphProvider}} use
> {{RANDOM.nextBoolean()}} in an attempt to get coverage over different load
> scenarios. In practice, this ends up causing nondeterministic execution of
> the test suite, which can mask real errors lingering in the code or test code.
> See TINKERPOP-1360
> Logging the seed used for these tests will allow us to re-run the test in the
> same way on failure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #881: TINKERPOP-1365 Refactored use of Random in test...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/881 ---
[jira] [Commented] (TINKERPOP-1365) Log the seed used to initialize Random in tests
[
https://issues.apache.org/jira/browse/TINKERPOP-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546300#comment-16546300
]
ASF GitHub Bot commented on TINKERPOP-1365:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/881
> Log the seed used to initialize Random in tests
> ---
>
> Key: TINKERPOP-1365
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1365
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
>Affects Versions: 3.2.0-incubating, 3.1.2-incubating
>Reporter: Jason Plurad
>Priority: Major
>
> {{HadoopGraphProvider}} and {{SparkHadoopGraphProvider}} use
> {{RANDOM.nextBoolean()}} in an attempt to get coverage over different load
> scenarios. In practice, this ends up causing nondeterministic execution of
> the test suite, which can mask real errors lingering in the code or test code.
> See TINKERPOP-1360
> Logging the seed used for these tests will allow us to re-run the test in the
> same way on failure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #890: Expose Pick in module.exports
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/890 `Pick` is covered by the cucumber tests and those features are passing: https://github.com/apache/tinkerpop/blob/master/gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js#L190 The problem is that we weren't exporting `pick` enum for users to access it. ---
