[GitHub] incubator-tinkerpop issue #329: use mockito-core instead of mockito-all to a...

2016-06-03 Thread okram
Github user okram commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/329 Do integration tests pass? ... that will be all I care about. @spmallette will have deeper thoughts on the matter as he uses Mockito. --- If your project is set up for it, you can reply

[GitHub] incubator-tinkerpop issue #325: TINKERPOP-1321 Introduce Kryo shim to suppor...

2016-06-03 Thread okram
Github user okram commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/325 @dalaro -- what about it doesn't work? Meaning, is your problem just a "unregistered class" issue? If so, we just register it. If I have a "bad" serializer for o

[GitHub] incubator-tinkerpop issue #325: TINKERPOP-1321 Introduce Kryo shim to suppor...

2016-06-03 Thread okram
Github user okram commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/325 So yea... sorta feels like we are where we were before in a way. And yea, all that Input, Output, Kryo stuff is what causes all the problems. So now I'm wondering, why not just

[GitHub] incubator-tinkerpop issue #325: TINKERPOP-1321 Introduce Kryo shim to suppor...

2016-06-07 Thread okram
Github user okram commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/325 ``` [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop ... SUCCESS [ 9.619 s] [INFO] Apache TinkerPop :: Gremlin Shaded

[GitHub] incubator-tinkerpop issue #325: TINKERPOP-1321 Introduce Kryo shim to suppor...

2016-06-06 Thread okram
Github user okram commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/325 Testing this morning, I get two test failures. ``` Tests in error: GroovyProgramTest$Traversals

[GitHub] incubator-tinkerpop issue #325: TINKERPOP-1321 Introduce Kryo shim to suppor...

2016-06-06 Thread okram
Github user okram commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/325 Okay. So 1 and 2 above are done, however, I had to `OPT_OUT` of `TraversalInterruptionComputerTest` as for some reason, the `GryoPoolKryoShimService` is not respecting interruption

[GitHub] incubator-tinkerpop issue #325: TINKERPOP-1321 Introduce Kryo shim to suppor...

2016-06-06 Thread okram
Github user okram commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/325 So, `mvn clean install` is happy w/o the `TravesralInterruptionComputerTest` (commented out). Running full integration tests now... --- If your project is set up for it, you can reply

[GitHub] incubator-tinkerpop issue #325: TINKERPOP-1321 Introduce Kryo shim to suppor...

2016-06-06 Thread okram
Github user okram commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/325 We use `Random` in numerous places to test various "versions" of a particular code block. It is possible to replace all possible choices with new `GraphProviders` but you a

[GitHub] tinkerpop pull request #:

2016-06-10 Thread okram
Github user okram commented on the pull request: https://github.com/apache/tinkerpop/commit/e790e56aaa2118b07e36f2579502786bd9d79cc0#commitcomment-17830411 In docs/src/recipes/centrality.asciidoc: In docs/src/recipes/centrality.asciidoc on line 26: This is a really "local

[GitHub] incubator-tinkerpop issue #325: TINKERPOP-1321 Introduce Kryo shim to suppor...

2016-06-03 Thread okram
Github user okram commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/325 @dalaro -- you mention: ``` spark.serializer=KryoSerializer spark.kryo.registrator=com.tinkerpop.something.TinkerPopRegistrator ``` I think we need

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1310: Allow OLAP to re...

2016-05-25 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/319 TINKERPOP-1310: Allow OLAP to return properties as Detached https://issues.apache.org/jira/browse/TINKERPOP-1310 I created {{HaltedTraverserFactoryStrategy}} which is an OLAP

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1310: Allow OLAP to re...

2016-05-25 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/319#issuecomment-221718317 Sorry. Giraph is breaking on integration tests. Easy fix. Will post BUILD status when full integration tests complete. --- If your project is set up

[GitHub] tinkerpop pull request #337: TINKERPOP-1332: Improve .explain() Dialogue

2016-06-15 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/337 TINKERPOP-1332: Improve .explain() Dialogue https://issues.apache.org/jira/browse/TINKERPOP-1332 `TraversalExplanation.toString()` now supports word wrapping and `GraphFilter` information

[GitHub] tinkerpop issue #344: gremlin_python: generate/build/deps before tests

2016-06-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/344 Can you add the license boilerplate? BTW: Just pulled your patch and building locally now. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tinkerpop issue #338: TINKERPOP-1139 Re-assigned step labels as appropriate ...

2016-06-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/338 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #342: TINKERPOP-1063 TinkerGraph Performance

2016-06-16 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/342 Do we know that its faster? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tinkerpop issue #343: restructured gremlin-python package

2016-06-20 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/343 This just changed to here: https://github.com/apache/tinkerpop/blob/TINKERPOP-1278/gremlin-variant/src/test/java/org/apache/tinkerpop/gremlin/python/JythonScriptEngineSetup.java#L36-L59

[GitHub] tinkerpop issue #337: TINKERPOP-1332: Improve .explain() Dialogue

2016-06-21 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/337 Can someone else VOTE on this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tinkerpop issue #337: TINKERPOP-1332: Improve .explain() Dialogue

2016-06-21 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/337 Note that there is a fall back if the `getWidth()` is "too small" ... people say when it fails, it returns -1 so the fall back will kick in. --- If your project is set up for it, you

[GitHub] tinkerpop issue #343: restructured gremlin-python package

2016-06-17 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/343 When I run the test suite, I get failures. ``` File "src/main/jython/gremlin_python/groovy_translator.py", line 23, in from .gremlin_python import P ValueError:

[GitHub] tinkerpop issue #343: restructured gremlin-python package

2016-06-20 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/343 This is how the Python modules are loaded into Jython. https://github.com/apache/tinkerpop/blob/TINKERPOP-1278/gremlin-variant/src/test/java/org/apache/tinkerpop/gremlin/python

[GitHub] tinkerpop issue #339: TINKERPOP-939 Added docs for Neo4j HA configuration.

2016-06-16 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/339 Beautiful. Thank you for doing testing that and finally getting that ticket done. Crazy it worked the whole time we just didn't know... VOTE +1. --- If your project is set up for it, you can reply

[GitHub] tinkerpop issue #378: TINKERPOP-1397 Fix StarGraph.addEdge

2016-08-11 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/378 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #377: TINKERPOP-1397 StarGraph filtering with self edges

2016-08-11 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/377 This solution makes sense to me -- no new `SelfEdge` class and we now have a test case. Thanks. VOTE +1. --- If your project is set up for it, you can reply to this email and have your

[GitHub] tinkerpop issue #371: Added new recipe for Traversal Induced Values.

2016-08-04 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/371 VOTE +1. This got me to thinking that we really need to start to extend other steps (beyond the `Mutating`) to support traversal parameterization. --- If your project is set up

[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.

2016-07-12 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/351 Adding my email on dev@ to here. I’m not following this PR too closely so what I might be saying is a already known/argued against/etc. 1. I think we should go

[GitHub] tinkerpop issue #348: TINKERPOP-1071 Enhance pre-processor output

2016-06-28 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/348 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #349: TINKERPOP-1349: RepeatUnrollStrategy should unroll loo...

2016-06-28 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/349 NOTE: This can not go into `tp31/` because `NoOpBarrierStep` is new to TinkerPop 3.2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] tinkerpop pull request #349: TINKERPOP-1349: RepeatUnrollStrategy should unr...

2016-06-28 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/349 TINKERPOP-1349: RepeatUnrollStrategy should unroll loops while maintaining equivalent semantics. https://issues.apache.org/jira/browse/TINKERPOP-1349 `RepeatUnrollStrategy` is a Standard

[GitHub] tinkerpop issue #355: TINKERPOP-1355 Design HasContainer for extension

2016-07-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/355 Clean changes. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] tinkerpop issue #354: TINKERPOP-1354 Added more invalid binding keys to Grem...

2016-07-06 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/354 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

2016-07-06 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/346 Smart. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #335: TINKERPOP-1319: fix incorrect FeatureRequirement annot...

2016-07-06 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/335 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #:

2016-07-06 Thread okram
Github user okram commented on the pull request: https://github.com/apache/tinkerpop/commit/1915fa531a5b3fb20b59d258313224864448ae0a#commitcomment-18144354 In gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Translator.java: In gremlin-core/src/main/java

[GitHub] tinkerpop issue #358: TINKERPOP-1254 Support dropping traverser path informa...

2016-07-11 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/358 VOTE +1 ``` [INFO] [INFO] BUILD SUCCESS [INFO

[GitHub] tinkerpop issue #372: DSP-1397 Fix StarGraph addEdge for self-edges

2016-08-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/372 Ah. Gotcha. Yea, please feel free to update my branch source with respect test that does the break and I can work to fix it. --- If your project is set up for it, you can reply to this email

[GitHub] tinkerpop issue #366: TINKERPOP-1379 remove excess bulk in tail buffer

2016-08-04 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/366 VOTE +1. Note that I added a comment for how to make the test case simpler. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tinkerpop issue #367: TINKERPOP-1350 was never quite fixed in 3.1.3.

2016-08-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/367 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #357: TINKERPOP-1278 : Make implicit relative imports explic...

2016-08-09 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/357 I tried to merge this but there were two problem: 1.) the PR references old code and thus, lots of conflicts. 2.) graph_traversal and traversal are auto-generated and thus editing

[GitHub] tinkerpop issue #342: TINKERPOP-1063 TinkerGraph Performance

2016-06-30 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/342 Cool stuff. `Stream` is evil. It lurks throughout the codebase... Its funny, we were all gun ho for Java8, but we barely use it :( VOTE +1. --- If your project is set up for it, you can reply

[GitHub] tinkerpop issue #353: TINKERPOP-1341 Add missing classes to GryoRegistrator

2016-06-30 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/353 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #353: TINKERPOP-1341 Add missing classes to GryoRegistrator

2016-06-30 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/353 Crazy. I never new `void.class` existing in Java. ?! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop issue #343: restructured gremlin-python package

2016-06-30 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/343 Yea -- its a little crazy on that branch right now. It will stabilize (be near the end) by the end of next week. --- If your project is set up for it, you can reply to this email and have your

[GitHub] tinkerpop pull request #:

2016-08-17 Thread okram
Github user okram commented on the pull request: https://github.com/apache/tinkerpop/commit/dc79f8fdf134a445ce7b06e13e8975986f41c40c#commitcomment-18672454 It is now automagically installed in install-plugins.groovy. Marko. > On Aug 17, 2016, at 1:53 AM, Dan

[GitHub] tinkerpop pull request #548: TINKERPOP-1589 Re-introduced CloseableIterator

2017-02-01 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/548#discussion_r98930854 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/FlatMapStep.java --- @@ -44,6 +45,7 @@ public FlatMapStep

[GitHub] tinkerpop pull request #548: TINKERPOP-1589 Re-introduced CloseableIterator

2017-02-01 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/548#discussion_r98931140 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GraphStep.java --- @@ -164,13 +164,13 @@ public int hashCode

[GitHub] tinkerpop issue #555: TINKERPOP-1271: Refactor SparkContext creation and han...

2017-02-03 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/555 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #548: TINKERPOP-1589 Re-introduced CloseableIterator

2017-02-01 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/548 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #549: TINKERPOP-1617: Create a SingleIterationStrateg...

2017-01-26 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/549 TINKERPOP-1617: Create a SingleIterationStrategy which will do its best to rewrite OLAP traversals to not message pass. https://issues.apache.org/jira/browse/TINKERPOP-1617

[GitHub] tinkerpop issue #546: TINKERPOP-1583: PathRetractionStrategy retracts keys t...

2017-01-27 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/546 I just tested the `PathRetractionStrategy` code in the GraphActors branch and the `akka-gremlin/` test suite passes. *** Sidenote: can you finalize your variables if possible? VOTE

[GitHub] tinkerpop issue #551: Fix the serializers lookup to handle the type first, t...

2017-01-30 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/551 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #553: remove tests from setup.py

2017-01-27 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/553 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #546: TINKERPOP-1583: PathRetractionStrategy retracts keys t...

2017-01-25 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/546 So the problem I was having was related to the interplay between `PathRetractionStrategy` and `MatchPredicateStrategy`. You can't have `PathRetractionStrategy` without `MatchPredicateStrategy

[GitHub] tinkerpop issue #537: TINKERPOP-1605 gremlin-console 3.2.3 -e can no longer ...

2017-01-20 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/537 Actually, can you add a test case for this so we know it doesn't break again in the future? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] tinkerpop issue #548: TINKERPOP-1589 Re-introduced CloseableIterator

2017-01-27 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/548 Yes. That makes sense to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tinkerpop issue #564: TINKERPOP-1639 Support simple String operations

2017-02-24 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/564 @dkuppitz asked me to say more of my thoughts on the matter. I think we need a general theory for how we are going to handle primitive manipulations. That is, math operators, string

[GitHub] tinkerpop issue #564: TINKERPOP-1639 Support simple String operations

2017-02-24 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/564 Also, what other string operations do we need? I'm thinking reg-ex. So now we have a `filter()` steps for regex, but then what about pattern matching selection. Well, thats not range

[GitHub] tinkerpop issue #563: TINKERPOP-1638 count() is optimized away in where()

2017-02-23 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/563 Can you add the traversal from the mailing list to `CountTest` or `RangeTest` for added confidences? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tinkerpop issue #562: TINKERPOP-1626: choose() is buggy in OLAP

2017-02-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/562 ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop ... SUCCESS

[GitHub] tinkerpop issue #563: TINKERPOP-1638 count() is optimized away in where()

2017-02-23 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/563 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #561: TINKERPOP-1635 Fix duplicate serialization of element ...

2017-02-21 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/561 Should this be directed to `tp32/` and not `master/`? Or is this a breaking change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tinkerpop issue #561: TINKERPOP-1635 Fix duplicate serialization of element ...

2017-02-21 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/561 Note that we will be heavily refactoring GraphSON for TinkerPop 3.3.0 (`master/`) so most of this will be gutted. I will leave it up to @spmallette / @newkek / @aholmberg to decide whether

[GitHub] tinkerpop pull request #562: TINKERPOP-1626: choose() is buggy in OLAP

2017-02-22 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/562 TINKERPOP-1626: choose() is buggy in OLAP https://issues.apache.org/jira/browse/TINKERPOP-1626 `ComputerAwareStep.EndStep` was using `path.extend()` and not `traverser.addLabel

[GitHub] tinkerpop issue #558: TINKERPOP-1631 Improvements to BindingsGremlinPlugin

2017-02-16 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/558 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #560: TINKERPOP-1554: has(propertyKey) should have a ...

2017-02-16 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/560 TINKERPOP-1554: has(propertyKey) should have a corresponding step in Gremlin-Java. https://issues.apache.org/jira/browse/TINKERPOP-1554 Currently `has('name')` compiles to `filter(values

[GitHub] tinkerpop pull request #559: TINKERPOP-1627: LazyBarrierStrategy should not ...

2017-02-15 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/559 TINKERPOP-1627: LazyBarrierStrategy should not append an end barrier. https://issues.apache.org/jira/browse/TINKERPOP-1627 You don't want `LazyBarrierStrategy` appending `NoOpBarriers

[GitHub] tinkerpop issue #535: TINKERPOP-1601 LazyBarrierStrategy should not check is...

2017-01-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/535 This is not the way that this should be done. We shouldn't remove any strategies. What we should do is generalize the `ProfileTests` so they are not so specific about step indexes and the like

[GitHub] tinkerpop pull request #539: TINKERPOP-1606: Refactor GroupStep to not have ...

2017-01-18 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/539 TINKERPOP-1606: Refactor GroupStep to not have the reduction traversal included in its BiOperator. https://issues.apache.org/jira/browse/TINKERPOP-1606 This is huge. With this PR

[GitHub] tinkerpop issue #539: TINKERPOP-1606: Refactor GroupStep to not have the red...

2017-01-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/539 Whoa. Because I branched from `master/` the rebase looked insane nevermind. I will twiddle to `tp32/` upon merge. --- If your project is set up for it, you can reply to this email and have

[GitHub] tinkerpop issue #538: TINKERPOP-1248: OrderGlobalStep should use local star ...

2017-01-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/538 ``` [INFO] [INFO] BUILD SUCCESS [INFO

[GitHub] tinkerpop issue #539: TINKERPOP-1606: Refactor GroupStep to not have the red...

2017-01-19 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/539 ``` [INFO] [INFO] BUILD SUCCESS [INFO

[GitHub] tinkerpop issue #538: TINKERPOP-1248: OrderGlobalStep should use local star ...

2017-01-19 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/538 So `MultiComparator` is internal to a `Traversal`. The way in which GraphSON serializes traversals is via their Bytecode. Thus, when the bytecode gets recompiled on the deserializing end

[GitHub] tinkerpop issue #531: Added more recipes

2017-01-17 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/531 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #535: TINKERPOP-1601 LazyBarrierStrategy should not check is...

2017-01-17 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/535 I was thinking more about this specific problem. The real problem is `ProfileTest`, not `LazyBarrierStrategy`. We need to generalize all the `ProfileTest` test cases such that they not be concerned

[GitHub] tinkerpop issue #535: TINKERPOP-1601 LazyBarrierStrategy should not check is...

2017-01-17 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/535 There are numerous areas where `is.testing` is used for strategies. We shouldn't just do this for one of them and push a PR. We should overhaul the entire system so we don't have some parts

[GitHub] tinkerpop pull request #538: TINKERPOP-1248: OrderGlobalStep should use loca...

2017-01-18 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/538 TINKERPOP-1248: OrderGlobalStep should use local star graph to compute sorts, prior to reduction. https://issues.apache.org/jira/browse/TINKERPOP-1248 We now support having the projected

[GitHub] tinkerpop issue #538: TINKERPOP-1248: OrderGlobalStep should use local star ...

2017-01-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/538 Decided to not touch `GroupStep` till the next release as it is more complicated to handle than `OrderGlobalStep` and `SampleGlobalStep`. Thus, for this PR: VOTE +1. --- If your project

[GitHub] tinkerpop issue #539: TINKERPOP-1606: Refactor GroupStep to not have the red...

2017-01-19 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/539 Just realized that the `GroupStep` work fixed: https://issues.apache.org/jira/browse/TINKERPOP-1261 ``` gremlin> m = ["marko":['blah']] ==>marko=[b

[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful

2016-08-19 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/384 Great. What do you think about `:set color.template=black-background`, `:set color.template=white-background`, etc. And then from there, those "MACRO" command will trigger a series of

[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful

2016-08-19 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/384 Thoughts: 1. I think there is a bit of an overdose of options here. Keep it simple. 2. We have to realize that not everyone has a black background as their terminal. I use a light

[GitHub] tinkerpop issue #385: TINKERPOP-1285 added multi-line line number support

2016-08-19 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/385 I agree with @dkuppitz . Lets make another ticket about deprecating and removing `IdentityRemovalStrategy`. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tinkerpop issue #381: TINKERPOP-1405 - profile() doesn't like withPath()

2016-08-16 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/381 Nice find. I really do hate `RequirementsStep`. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]

2016-08-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/386 @newkek I understand. I like the `@value` concept -- its the JSON sub-object for creating the object (defined by `@type`). VOTE +1. --- If your project is set up for it, you can reply

[GitHub] tinkerpop pull request #560: TINKERPOP-1554: has(propertyKey) should have a ...

2017-02-27 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/560#discussion_r103210119 --- Diff: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/FilterRankingStrategyTest.java --- @@ -106,7

[GitHub] tinkerpop issue #565: TINKERPOP-1612 Remove gremlin-groovy-test

2017-03-01 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/565 Test suite passes. Still doing a code review. Got stuck with the `ComputerVerificationStrategy` merge this afternoon... --- If your project is set up for it, you can reply to this email and have

[GitHub] tinkerpop pull request #560: TINKERPOP-1554: has(propertyKey) should have a ...

2017-02-27 Thread okram
Github user okram closed the pull request at: https://github.com/apache/tinkerpop/pull/560 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] tinkerpop issue #560: TINKERPOP-1554: has(propertyKey) should have a corresp...

2017-02-27 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/560 Realizing that this should really go into `master/` as I just walked through a bunch of the code and notes that we use `PropertiesStep` a lot through out various traversal strategies. Going

[GitHub] tinkerpop issue #554: TINKERPOP-1599 implement real gremlin-python driver

2017-02-27 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/554 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #566: TINKERPOP-1640: ComputerVerificationStrategy gi...

2017-02-28 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/566 TINKERPOP-1640: ComputerVerificationStrategy gives false errors https://issues.apache.org/jira/browse/TINKERPOP-1640 Split `ComputerVerificationStrategy` into two strategies

[GitHub] tinkerpop issue #399: TINKERPOP-1369 Renamed REST API to HTTP API

2016-09-13 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/399 I think is smart. This way all those REST evangelists won't get all uppity. Its funny how REST people are like Ruby/Clojure/Hadoop people -- "bro, insider tip --- its all about REST. S

[GitHub] tinkerpop issue #404: TINKERPOP-1280 VertexPrograms should declare traverser...

2016-09-13 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/404 Very well done code. In other words, in full arrogance and conceit, this is exactly how I would have done it thus, you work is perfect. And like me, I would have skimped on the JavaDoc. Can

[GitHub] tinkerpop issue #414: Release name generator

2016-09-14 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/414 Ha. For sure this is bad ass, but I don't know about putting it into the repo... Well, perhaps off `bin/` or something dunno. VOTE +0. --- If your project is set up for it, you can

[GitHub] tinkerpop issue #415: Tinkerpop 1448: gremlin-python should be Python 2/3 co...

2016-09-14 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/415 I like this. It works for me against Python 2.7.10. The one thing I think would be nice is to move the `compat.py` code into `statics.py`. Why? One less file. The `compat.py` code is all about

[GitHub] tinkerpop pull request #417: TINKERPOP-1330: by()-modulation for where()

2016-09-14 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/417 TINKERPOP-1330: by()-modulation for where() https://issues.apache.org/jira/browse/TINKERPOP-1330 Added `by()`-modulation support to `where()` predicate-based steps. Added 3 solid

[GitHub] tinkerpop issue #397: TINKERPOP-1389 Support Spark 2.0

2016-09-12 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/397 This has been merged into TINKERPOP-1389 off the Apache TinkerPop Git repository. @yucx -- please close this PR. Once I fix the performance issue with GryoSerializer, I will open up a new PR. Thank

[GitHub] tinkerpop issue #398: TINKERPOP-1426, GryoSerializer should implement Java s...

2016-09-12 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/398 This has been merged into TINKERPOP-1389 off the Apache TinkerPop Git repository. @yucx -- please close this PR. Once I fix the performance issue with GryoSerializer, I will open up a new PR. Thank

[GitHub] tinkerpop issue #407: TINKERPOP-1264 Improve BLVP docs

2016-09-12 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/407 VOTE +1. I think this could have been a CTR as its a doc update that provides more information. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tinkerpop pull request #408: TINKERPOP-1440: g:Path needs a GraphSON deseria...

2016-09-12 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/408 TINKERPOP-1440: g:Path needs a GraphSON deserializer in Gremlin-Python This was easy to implement. Now you get a Path `Path` object back with a `str` that looks like Gremlin-Python

[GitHub] tinkerpop issue #417: TINKERPOP-1330: by()-modulation for where()

2016-09-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/417 The Python-related fixes are necessary or else some of the `WhereTests` fail. Python has a bad ordering to the scoping variables with nested `and()`/`or()`. Thus, for the test suite to pass I had

[GitHub] tinkerpop pull request #417: TINKERPOP-1330: by()-modulation for where()

2016-09-15 Thread okram
Github user okram closed the pull request at: https://github.com/apache/tinkerpop/pull/417 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

  1   2   3   4   5   >