GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/346
ResultSet.hasNext should be idempotent
Sorry I didn't create a ticket; JIRA is having problems.
Calling hasNext() multiple times would dequeue items.
You can merge this pull
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/365
Tp31: Minor word and link cleanup
Related to #362
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertdale/tinkerpop tp31-docs-edits
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/368
TINKERPOP-1394: fixed dev list and jira links
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1394
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/362
Minor word and link cleanup
Fixed spelling and links.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertdale/tinkerpop docs-edits
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/361
Java is brain damaged when comparing numbers. Don't blame JSON.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/346
Yes, I ran 'mvn clean install -DskipIntegrationTests=false -DincludeNeo4j'
and it passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/356
Fixed my Spark issue. Wanted to rebuild since giraph, hadoop, and spark
have some dependency on groovy.
Builds cleanly with mvn clean install && mvn verify -pl gremli
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/351
So I've caught up on the discussion and I'll offer some more food for
thought since I haven't seen any other ideas. Embedding metadata is neither
easy nor fun (not for me anyway). For any
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/356
I rebased to include @okram 's fix in the jira ticket. 4.5 hours later,
"docker/build.sh -t -i -n" passed!
---
If your project is set up for it, you can reply to this email and
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/356
This PR does include #353 but not #354 . In the meantime, I'm setting up
docker. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/356
TINKERPOP-1338 Bumped groovy to 2.4.7
No new dependencies introduced.
No other dependency versions changed.
Successful build and verify with:
mvn clean install -pl
gremlin
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/346
Normally that's what I would do but tried doing it the 'github way' -
https://help.github.com/articles/syncing-a-fork/
So let me know what you want me to do now. I can start over
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/346
I merged your master into my fork. Commit
0787e46097cc09bb278ac1c787c4a50ece81cdb0
I didn't realize it would affect the pull request. Next time I'll create a
branch.
---
If your project
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/352
Using (have to ignore hadoop/spark) mvn clean install -pl
gremlin-shaded,gremlin-core,gremlin-test,gremlin-groovy,gremlin-groovy-test,tinkergraph-gremlin,neo4j-gremlin,gremlin-driver,gremlin
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/354
BUILD SUCCESS
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/352
Can you provide the stacktrace (from the surefire report)? What OS, java
versions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/351
@newkek @spmallette Sorry, my context was only this thread. I agree with
you on all accounts.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/537
Isn't there a distribution verification that does tests? I know it's
post-build, but that's better than nothing.
---
If your project is set up for it, you can reply to this email and have
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/536#discussion_r97582757
--- Diff:
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java
---
@@ -105,7 +106,13
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/536
Tests added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/541
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/534#discussion_r102062737
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpBasicAuthenticationHandler.java
---
@@ -92,6 +102,13 @@ public
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/534#discussion_r102062848
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/SaslAuthenticationHandler.java
---
@@ -94,13 +99,17 @@ public void
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/534#discussion_r102058441
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -1035,6 +1035,7 @@ The following table describes the various YAML
configuration
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/534#discussion_r102104360
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpBasicAuthenticationHandler.java
---
@@ -92,6 +102,13 @@ public
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/534#discussion_r102104550
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -1035,6 +1035,7 @@ The following table describes the various YAML
configuration
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/557
transferring my vote from #556
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/556
Verified that this matches the original code. Compared source files and
decompiled class files.
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/536
@spmallette before you say it, I know I have to update changelog and update
docs. :boom:
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/536
And it does. Yay. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/536
Just wondering if posting a comment after updating the title will trigger
JIRA to connect (or however that works).
---
If your project is set up for it, you can reply to this email and have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/536
Looks like I can copy GremlinServerIntegrateTest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
## Color codes:
-BLACK
- RED
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
I think a mockup of the desired coloring effect would be nice to have.
Currently elements just have toString called on them. I added a vertex.color
and edge.color for demonstration purposes
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Disco disco! ANSI is enabled by default. This is actually not a change. It
was this way before this PR. No color scheme by default. If you want colors,
you have to set them yourself. Added
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
I'm definitely not the right person to pick a color scheme. Open for
suggestions or we can figure it out later. Committed the vertex, edge, path
coloring so you can see.
---
If your project
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/385
This is failing due to some random error, not the code change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/384#discussion_r75560386
--- Diff:
gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/GremlinGroovysh.groovy
---
@@ -45,12 +46,13 @@ class GremlinGroovysh
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
I think I'll leave templating for another jira ticket. :satisfied:
Currently, themes (really any `:set` commands) can be saved into files and
loaded with `:load my-gremlin.theme
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
I'm done with changes. Carry on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/384
TINKERPOP-1037 Made life more colorful
Stephen did all the hard work.
- Added option -C to disable ANSI colors just in case.
- Colorized the gremlin ascii art.
- Added bold red
Github user robertdale closed the pull request at:
https://github.com/apache/tinkerpop/pull/383
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Screenshot:
---
If your project is set up for it, you
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
@pluradj I noticed that too. I was thinking that metaclass could be used to
intercept calls to groovy shell's Preferences class and gremlin console could
have its own Java Preferences node
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/401
fixed option step header
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertdale/tinkerpop ref-option-fix
Alternatively you can
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/400
Ok. Didn't notice it mentioned docker and I can't speak to that. However,
it is very repeatable on other systems. Given no other configuration...
```
rm -rf ~/.groovy
rm -rf ~/.m2
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/400
Do you also clean your groovy/grapes dir? artifacts will be copied there
from maven. afterwards, it won't reference the maven artifacts unless they are
also missing from grapes.
---
If your
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/402
fixed hardcoded link
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertdale/tinkerpop fix-hardcoded-link
Alternatively you can
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/399
TINKERPOP-1369 Renamed REST API to HTTP API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1369
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/395
OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale closed the pull request at:
https://github.com/apache/tinkerpop/pull/394
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/395
Hold on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/395
TP31: Server missing scripts directory
Fixed distribution scripts target directory.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/414
Release name generator
$ groovy release-name-generator.groovy
Twenty-Four Gremlin From Tulsa
$ groovy release-name-generator.groovy
(I'd) Wait a Million Gremlin
$ groovy
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/414
That's ok. I don't actually expect this to get merged. Just for fun. This
was a convenient way to share.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user robertdale closed the pull request at:
https://github.com/apache/tinkerpop/pull/414
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/439
Upstart looks simple enough. I don't know if the one @dkuppitz created,
referenced in TINKERPOP-980 , is still viable. But I can't test. Any volunteers?
I would have to say that it's
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/439
Maybe if the script detects that it's called via link with no parameters,
then it's in initd mode and displays help. If the script is called directly
with no parameters, then it just runs
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/439
- `gremlin-server.sh` _is_ the init script. This makes it more inline with
other Apache servers like Tomcat, ActiveMQ, solr, etc.
- Moved how to install "As A Service" fr
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/439
That should still work. What won't work is an invocation of just
"gremlin-server.sh" without parameters. I didn't find any in the code base nor
in the docs (which is highly
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/439
I just tested with backgrounding the job and killing that. That also still
works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/452
TINKERPOP-1189 Increased performance of CredentialGraph authentication
Using lowest complexity 4 (was 10).
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/430
Fix store step documentation
Query produces 2 results since 3.0.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertdale/tinkerpop
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/413
I'm just going to throw my $0.02 out there. Maybe I don't understand the
use case, but this seems strange and unexpected to me. I don't understand why
or how a completely separate client
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/433
Tested a clean console build with 3.2.2 server. Pinging works as expected.
Closing each Client, a Cluster, and ':remote close' does stop pinging as
expected.
Not sure what
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/433
Yup, there it is right there in the javadoc: When close() is called, the
Cluster is left open for the caller to close.
---
If your project is set up for it, you can reply to this email
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/385
TINKERPOP-1285 added multi-line line number support
Looks like:
```
gremlin>
gremlin> 1 +
001 2 +
002 3 +
003 x
No such property: x for
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
There are some things that are out of our control because they are
inherited from groovy.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Would you really want a separate preferences (properties) file or rather
reuse the existing preferences mechanism (:set gremlin.console.errorMessage
red) ?
---
If your project is set up
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/385
This was rebased on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/391
Fixed empty result
Forgot to test this one. Fixed now.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertdale/tinkerpop emptyResult
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/385
@spmallette I can rebase on latest master. Just let me know. Do you think
there is any point in keeping the leading zeroes?
```
gremlin> 1+
..1> 2+
..2> 3+
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/385
I would only be against `===>` because that looks like the result prompt.
I would probably lean towards `001>`. Maybe:
```
gremlin> 1 +
001> 1 +
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/385
OK. And when this is merged with the color preferences PR, it will be
adjusted and left-filled with `.` for the input.prompt length, but no less than
`000>`.
---
If your project is set
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/438
Rebased on tp31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/438
Build is good with `mvn clean install` on my machine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/439
TINKERPOP-980: added sysv and systemd init scripts
I don't know if you want all of this in bin/. I could definitely see the
systemd gremlin-server.service moving out since it's more
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/439
Cool. I was wondering how to link. Didn't think it was absolute. I hope it
works. Tried testing with `./docker/build.sh -d` but it hangs at installing
plugins `* hadoop-gremlin
Github user robertdale closed the pull request at:
https://github.com/apache/tinkerpop/pull/399
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/446
Thanks for the clarification @dkuppitz
`./docker/build.sh -t -i -n ` passes
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/446
Can this PR be updated with Map<Object, Object> or should it be closed and
open a new one?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/446
This is interesting. I was unaware of some or didn't understand some
implementation details. Taking a step back and looking at this again, I wonder
if the original intent is more correct
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I didn't consider that your remote branch was behind. Duh. What should have
been done is a forced push `git push -f origin tp31` to replace your remote
branch with your local branch. Instead
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/457
@pauljackson It's all good. It's only the history here in the PR that looks
weird. Since it's just the one commit, it'll be right in git history when it's
actually merged.
---
If your
Github user robertdale commented on the pull request:
https://github.com/apache/tinkerpop/commit/4eba658bcb347679eda964c27595e5d3969a199a#commitcomment-19987601
In CHANGELOG.asciidoc:
In CHANGELOG.asciidoc on line 49:
1. Isn't it Map<Object,Object>?
2. It should b
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/494
I'm on Apache Maven 3.3.9 (latest). So I'm ok with downgrading :trollface:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/496
TINKERPOP-1556 allow developers to pass options to docker
This was a much smaller change than I expected. Originally I was adding
some sysctl settings to the dockerfiles. In the end I
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/496
Technically, neither, not even for the daemon. It's specific to certain
distribution startup scripts. So there should be no overlap here.
---
If your project is set up for it, you can reply
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/498
There's probably over an hour that can be gained in giraph that's spent in
waiting for everything to shutdown in each test run (about 6s each). Looks like
it's zookeper. But I don't really
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/498
@okram The giraph improvement will help all builds inside or outside of
docker. That should save you about 1 hour. I don't know what OS you're on, but
in Linux you can get some speed
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/498
@spmallette I concur with @dkuppitz that you don't appear to be using
tmpfs. What OS, branches, etc, and how to reproduce the mkdirs issue?
---
If your project is set up for it, you can
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/498
@spmallette looks like this:
```
Step 5 : CMD sh -c docker/scripts/build.sh -t -i -n
---> Running in 3ab3e0b10487
---> 1baf7291ec3a
Removing intermediate con
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/498
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/502
I like the refactoring. But why go backwards in java version? Is this for
source or target compatibility? If it's source, I can't imagine as a dev you
don't have the ability to upgrade
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/498
TINKERPOP-1557 Improve docker build time with this one weird trick!
Total time went from just over 4 hours to 2:20m. Get back 1:40m of your
cycles!
Giraph: startup would wait 3s
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/504
I've seen this on master.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/504#discussion_r88893084
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionComputerTest.java
---
@@ -86,7 +97,7
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/482
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/439
@spmallette I pushed the windows changes. can you review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/439
@PommeVerte do you mind if we move the ubuntu script to a separate pull
request so this one can move forward?
---
If your project is set up for it, you can reply to this email and have your
1 - 100 of 338 matches
Mail list logo
