Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/512
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/508#discussion_r90632990
--- Diff: CHANGELOG.asciidoc ---
@@ -26,6 +26,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
TinkerPop
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/507
`docker/build.sh -t -i -n` passes.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/508
Building world `docker/build.sh -t -i -n -d ` passes.
Building docs only `docker/build.sh -d ` passes.
Skimmed reference docs through browser.
VOTE: +1
---
If your project
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/580
Could you also fix the ones in `docs/src/dev/provider/index.asciidoc` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/588
TINKERPOP-1659 Docker uses custom maven settings.xml
This lets docker use a local maven proxy for faster download. Speeds up
build time for those of us out in the boonies with slow internet
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/588
They've started laying fiber in the county. Hopefully they'll bring it all
the way down my road. But I don't know if that's 1 year or 5 years from now.
Until then, I'm at the outer limits
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/589
I like how the previous example shows the vertices before applying sack().
I think it would be useful to see that before 1 and before 3.
Why was the example withBulk(false) removed? I
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/583
One thing I haven't had much time to think about here is how to propagate
ssl client authentication up (into an authentication handler). Right now it's
at the channel level only. That means
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/587
My app tests pass. Also noticed a slight reduction in test time. :grinning:
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/579#discussion_r107661176
--- Diff: CHANGELOG.asciidoc ---
@@ -26,6 +26,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
TinkerPop
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/589
@spmallette @dkuppitz Separate issue: when I pull up the initial URL to
look at the docs, it's local -
`http://172.17.0.2/` .
Anchor links to the same page are also local
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/589
@mpollmeier Have you used tinkerpop docker before? I'm wondering if you
have an old image. If so, maybe try rebuilding your images. I was able to run
this successfully with the same docker
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/579
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/570
@spmallette If you could just clarify if compilation timeout is
configurable in 3.2? if so, how?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/570
Works now.
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/589
@mpollmeier it lost the additions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/590
Looks like a candidate for tp31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/589
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/589
Updates look good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/589
I rebuilt my images and did not encounter any errors. Maybe something
didn't get pulled down like it should. I've seen connection resets when
pulling down the python stuff.
---
If your
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/595#discussion_r110806894
--- Diff: gremlin-core/src/main/resources/tp2-to-tp3-graphml.xslt ---
@@ -0,0 +1,59 @@
+
+
+
+
+
+http
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/570#discussion_r105750603
--- Diff:
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinGroovyScriptEngine.java
---
@@ -149,19 +159,64
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/570#discussion_r105747128
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -1560,6 +1560,11 @@ and standard deviation evaluation times, as well as
the 75th
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/570#discussion_r105759976
--- Diff:
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinGroovyScriptEngine.java
---
@@ -149,19 +159,64
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/570#discussion_r105764358
--- Diff:
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/CompilationOptionsCustomizer.java
---
@@ -0,0 +1,39
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/570#discussion_r105959185
--- Diff:
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/CompilationOptionsCustomizer.java
---
@@ -0,0 +1,39
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/570#discussion_r105959819
--- Diff:
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/customizer/CompilationOptionsCustomizerProvider.java
---
@@ -31,13
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/567
I have a concern on overall performance. I agree that "Script compilation
is synchronised" helps in the rare case when two or more identical scripts are
submitted concurrently
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/568
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/567
That sounds like a good alternative.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/567
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/603
@pluradj are you calling this a 'pointless burden to the community'? ð¸
Will CTR...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user robertdale closed the pull request at:
https://github.com/apache/tinkerpop/pull/603
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/603
Fix WebSocket documentation
WebSocket is a protocol and a proper noun
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertdale/tinkerpop
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/603
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/685
`docker/build.sh -i -t -n` SUCCESS
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/686
Me likey dat!
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/687
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/688
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user robertdale opened a pull request:
https://github.com/apache/tinkerpop/pull/692
TINKERPOP-1749 Bump to Netty 4.0.50
https://issues.apache.org/jira/browse/TINKERPOP-1749
Many SSL updates, bug fixes.
`docker/build.sh -i -t -n` SUCCESS
VOTE +1
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/692
@spmallette Confirmed no new deps in zip.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/694
Looks like it works for some but not all.
The very first one on the reference page didn't work:
Graph graph = TinkerGraph.open(); (1)
Looks like there are ones with circles
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/674
@jexp Can you change the title to reference
[TINKERPOP-1692](https://issues.apache.org/jira/browse/TINKERPOP-1692) ?
---
If your project is set up for it, you can reply to this email
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/618
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/682
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
Hmm... so just to reiterate and be super clear the desire is to have Neo4j
3.2.2 on TinkerPop 3.3.0.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
The original request was to upgrade on TinkerPop 3.3 on
https://github.com/neo4j-contrib/neo4j-tinkerpop-api-impl/issues/6 . I think
with Neo4j and TinkerPop being on similar 3.x.y version
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
@spmallette Sorry I haven't commented earlier. I don't think this is right.
This PR is using neo4j-tinkerpop-api-impl 0.6-3.2.2 which uses gremlin 3.2.5.
However, master is gremlin 3.3.0
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/682
This all goes back to typing numbers based on storage size is dumb. Most
modern, high-level languages have arbitrary precision on integer and decimal
values. Languages that have strongly typed
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/605
`docker/build.sh -i -t -n` success
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
@spmallette I think the right way to do it is for @jexp to pull out that
neo4j/gremlin procedure into its own, separate module. That's what creates the
cyclic dependency on tinkerpop
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/674
@jexp This PR can be closed. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
Pulled in @jexp latest changes. This depends on SNAPSHOT versions both
ways (cyclic dependencies) so we'll need to update both sides to release
versions at release time.
`mvn clean
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/694
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/692
@spmallette docs success
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/694
Ah, I see now. You've added line continuations `\` on the mid-traversals.
Excellent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/611
@oscerd can you retarget your pull request to tp31 and add an entry in the
CHANGELOG?
Changelogs:
- [2.4.10](http://groovy-lang.org/changelogs/changelog-2.4.10.html
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/609
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/611
@spmallette I have this pull request building now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/612
`docker/build.sh -i -t -n` success on master. Waiting for tp31 to finish.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/612
`docker/build.sh -i -t -n` success on tp31
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/612
@spmallette Yes, I can take this. Confirmed no new deps in gremlin-groovy.
Will verify the zip.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/705
That dependency cycle is bad. It should probably be put in `gremlin-test`.
Maybe even make it a [Graph
Feature](http://tinkerpop.apache.org/docs/current/reference/#_features) -
Cloning.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/705
VOTE +1
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/720#discussion_r140465221
--- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc ---
@@ -95,6 +95,19 @@ In `gremlin-test` there is a new `GraphHelper` class
that has
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/718
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/714
Tests in the jira ticket work as expected.
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/709
Looks good.
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/727
Thanks.
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/703
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/699
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/707
Did it fix https://issues.apache.org/jira/browse/TINKERPOP-1509 ?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/707
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
[Started a
thread](https://lists.apache.org/thread.html/4c8f832ce0640230614989f4d60bfd0078aa69a0e11cfd197015fde1@%3Cdev.tinkerpop.apache.org%3E)
to try to solve my issues.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
Hmm.. even Reference Doc isn't local. Thought it was the first time I
looked at it.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
This makes reviewing so much easier!
VOTE +1
If anyone is interested, these are the times (in seconds) for building each
doc:
15 /usr/src/tinkermem/docs/src/recipes/duplicate
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
Ignore that. Somehow my branch was reset to master. Rebuilding...
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
I ended up using a local copy of hadoop 2.7.2 to complete my docker rebuild.
Anyway, 'Reference Documentation' is now a local link but everything else
still points
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
Docker images are building this morning. Yay.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
@dkuppitz It was change 37a2471932229ae6a4c1f5e5f3f2d3d25bbf7fd4 that
introduced dotnet that required the need to rebuild the images.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/725
That's fine. Now I know what to look for ;-)
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/727
@boliza I created a JIRA issue. Please review it. Can you change the title
to include 'TINKERPOP-1796' and put the link
'https://issues.apache.org/jira/browse/TINKERPOP-1796' in the first
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/724
Nice. VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/705
This doesn't look like a deep copy e.g. modifying a property would be
reflected in both graphs. Which may be fine. I think any limitations should be
noted in the clone method comment.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/701
`docker/build.sh -i -t -n` SUCCESS
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
`docker/build.sh -i -t -n` SUCCESS
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
All better now. Verified new index and cluster property settings.
VOTE +1 again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
I did a rebase to master and messed it up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/702
`docker/build.sh -i -t -n` SUCCESS
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/699#discussion_r136983503
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_O_Traverser.java
---
@@ -62,10 +62,12 @@ public void
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/732
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/741
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/747
@jorgebay On which OS do you get the test errors?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/750
[INFO]
[INFO] BUILD SUCCESS
[INFO
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/745
@mpollmeier Sorry, I thought that `putIfAbsent()` returned the current map
but it returns old mapping or `null` hence the `NPEs`. Should be:
```java
protected void put(final String
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/750
Updated the PR to tp32 base
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/750
Indeed it was. Rebase on tp32. Building..
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/745
`mvn -pl tinkergraph-gremlin -DskipIntegrationTests=false -am clean
install` build SUCCESS
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/742
```
$ sh docker/build.sh -i -t -n
...
[INFO]
[INFO] BUILD SUCCESS
[INFO
101 - 200 of 338 matches
Mail list logo
