Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/950
VOTE +1
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/952#discussion_r223009609
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js
---
@@ -216,14 +219,18 @@ class
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/952#discussion_r223001408
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js
---
@@ -216,14 +219,18 @@ class
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
PR for this is now on #952
---
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/952
TINKERPOP-1959 submit scripts in javascript
https://issues.apache.org/jira/browse/TINKERPOP-1959
Follow on PR to #922 - more details there. This branch now contains a fix
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@mattallenuk I figured out what was going on. The `EnumValue` was being
interpreted as a `Map` when serializing to GraphSON. The change is pretty
trivial, but I have a bunch of other little
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/949
Just pushed a commit 4bdb006c5ee418f27ef7bb8a9330714ce414c50f on the
release branches to deal with these pesky tests that sometimes fail in travis:
```text
[ERROR
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/948
merged to all release branches - thanks @otaviojava
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/946
@robertdale lots of stuff merged today - looks like you need a rebase on
this one
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/948
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
"gremlin-groovy" is fine. The server should default to that if the argument
isn't present.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/928
@jantzeca this merged a day or so ago. it has not been released yet to
nuget. we have releases scheduled for 3.2.10 and 3.3.4 in the next couple of
weeks. it will be available then.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
It works with Java and GraphSON 2.0:
```text
gremlin> cluster = Cluster.build().serializer("GRAPHSON_V2D0").create()
==>localhost/127.0.0.1:8182
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/947#discussion_r222757984
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/graphson-test.js
---
@@ -46,6 +46,30 @@ describe('GraphSONReader
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
`addProperty()` looks right. On `tp32` I guess the default is GraphSON 2.0
which has this form for `Cardinality` values:
http://tinkerpop.apache.org/docs/3.2.9/dev/io/#_cardinality
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
sorry to hear about the sickness. i hope your doing well now. you're right
about the documentation. i think we wanted to focus folks on bytecode based
traversals. we do have a section
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/944
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
hi @mattallenuk - Judging from the comments it seems like the only thing
missing here code-wise is an added test. Administratively, there's some
documentation (reference docs, upgrade docs
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/947
TINKERPOP-2055 Support NaN and Infinity in GraphSON
https://issues.apache.org/jira/browse/TINKERPOP-2055
GraphSON wasn't supporting NaN and Infinity but Gryo was. Merging to tp33
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/944
I think we need to add `TextP` to the IO tests and provide an example in
the related IO docs. I can do that tomorrow.
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/944#discussion_r222063944
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TextP.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/944#discussion_r222063562
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Text.java
---
@@ -0,0 +1,123 @@
+/*
+ * Licensed
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/944#discussion_r222062939
--- Diff: docs/src/reference/the-traversal.asciidoc ---
@@ -3356,24 +3356,32 @@ interface. Steps that allow for this type of
modulation
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/946
Nice cleanup work on all this groovy stuff - thanks
VOTE +1
---
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/945
TINKERPOP-2053 Support for OptionsStrategy
https://issues.apache.org/jira/browse/TINKERPOP-2053
`OptionsStrategy` lets users pass arbitrary configurations at a traversal
level
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/920
VOTE +1
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/943#discussion_r221908780
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Settings.java
---
@@ -243,6 +243,8 @@ public static Settings from(final
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/943#discussion_r221908735
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java
---
@@ -575,6 +585,8 @@ SslContext createSSLContext() throws
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/943
TINKERPOP-2044 Configurable traversal to validate host connectivity.
https://issues.apache.org/jira/browse/TINKERPOP-2044
The user can now configure the script used to validate
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/938
Merged - web site is published though it may take some time to propagate
the changes so as to be visible
---
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/942
TINKERPOP-2049 Added with(k) overload
https://issues.apache.org/jira/browse/TINKERPOP-2049
Makes flag-like uses of with() a bit more succinct. Basically, the
shorthand of `with(k
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/929
oh - i see now...you wrote:
> Once it gets approved,
I didn't' notice that as meaning that you wanted another review. I figured
your "+1 with cool down period
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/941
TINKERPOP-2040 Improve flexibility of GroovyTranslator to handle custom
types
https://issues.apache.org/jira/browse/TINKERPOP-2040
Handled all of the core GraphSON types
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/935
I suppose that it's not surprising that they only did the source release.
Technically, Apache only releases source code - binaries are for user
convenience only.
VOTE +1
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/938
thanks for the explanation. it looks like it's script based and not
bytecode based. it would be cool to see bytecode support in the future. you
might also consider implementing our test suite
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/938
hehe - feel free to use that in your README if you like it :smile:
![gremlin-bottle](https://user-images.githubusercontent.com/384249/46030547-6f67d980-c0c4-11e8-8c52-d2ea8a5c4b50.png
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/938
ah - you added the examples to the README. i was just asking for a response
here but i think it's even better that you put it in the README. Interesting
syntax...thanks for providing
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/920
@otaviojava just wanted to point out that we are preparing for release
(3.2.10 and 3.3.4) in the next couple of weeks. as this change target tp32 and
thus those releases. I just wanted to make
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/939
VOTE +1
---
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/940
TINKERPOP-2039 Bump to Groovy 2.5.2
https://issues.apache.org/jira/browse/TINKERPOP-2039
Required some minor changes to the Console as the CliBuilder is no longer
the recommended
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/938
@samhavens First, thanks for making us aware of this. Second, I've started
a thread on the dev mailing list to call attention to this (all web site
changes go through community
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/934
VOTE +1
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/934#discussion_r219608379
--- Diff:
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GroovyTranslator.java
---
@@ -115,7 +116,8 @@ else if (object
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/934#discussion_r219607573
--- Diff:
gremlin-groovy-test/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GroovyTranslatorTest.java
---
@@ -141,4 +144,52 @@ public void
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/934#discussion_r219606770
--- Diff:
gremlin-groovy-test/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GroovyTranslatorTest.java
---
@@ -141,4 +144,52 @@ public void
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/934#discussion_r219606369
--- Diff:
gremlin-groovy-test/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GroovyTranslatorTest.java
---
@@ -141,4 +144,52 @@ public void
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/925
looks like this is targetted for all the open release branches: 3.2.10,
3.3.4 and 3.4.0. we just agreed on the dev list to push of 3.4.0 for a few
months as it doesn't feel "done&quo
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/929
sorry, i just noticed this, but @jorgebay should this be targetted at tp32?
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/922#discussion_r218854373
--- Diff:
gremlin-server/src/test/resources/org/apache/tinkerpop/gremlin/server/gremlin-server-integration.yaml
---
@@ -41,6 +41,7 @@ serializers
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/925
@FlorianHockmann any reason not to merge/close this one now? it's past the
cool down period so you have lazy consensus at this point.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/933
Assuming there are no objections on the dev list to doing a release
candidate for 3.4.0 then it could be as early as next week, but that discussion
needs to run to completion. Please follow
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
Please see #933 for the PR to the release branch that contains these
changes.
---
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/933
TINKERPOP-1913 Make status attributes available
https://issues.apache.org/jira/browse/TINKERPOP-1913
Status attributes have always been returned from Gremlin Server but they
haven't
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
release for 3.2.10/3.3.4 is under discussion now in the dev list, however
this change is slated for 3.4.0. we could do an release candidate of 3.4.0 for
.NET possibly so as to make this change
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/932#discussion_r218272943
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoSerializersV3d0.java
---
@@ -427,7 +428,12 @@ else if (1
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@FlorianHockmann and @jorgebay are you both good with this now? if so, i
will merge to TINKERPOP-1913 - we can tweak further as necessary from there if
something needs to be addressed.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/931
VOTE +1
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/932#discussion_r217737875
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoSerializersV3d0.java
---
@@ -427,7 +428,12 @@ else if (1
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
there's only known instability in travis itself. i rarely trust it fully
for failures.
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/922#discussion_r217501779
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/translator.js
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/932
TINKERPOP-2033 Maintain order in profile() annotations
https://issues.apache.org/jira/browse/TINKERPOP-2033
Used a synchronized map around a `LinkedHashMap` rather than
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/930
I felt like I tried this once before and I got all kinda hella build
failuresmaybe I'm mistaken. Seems to build now. I would try to merge
forward to the other branches and see what happens
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/903
@FlorianHockmann i don't personally feel like calling for a release this
month as there are things i think i'd still like to see completed, so i think
we're at a point of evaluating month
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/927
TINKERPOP-1921 Added hasNext() in gremlin-python
https://issues.apache.org/jira/browse/TINKERPOP-1921
Adds `hasNext()` to gremlin-python - pretty self explanatory. Would be nice
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/926
TINKERPOP-2031 Removed support for -i in gremlin-server.sh
https://issues.apache.org/jira/browse/TINKERPOP-2031
VOTE +1
You can merge this pull request into a Git repository
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/920
hi @otaviojava - do you plan to come back to this pull request to consider
the comment that @dkuppitz has made here?
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/923
ok - i understand. it can stay here for master only.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/923
This seems to build now along with gremlin server integration tests. Any
reason to not go to `tp33`? if not, please squash and retarget and i can go
ahead an move to merge.
Please
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/898
I've closed this pull request given the recent discussion here to deal with
this on TINKERPOP-2027.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/907
> We develop a gremlin query engine based on c++,
interestingIs that code available as open source?
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
I'm not sure how you ended up in this state, but I don't think you need
these two commits:
* 6c87f04490ea3998cc180c16ba48a47e3d72880d
* b25efcb70a3326193412f06e0526771843913e50
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/905
Ok - I handled the merge and polished up a couple of things. Thanks for
your help on this. Take care!
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/907
hi @RainMark do you plan to come back to address the comments here?
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
Excellent - thanks for doing this. @jorgebay is the better person to handle
this review in full, but I'd like to offer a few points:
> Is it safe to assume that a returned va
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
I think you need to update your fork and rebase on TINKERPOP-1913
@ashwinisingh01 as @redoz suggested.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/898
`subgraph()` serialization is a major problem without a clear solution for
GLVs. there is nothing for anyone to deserialize a returned subgraph into for
GLVs and so it has no where to go. all
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/889
Note that it's pulling in commits from master now. Not sure how you got to
that point exactly, but I think you need to just rebase your commits in your
local repository on your branch
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/919
thanks for the contribution @otaviojava - please edit the PR to target
tp32. we handle the rest of the merge flow to tp33 and master from there unless
there are really ugly merges or something
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/912
VOTE +1 - server integration tests are good - nice job with docs and
everything. thanks for doing this nerd work
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/898
@daem0ndev do you have any thoughts on the recent comments made here?
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/914
Integration tests are working good - code changes look fine: VOTE +1
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/916
I think that this is a good change though, would it be hard to re-target
this to the tp32 branch? I assume the problem is there as well.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/912
They settings are `@Deprecated` not removed - for example:
https://github.com/apache/tinkerpop/pull/912/files#diff-45b18530a9a147f84ad0ee9ddab81fa1R681
once we deprecate
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/912
I wondered that tooi figured the reasoning for tp32 was that this was a
"security" issue and thus the "breaking" aspect was justified. is that a fair
way to characte
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
oh right - i forgot @ashwinisingh01 - i'll take care of it
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@redoz A GLV is a Gremlin Language Variant (Gremlin.NET is an example of
one):
http://tinkerpop.apache.org/docs/current/tutorials/gremlin-language-variants/
A GLV is just
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
thanks for the clarification @Blackbaud-IanThomas - well, that much is
present for Java. again, i agree that we should look to get that added for .NET
as well (and other GLVs).
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
sorry for the extra message here, but @ashwinisingh01 do you mind closing
the #868 PR - we don't need that anymore right?
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@ashwinisingh01 strange that you have so many conflicts on classes that you
didn't touch. it looks like your PR is a little messed up because it contains
my commits in addition to yours
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@redoz if you're referring to the java `ResponseException` then that's done
now from the client perspective (though as I think about it, we could use more
tests in that regard, but i'll leave
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r210646017
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientTests.cs ---
@@ -51,7 +52,18 @@ public async Task
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/842
I proposed the listing on the dev list...the preview release is nice, but
could you reference it in your README so that it's clear. Also, please include
mention of "Apache Tinke
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/889
I'm generally VOTE +1 but have some questions/points to make:
Is this ok pointed at master branch? any reason not to go to tp32/tp33, or
is this a feature we only want on 3.4.0
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/912
Nice PR description and good upgrade docs. I was reading through the
current docs on "Security" and they seem insufficient:
http://tinkerpop.apache.org/docs/current/reference
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/912#discussion_r210029978
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -732,7 +732,10 @@ The following table describes the various
configuration options
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/912#discussion_r210028588
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java
---
@@ -579,7 +657,9 @@ public Builder sslContext(final
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/913
Thanks for taking the time to submit this pull request, but I don't think
we can accept it. TinkerPop is vendor agnostic and this change seems highly
specific to CosmosDB and its operations
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/907
@RainMark did you have a chance to consider the previous comment from
@robertdale ? While I appreciate that you have a solution to a problem you are
seeing, I share his concern about
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/842
I'm not personally in touch with anyone over there really. I usually just
ping folks over there on twitter if I need to convey/ask something - try Luis
Bosquez:
https://twitter.com
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/842
nice @FlorianHockmann - i will manually close this PR now
@danielcweber hope we get to see some more pull requests from you in the
future. really nicely done - i bragged about your
1 - 100 of 1182 matches
Mail list logo