[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-09-05 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/680 All tests pass with `docker/build.sh -t -n -i` VOTE +1 ---

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-09-03 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/680 All better now. Verified new index and cluster property settings. VOTE +1 again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-09-02 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/680 I did a rebase to master and messed it up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-09-02 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/680 `docker/build.sh -i -t -n` SUCCESS VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-08-31 Thread jexp
Github user jexp commented on the issue: https://github.com/apache/tinkerpop/pull/680 @robertdale I did the split of the project into two modules which have been published separately, please have a look.

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-08-08 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/680 @spmallette I think the right way to do it is for @jexp to pull out that neo4j/gremlin procedure into its own, separate module. That's what creates the cyclic dependency on tinkerpop. Then a

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-08-08 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/680 @robertdale can you offer your thoughts on how you see this working? I don't think we want to merge a SNAPSHOT to master. --- If your project is set up for it, you can reply to this email

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-08-04 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/680 Pulled in @jexp latest changes. This depends on SNAPSHOT versions both ways (cyclic dependencies) so we'll need to update both sides to release versions at release time. `mvn clean

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-07-28 Thread jexp
Github user jexp commented on the issue: https://github.com/apache/tinkerpop/pull/680 I pushed a branch here: https://github.com/neo4j-contrib/neo4j-tinkerpop-api-impl/tree/gremlin-330 and updated the other branch here:

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-07-24 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/680 3.3.0 is still SNAPSHOT only. it won't release for another couple of weeks or so i imagine. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-07-24 Thread jexp
Github user jexp commented on the issue: https://github.com/apache/tinkerpop/pull/680 I didn't see a released 3.3.0 version of tp3 on maven central, that's why I used 3.2.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-07-24 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/680 Hmm... so just to reiterate and be super clear the desire is to have Neo4j 3.2.2 on TinkerPop 3.3.0. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-07-24 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/680 The original request was to upgrade on TinkerPop 3.3 on https://github.com/neo4j-contrib/neo4j-tinkerpop-api-impl/issues/6 . I think with Neo4j and TinkerPop being on similar 3.x.y version

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-07-24 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/680 confused - does this mean this PR should target 3.2.2? or is there a neo4j-tinkerpop-api-impl 0.6-3.3.0 to use? --- If your project is set up for it, you can reply to this email and have your

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-07-24 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/680 @spmallette Sorry I haven't commented earlier. I don't think this is right. This PR is using neo4j-tinkerpop-api-impl 0.6-3.2.2 which uses gremlin 3.2.5. However, master is gremlin