[GitHub] incubator-tinkerpop pull request #328: TINKERPOP-1317: use graph class as ro...

2016-06-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-tinkerpop/pull/328


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-tinkerpop pull request #328: TINKERPOP-1317: use graph class as ro...

2016-06-03 Thread twilmes
Github user twilmes commented on a diff in the pull request:

https://github.com/apache/incubator-tinkerpop/pull/328#discussion_r65783485
  
--- Diff: docs/src/dev/provider/index.asciidoc ---
@@ -505,6 +505,11 @@ off for the test suite (the Maven SureFire Plugin is 
configured this way by defa
 include this setting, `false`, in the SureFire 
configuration if tests are failing in an
 unexplainable way.
 
+TIP: When running the `gremlin-test` suite against your implementation, 
you may need to set `build.dir` as an
+envrionment variable, depending on your project layout. Some tests require 
this to find a writable directory for
--- End diff --

Tiny little typo here: "envrionment" -> "environment"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---