[GitHub] tinkerpop issue #818: Remove null values to fix TINKERPOP-1923

2018-04-25 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/818 I think I'm going to have to close this because I can't recreate the problem with the current information supplied and I don't want to merge this PR as-is because it seems like it's just

[GitHub] tinkerpop issue #818: Remove null values to fix TINKERPOP-1923

2018-03-22 Thread jbaker-nca
Github user jbaker-nca commented on the issue: https://github.com/apache/tinkerpop/pull/818 The copying code is as follows (I've simplified a little to make it clearer what's happening, as it's actually part of a bigger chunk code): List newEdges = new

[GitHub] tinkerpop issue #818: Remove null values to fix TINKERPOP-1923

2018-03-22 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/818 @rcaunt how did you do this part: > copy the edges from the original vertex to a new one ---

[GitHub] tinkerpop issue #818: Remove null values to fix TINKERPOP-1923

2018-03-22 Thread rcaunt
Github user rcaunt commented on the issue: https://github.com/apache/tinkerpop/pull/818 @spmallette I've been working with @jbaker-nca to understand this issue a bit more. Our use case for discovering this bug was essentially merging two separate graphs into a single graph.

[GitHub] tinkerpop issue #818: Remove null values to fix TINKERPOP-1923

2018-03-16 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/818 > when removing nodes and/or edges, the collection of edges on a vertex can end up containing null values right, i think i followed that part - i was asking more about the "why" nulls

[GitHub] tinkerpop issue #818: Remove null values to fix TINKERPOP-1923

2018-03-16 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/818 @jbaker-nca Is there a test case that would fail without this fix so it can catch regressions? ---

[GitHub] tinkerpop issue #818: Remove null values to fix TINKERPOP-1923

2018-03-16 Thread jbaker-nca
Github user jbaker-nca commented on the issue: https://github.com/apache/tinkerpop/pull/818 Hi @spmallette, I've made the changes requested. My understanding is that in some cases, when removing nodes and/or edges, the collection of edges on a vertex can end up containing

[GitHub] tinkerpop issue #818: Remove null values to fix TINKERPOP-1923

2018-03-16 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/818 Thanks for looking into this issue. I saw your issue in JIRA and your SO question, but just haven't had a chance to really dig into it. I can see how your solution would get rid of the