[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/919 @dkuppitz Will do. ---

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/919 In the future, can we please let those (potential) CTR's sit for a bit longer? I haven't had a chance to really look at it and I guess I would have voted against it (it's not bad, but also not

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/919 Nevermind, still just grapes. ---

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/919 Hmm.. it happens on tp32. ---

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/919 @otaviojava was that locally? the travis build failed due to grapes download. ---

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

Github user otaviojava commented on the issue: https://github.com/apache/tinkerpop/pull/919 @spmallette @robertdale When I changed the branch to tp32. When execute this code: `return new ASTTransformationCustomizer(InterpreterMode.class);` It returns an NPE, I checked the code.

[GitHub] tinkerpop issue #919: String loop to String builder [master]

Github user otaviojava commented on the issue: https://github.com/apache/tinkerpop/pull/919 @spmallette done. ---

[GitHub] tinkerpop issue #919: String loop to String builder [master]

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/919 thanks for the contribution @otaviojava - please edit the PR to target tp32. we handle the rest of the merge flow to tp33 and master from there unless there are really ugly merges or something

[GitHub] tinkerpop issue #919: String loop to String builder

Github user otaviojava commented on the issue: https://github.com/apache/tinkerpop/pull/919 There are optimizations in Java 8 to String, however, it does not cover to String in a loop. Yes, I checked also in the bytecode. After that, I put the final var. Thank you for the help.

[GitHub] tinkerpop issue #919: String loop to String builder

Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/919 @otaviojava did you decompile the bytecode to make sure the compiler didn't do that automagically? Otherwise, StringBuilder vars should be final. ---