[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

2018-08-23 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/919 @dkuppitz Will do. ---

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

2018-08-23 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/919 In the future, can we please let those (potential) CTR's sit for a bit longer? I haven't had a chance to really look at it and I guess I would have voted against it (it's not bad, but also not

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

2018-08-22 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/919 Nevermind, still just grapes. ---

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

2018-08-22 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/919 Hmm.. it happens on tp32. ---

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

2018-08-22 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/919 @otaviojava was that locally? the travis build failed due to grapes download. ---

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

2018-08-22 Thread otaviojava
Github user otaviojava commented on the issue: https://github.com/apache/tinkerpop/pull/919 @spmallette @robertdale When I changed the branch to tp32. When execute this code: `return new ASTTransformationCustomizer(InterpreterMode.class);` It returns an NPE, I checked the code.