This vote is now closed with a total of 4 +1s, no +0s and no -1s. The results are:
BINDING VOTES: +1 (4 -- Stephen Mallette, Robert Dale, Florian Hockmann, Daniel Kuppitz) 0 (0) -1 (0) Thank you very much, Stephen On Sun, Jan 6, 2019 at 7:41 AM Robert Dale <robd...@gmail.com> wrote: > VOTE +1 > > Robert Dale > > > On Sat, Jan 5, 2019 at 11:45 AM Daniel Kuppitz <m...@gremlin.guru> wrote: > > > All validations passed ... > > > > *Validating binary distributions* > > > > * downloading Apache TinkerPop Gremlin > > (apache-tinkerpop-gremlin-console-3.4.0-bin.zip)... OK > > * validating signatures and checksums ... > > * PGP signature ... OK > > * SHA512 checksum ... OK > > * unzipping Apache TinkerPop Gremlin ... OK > > * validating Apache TinkerPop Gremlin's docs ... OK > > * validating Apache TinkerPop Gremlin's binaries ... OK > > * validating Apache TinkerPop Gremlin's legal files ... > > * LICENSE ... OK > > * NOTICE ... OK > > * validating Apache TinkerPop Gremlin's plugin directory ... OK > > * validating Apache TinkerPop Gremlin's lib directory ... OK > > * testing script evaluation ... OK > > > > * downloading Apache TinkerPop Gremlin > > (apache-tinkerpop-gremlin-server-3.4.0-bin.zip)... OK > > * validating signatures and checksums ... > > * PGP signature ... OK > > * SHA512 checksum ... OK > > * unzipping Apache TinkerPop Gremlin ... OK > > * validating Apache TinkerPop Gremlin's docs ... OK > > * validating Apache TinkerPop Gremlin's binaries ... OK > > * validating Apache TinkerPop Gremlin's legal files ... > > * LICENSE ... OK > > * NOTICE ... OK > > * validating Apache TinkerPop Gremlin's plugin directory ... OK > > * validating Apache TinkerPop Gremlin's lib directory ... OK > > > > *Validating source distribution* > > > > * downloading Apache TinkerPop 3.4.0 (apache-tinkerpop-3.4.0-src.zip)... > OK > > * validating signatures and checksums ... > > * PGP signature ... OK > > * SHA512 checksum ... OK > > * unzipping Apache TinkerPop 3.4.0 ... OK > > * building project ... OK > > > > > > ... and given that the issues found by Florian are indeed minor ones (the > > empty Python tabs are caused by missing CSS definitions; I already CTR'd > a > > fix > > < > > > https://github.com/apache/tinkerpop/commit/0c2e0b592092f25bccb0c917297092ca87c1c6b9 > > >) > > ... > > > > VOTE +1 > > > > Cheers, > > Daniel > > > > > > On Sat, Jan 5, 2019 at 5:57 AM Florian Hockmann <f...@florian-hockmann.de> > > wrote: > > > > > I skimmed over the docs and they look good. I really like the new > > > structure and the added sections :-) I only noticed one small issue: > The > > > Python tabs are empty for the first two code listings in Basic Gremlin: > > > http://tinkerpop.apache.org/docs/3.4.0/reference/#basic-gremlin > > > > > > No idea what's going on there as the code examples for Python are > > > definitely in the AsciiDoc file. > > > > > > I also tried to validate the distribution. Everything worked until it > > > builds the project and executes tests which unfortunately fails on my > > > system, probably because a test assumes that the installed locale is > > > en_US. I'm getting this failure with my de_DE locale: > > > > > > /java.text.ParseException: Unparseable date: "Jan 12, 1952"// > > > // at > > > > > > > > > org.apache.tinkerpop.gremlin.driver.ser.binary.GraphBinaryReaderWriterRoundTripTest.input(GraphBinaryReaderWriterRoundTripTest.java:156)/ > > > > > > The german representation of this date would be 12.01.1952 and other > > > locales will again have different formats. We should change this test > to > > > work independently of the locally installed locale, but we can do that > > > any time after the release. > > > > > > These two issues are really minor and shouldn't stop the release in my > > > opinion, so: VOTE +1 > > > > > > Am 04.01.2019 um 23:33 schrieb Stephen Mallette: > > > > <sigh> sorry....the template is just broken. I'll make a note to fix > > > that. > > > > > > > > The tag in Apache Git can be found here: > > > > https://github.com/apache/tinkerpop/tree/3.4.0 > > > > > > > > The release notes are available here: > > > > > > > https://github.com/apache/tinkerpop/blob/3.4.0/CHANGELOG.asciidoc > > > > > > > > > > > > > > > > On Fri, Jan 4, 2019 at 4:52 PM Robert Dale <robd...@gmail.com> > wrote: > > > > > > > >> Some links point to 3.3.4 instead of 3.4.0. > > > >> > > > >> Robert Dale > > > >> > > > >> > > > >> On Fri, Jan 4, 2019 at 4:51 PM Stephen Mallette < > spmalle...@gmail.com > > > > > > >> wrote: > > > >> > > > >>> Hello, > > > >>> > > > >>> We are happy to announce that TinkerPop 3.4.0 is ready for release. > > > >>> > > > >>> The release artifacts can be found at this location: > > > >>> https://dist.apache.org/repos/dist/dev/tinkerpop/3.4.0/ > > > >>> > > > >>> The source distribution is provided by: > > > >>> apache-tinkerpop-3.4.0-src.zip > > > >>> > > > >>> Two binary distributions are provided for user convenience: > > > >>> apache-tinkerpop-gremlin-console-3.4.0-bin.zip > > > >>> apache-tinkerpop-gremlin-server-3.4.0-bin.zip > > > >>> > > > >>> The GPG key used to sign the release artifacts is available at: > > > >>> https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS > > > >>> > > > >>> The online docs can be found here: > > > >>> http://tinkerpop.apache.org/docs/3.4.0/ (user docs) > > > >>> http://tinkerpop.apache.org/docs/3.4.0/upgrade/ (upgrade > > docs) > > > >>> http://tinkerpop.apache.org/javadocs/3.4.0/core/ (core > > > javadoc) > > > >>> http://tinkerpop.apache.org/javadocs/3.4.0/full/ (full > > > javadoc) > > > >>> > > > >>> The tag in Apache Git can be found here: > > > >>> https://github.com/apache/tinkerpop/tree/3.3.4 > > > >>> > > > >>> The release notes are available here: > > > >>> > > > >> https://github.com/apache/tinkerpop/blob/3.3.4/CHANGELOG.asciidoc > > > >>> The [VOTE] will be open for the next 72 hours --- closing Monday > > > (January > > > >>> 7, 2019) at 5:00pm EST. > > > >>> > > > >>> My vote is +1. > > > >>> > > > >>> Thank you very much, > > > >>> > > > >>> Stephen > > > >>> > > > > > >
