[GitHub] incubator-tinkerpop pull request: TINKERPOP-1301 Provide Javadoc f...

2016-05-20 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/314#discussion_r64039957 --- Diff: hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/structure/io/script/ScriptOutputFormat.java --- @@ -29,6 +29,12

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1305: HALTED_TRAVERSER...

2016-05-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/316#issuecomment-220440890 These are "master traversal" traversers. Even before when it was stored in sideeffects, those are ultimately stored in `Configuration` (`TRAVER

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1035: HALTED_TRAVERSER...

2016-05-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/316#issuecomment-220384591 This also solves https://issues.apache.org/jira/browse/TINKERPOP-1298 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1035: HALTED_TRAVERSER...

2016-05-19 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/316 TINKERPOP-1035: HALTED_TRAVERSERS hold wrong information https://issues.apache.org/jira/browse/TINKERPOP-1305 @dkuppitz found a severe bug in 3.2.0 in OLAP traversal chains

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1281 & TINKERPOP-1282 ...

2016-05-13 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/312#issuecomment-219033703 ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1281 & TINKERPOP-1282 ...

2016-05-12 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/312 TINKERPOP-1281 & TINKERPOP-1282 & TINKERPOP-1299: OLAP chains and traverser propagation https://issues.apache.org/jira/browse/TINKERPOP-1281 https://issues.apache.org/jir

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1297 Updated the gephi...

2016-05-12 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/308#issuecomment-218852572 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1300 Fixed many broken...

2016-05-11 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/311#issuecomment-218552985 VOTE +1. This is CTR'able in my opinion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1293: Implement GraphF...

2016-05-11 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/310#discussion_r62851083 --- Diff: tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerGraphComputer.java --- @@ -54,6

[GitHub] incubator-tinkerpop pull request: Broaden catch for computePath.

2016-05-11 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/309#issuecomment-218463603 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1293: Implement GraphF...

2016-05-10 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/310#issuecomment-218332211 ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1293: Implement GraphF...

2016-05-10 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/310#issuecomment-218266032 CHANGELOG ``` * `GraphFilter` helper methods are now more intelligent when determining edge direction/label legality. * Added

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1293: Implement GraphF...

2016-05-10 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/310 TINKERPOP-1293: Implement GraphFilterStrategy as a default registration for GraphComputer https://issues.apache.org/jira/browse/TINKERPOP-1293 `GraphFilterStrategy` (traversal

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1295 Precompile Script...

2016-05-07 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/307#issuecomment-217633168 Perfect. This will come in handy with all my Friendster benchmarking that uses `ScriptInputFormat`. Did a code review, makes perfect sense

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-06 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/305#discussion_r62347949 --- Diff: spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/process/computer/traversal/strategy/optimization/interceptor

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-06 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/305#discussion_r62347464 --- Diff: spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/process/computer/traversal/strategy/optimization/interceptor

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-05 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/305#issuecomment-217260649 ``` [INFO] Apache TinkerPop .. SUCCESS [4.770s] [INFO] Apache TinkerPop :: Gremlin Shaded SUCCESS

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-05 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/305 TINKERPOP-1288 & TINKERPOP-1290: VertexProgramInterceptor and GraphComputer TraversalStrategies https://issues.apache.org/jira/browse/TINKERPOP-1288 https://issues.apache.org/

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-04 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216886769 That is a wierd `NullPointerException` in that the `graphProvider` of the test is null. ``` graphProvider

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-04 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216862192 Another thing that is weird. `TinkerGraphStepStrategyTest` doesn't even use `TraversalVertexProgram` and thus, this failure is in no way related t

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-04 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216856863 @dkuppitz --- I can't seem to reproduce this. Note that there is nothing in this PR that has to do with the testing infrastructure (`AbstractGremli

[GitHub] incubator-tinkerpop pull request: TINKERPOP-946 Interrupting Trave...

2016-05-03 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/299#issuecomment-216542972 You don't need it in `ComputerResultStep` either as that is a simple `AbstractStep` and thus, gets the "interrupt check" from `next(

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-03 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216533557 VOTE +1 -- integration tests and Blade cluster benchmarking/testing. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-03 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/301 TINKERPOP-1120: If there is no view nor messages, don't create empty views/messages in SparkExecutor https://issues.apache.org/jira/browse/TINKERPOP-1120 The followi

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1279: Add Iterable ...

2016-05-02 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/300 TINKERPOP-1279: Add Iterable parameter constructor to ConnectiveP subclasses https://issues.apache.org/jira/browse/TINKERPOP-1279 `ConnectiveP` and its two subclasses `OrP` and

[GitHub] incubator-tinkerpop pull request: TINKERPOP-946 Interrupting Trave...

2016-04-30 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/299#issuecomment-215977029 I don't think you need to put as may interrupt checks. Most steps inherit from `AbstractStep` and thus, if `AbstractStep.next()` and `AbstractStep.ha

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1284: StarGraph does n...

2016-04-29 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/298 TINKERPOP-1284: StarGraph does not handle self-loops correctly. https://issues.apache.org/jira/browse/TINKERPOP-1284 ``` gremlin> graph = TinkerGraph.o

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1232: Write a tutorial...

2016-04-27 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/296#issuecomment-215185511 A changed "is a" to "provides". Regarding naming, there are two classes: `gremlin-jython.py` (which is all JVM-based) an

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1232: Write a tutorial...

2016-04-27 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/296 TINKERPOP-1232: Write a tutorial demonstrating the 3 ways to write a Gremlin language variant. https://issues.apache.org/jira/browse/TINKERPOP-1232 A tutorial demonstrating how

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1272 Added init-tp-spa...

2016-04-27 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/295#issuecomment-215074715 Thanks for handling this. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1269 More Configuratio...

2016-04-21 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/293#issuecomment-212856545 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1263 Pass SASL mechani...

2016-04-20 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/291#issuecomment-212528365 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1020 Provide --dryRun ...

2016-04-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/286#issuecomment-212021887 Very cool PR. Thanks @dkuppitz -- VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-tinkerpop pull request: Fix NPE in ObjectWritable.toStri...

2016-04-06 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/287#issuecomment-206585855 There were other issues around NPE. I fixed those and added an `ObjectWritableTest`. Can you please close this PR. --- If your project is set up for it

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1225: Do a "rolling re...

2016-03-31 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/285#issuecomment-203927074 ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1225: Do a "rolling re...

2016-03-30 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/285 TINKERPOP-1225: Do a "rolling reduce" for GroupXXXStep in OLAP. https://issues.apache.org/jira/browse/TINKERPOP-1225 We now can do mid-barrier reductions in with `g

[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...

2016-03-30 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203429631 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1234: program() step t...

2016-03-30 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/283#issuecomment-203393903 Huh. I don't know why I didn't catch that. We already OPT_OUT of a related in `RemoteGraph`. ``` @Graph.OptOut(

[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...

2016-03-30 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203391062 Can you also check Neo4j? This is the "full integration" test command. ``` mvn clean install -DskipIntegrationTests=false -Din

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1237: ProjectMap: For ...

2016-03-29 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/284#discussion_r57778538 --- Diff: docs/src/reference/the-traversal.asciidoc --- @@ -1376,6 +1376,24 @@ metrics = t.getSideEffects().get('metrics') For

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1237: ProjectMap: For ...

2016-03-29 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/284 TINKERPOP-1237: ProjectMap: For the Love of Die Faterland https://issues.apache.org/jira/browse/TINKERPOP-1237 Added `GraphTraversal.project()` which allows is like the inverse

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1223: Allow jars in gr...

2016-03-29 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/282#discussion_r57736007 --- Diff: hadoop-gremlin/src/test/java/org/apache/tinkerpop/gremlin/hadoop/process/computer/AbstractHadoopGraphComputerTest.java --- @@ -0,0

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1223: Allow jars in gr...

2016-03-29 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/282#discussion_r57735850 --- Diff: hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/process/computer/AbstractHadoopGraphComputer.java --- @@ -195,4

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1223: Allow jars in gr...

2016-03-29 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/282#discussion_r57735840 --- Diff: hadoop-gremlin/src/test/java/org/apache/tinkerpop/gremlin/hadoop/process/computer/AbstractHadoopGraphComputerTest.java --- @@ -0,0

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1234: program() step t...

2016-03-29 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/283 TINKERPOP-1234: program() step that takes arbitrary vertex programs https://issues.apache.org/jira/browse/TINKERPOP-1234 We now have `GraphTraversal.program(VertexProgram)`. This

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1223: Allow jars in gr...

2016-03-28 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/282 TINKERPOP-1223: Allow jars in gremlin.distributedJars to be read from HDFS https://issues.apache.org/jira/browse/TINKERPOP-1223 If a `HADOOP_GREMLIN_LIBS` directory does not

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1163: GraphComputer's ...

2016-03-26 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/278#issuecomment-201910150 You can see how computer-only strategies don't show up in OLTP. ``` gremlin> g = TinkerFactory.createModern().t

[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...

2016-03-26 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-201909772 @pietermartin -- From just a code review, everything looks really clean and consistent with the conventions thus far. You added to `traversal.asciidoc`, you

[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...

2016-03-26 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/279#discussion_r57517467 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/OptionalTest.java --- @@ -0,0 +1,154

[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...

2016-03-26 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/279#discussion_r57517425 --- Diff: docs/src/reference/the-traversal.asciidoc --- @@ -1127,6 +1127,31 @@ g.V().repeat(both()).times(3).values('age').min()

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1163: GraphComputer's ...

2016-03-26 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/278 TINKERPOP-1163: GraphComputer's can have TraversalStrategies. https://issues.apache.org/jira/browse/TINKERPOP-1163 GraphComputers can now have their own `TraversalStr

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1236: SelectDenormaliz...

2016-03-25 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/277#issuecomment-201704483 This is a failure from another PR that wasn't full integration tested. This is not related to this PR. ``` shouldSerializ

[GitHub] incubator-tinkerpop pull request: Do not include TraversalMetrics ...

2016-03-25 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/195#issuecomment-201594084 @rjbriody --- is this PR still valid? Also, I really think we should keep all the information in there. I believe (moving forward too) that `explain()` and

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1236: SelectDenormaliz...

2016-03-25 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/277#issuecomment-201550250 Sorry. Pushed something that should have gone into `master/` around `GraphFilter` exceptions. Anywho, if this PR gets merged into `master/`, all is good

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1236: SelectDenormaliz...

2016-03-25 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/277#issuecomment-201469671 `mvn clean install` VOTE +1. (Giraph integration will not be effected by this if SparkGraphComputer tests pass -- which they do). --- If your

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1236: SelectDenormaliz...

2016-03-25 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/277 TINKERPOP-1236: SelectDenormalizationStrategy for select().by(starGraph) in OLAP. https://issues.apache.org/jira/browse/TINKERPOP-1236 This is massive. We have been plagued by

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1109 Make Gremlin Cons...

2016-03-24 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/276#issuecomment-201018053 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1231: Get RemoteGraph ...

2016-03-24 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/275#issuecomment-200876559 ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1231: Get RemoteGraph ...

2016-03-23 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/275#issuecomment-200568210 VOTE +1. Docs build and published as well. http://tinkerpop.apache.org/docs/3.2.0-SNAPSHOT/reference/ --- If your project is set up for it, you can reply

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1231: Get RemoteGraph ...

2016-03-22 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/275#issuecomment-200045429 @twilmes --- While we can merge at this time, there is some things I would like @spmallette to look at. He will most likely add a commit. --- If your

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1231: Get RemoteGraph ...

2016-03-22 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/275 TINKERPOP-1231: Get RemoteGraph to work with GraphComputer traversals (OLAP). https://issues.apache.org/jira/browse/TINKERPOP-1231 I got `RemoteGraph` to work with

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1016 Replace junit-ben...

2016-03-22 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/274#issuecomment-199914657 This looks really good. Its pretty simple as it stands, but a good foundation for us to build on. Already have a list of JIRA features to add once this gets

[GitHub] incubator-tinkerpop pull request: Update Maven plugins (mostly min...

2016-03-22 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/263#issuecomment-199907731 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-tinkerpop pull request: TINKERPOP-732 .tree() serializat...

2016-03-22 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/271#issuecomment-199907006 Reviewed code as best I could given my knowledge of GraphSON serialization. VOTE +1. --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1199:Use "MicroMetrics...

2016-03-22 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/273#issuecomment-199886276 Here is the complete branch: https://github.com/apache/incubator-tinkerpop/tree/TINKERPOP-1199 --- If your project is set up for it, you can reply to this

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1199:Use "MicroMetrics...

2016-03-22 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/273#issuecomment-199883620 This is ready to VOTE. The completed branch is actually TINKERPOP-1199 locally (not in @rjbriody's repository anymore). I can't seem to make a PR

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1199:Use "MicroMetrics...

2016-03-21 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/273#issuecomment-199418665 This has been merged to a local `TINKERPOP-1199` branch as more work still needs to be done. Will put up for VOTE via a PR from the local branch after

[GitHub] incubator-tinkerpop pull request: append a note to the note on lam...

2016-03-20 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/272#issuecomment-199069182 I merged by CTR given its a simple doc change. @mpollmeier --- please keep the doc updates coming. Always appreciated. --- If your project is set up for it

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1219: Create a test ca...

2016-03-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/267#issuecomment-197865254 @spmallette -- the problem is that this is a breaking change in that `HasContainers` do id magic. Why do they do that? Seems like a really really bad idea

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1206 & TINKERPOP-1014:...

2016-03-19 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/266 TINKERPOP-1206 & TINKERPOP-1014: Bulk Traversers and Requirements Optimization https://issues.apache.org/jira/browse/TINKERPOP-1206 https://issues.apache.org/jira/browse/TINKE

[GitHub] incubator-tinkerpop pull request: Update hadoop to 2.7.2

2016-03-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/262#issuecomment-198518679 Note that I also verified that this still works with Hadoop 2.7.1 by building the docs with Hadoop 2.7.1 running. --- If your project is set up for it, you

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1219: Create a test ca...

2016-03-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/267#issuecomment-197409086 ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1219: Create a test ca...

2016-03-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/267#issuecomment-197471337 I believe that is all specific to `TinkerGraph` (or the vendor specifically). In short, I don't know. @spmallette ? Why, are you getting re

[GitHub] incubator-tinkerpop pull request: Update hadoop to 2.7.2

2016-03-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/262#issuecomment-198497088 VOTE +1. I merged locally (had to tweak a few other things -- docs and Manifest stuff, but works). This appears okay for `tp31` and an upmerge to

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1219: Create a test ca...

2016-03-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/267#issuecomment-197514987 @dkuppitz -- yea, @spmallette should review this. Why `HasContainer` does casting, I don't know. I think its bad... --- If your project is set up f

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1219: Create a test ca...

2016-03-19 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/267 TINKERPOP-1219: Create a test case that ensures the provider's compilation of g.V(x) and g.V().hasId(x) is identical https://issues.apache.org/jira/browse/TINKERPOP-1219

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1219: Create a test ca...

2016-03-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/267#issuecomment-197591991 I think @spmallette needs to make a call on whether what I have done is still within convention and whether this PR is mergable. --- If your project is set

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1082 & TINKERPOP-1222:...

2016-03-19 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/268 TINKERPOP-1082 & TINKERPOP-1222: Hadoop Configuration Updates https://issues.apache.org/jira/browse/TINKERPOP-1082 https://issues.apache.org/jira/browse/TINKERPOP-1222 We

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1219: Create a test ca...

2016-03-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/267#issuecomment-197391213 @spmallette -- please review this carefully as it deals with ID handling and I know that is a rats nest that you maintain. --- If your project is set up

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1082 & TINKERPOP-1222:...

2016-03-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/268#issuecomment-197990762 Docs have been published: http://tinkerpop.apache.org/docs/3.2.0-SNAPSHOT/reference VOTE +1. --- If your project is set up for it, you can reply

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1206 & TINKERPOP-1014:...

2016-03-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/266#issuecomment-197335092 @twilmes -- it would be great if you reviewed this ticket as it has to do with speed up in `TraverserRequirement` calculations. Perhaps some profiling magic

[GitHub] incubator-tinkerpop pull request: TINKERPOP-575 RemoteGraph

2016-03-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/269#issuecomment-198126388 The insane PR. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1206 & TINKERPOP-1014:...

2016-03-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/266#issuecomment-197334571 ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1206 & TINKERPOP-1014:...

2016-03-18 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/266#issuecomment-197496989 @spmallette -- I dunno. I ran integration tests over night and they passed. I think Travis is fuggled. It always just fails all the tests. --- If your

[GitHub] incubator-tinkerpop pull request: Update hadoop to 2.7.2

2016-03-18 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/262#issuecomment-198522184 Note that I also just merged master/ and all is good in the (proverbial) hood. --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1219: Create a test ca...

2016-03-18 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/267#issuecomment-197971920 @spmallette -- Can you give me the upgrade comment blurb to add to the upgrade docs? I will add it on merge. --- If your project is set up for it, you can

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1209 & TINKERPOP-1210:...

2016-03-15 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/264#issuecomment-197092220 ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1209 & TINKERPOP-1210:...

2016-03-15 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/264 TINKERPOP-1209 & TINKERPOP-1210: OrderXXXStep Updates https://issues.apache.org/jira/browse/TINKERPOP-1209 https://issues.apache.org/jira/browse/TINKERPOP-1210 In OLAP

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1069: Support Spark 1....

2016-03-14 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/260#issuecomment-196552337 ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1069: Support Spark 1....

2016-03-14 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/260 TINKERPOP-1069: Support Spark 1.6.0 https://issues.apache.org/jira/browse/TINKERPOP-1069 Bumped. * Integration tests passed. * Tested manually with `local[4

[GitHub] incubator-tinkerpop pull request: improve predicate doc

2016-03-11 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/259#issuecomment-195429374 Please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-tinkerpop pull request: improve predicate doc

2016-03-11 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/259#issuecomment-195427557 VOTE +1. This is so minor, you could just CTR it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-tinkerpop pull request:

2016-03-11 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/commit/035dc36f4c0f077963949b5222650ee7b4497533#commitcomment-16645889 Ha. Russel Spitzer. ... dar. Thanks for the heads up. --- If your project is set up for it, you can reply to this

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1217: Repeated Logging...

2016-03-11 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/258 TINKERPOP-1217: Repeated Logging of "The HadoopPools has not been initialized, using the default pool" https://issues.apache.org/jira/browse/TINKERPOP-1217 This is a

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1180: Add more optimiz...

2016-03-11 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/254#discussion_r55836702 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/GroupSideEffectStep.java --- @@ -77,7 +77,7

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1096 TINKERPOP-1097 Se...

2016-03-09 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/256#issuecomment-194561611 VOTE +1. This is baller. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1173: If no Serializer...

2016-03-09 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/255 TINKERPOP-1173: If no Serializer is provided in Configuration, use GryoSerializer by default (Spark) https://issues.apache.org/jira/browse/TINKERPOP-1173 If the user does not

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1180: Add more optimiz...

2016-03-09 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/254 TINKERPOP-1180: Add more optimized binary operators to Operator https://issues.apache.org/jira/browse/TINKERPOP-1180 This is simple. Added `Operator.sumLong` which bypasses using

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1184 Fixed bug where s...

2016-03-04 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/252#issuecomment-192336493 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1160 Add timeout confi...

2016-03-04 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/249#issuecomment-192336263 Bro, JavaDoc is for the weak. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

  1   2   3   4   >