[GitHub] incubator-tinkerpop pull request: Docker Integration

2016-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/281 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: Docker Integration

2016-03-30 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/281#issuecomment-203436516 Forgot my own vote in the new PR, hence... VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-tinkerpop pull request: Docker Integration

2016-03-30 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/281#issuecomment-203417372 VOTE +1 - tried a couple commands. looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-tinkerpop pull request: Docker Integration

2016-03-29 Thread PommeVerte
Github user PommeVerte commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/281#issuecomment-203125761 VOTE +1 I think this is great to have around. It will streamline the workflow. I also think it will help with travis testing. I know travis

[GitHub] incubator-tinkerpop pull request: Docker Integration

2016-03-28 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/281 Docker Integration Provided Docker script that allows the execution of several build tasks within a Docker container. You can merge this pull request into a Git repository by running:

[GitHub] incubator-tinkerpop pull request: Docker Integration

2016-03-28 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/280#issuecomment-202486543 Doh, always the same thing. I will create a new PR targeting tp31 (and you're right about the typo in the docs, I will fix that as well). --- If your pro

[GitHub] incubator-tinkerpop pull request: Docker Integration

2016-03-28 Thread dkuppitz
Github user dkuppitz closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-tinkerpop pull request: Docker Integration

2016-03-28 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/280#discussion_r57595422 --- Diff: docs/src/dev/developer/contributing.asciidoc --- @@ -90,6 +90,30 @@ mvn -Dmaven.javadoc.skip=true --projects tinkergraph-gremlin tes

[GitHub] incubator-tinkerpop pull request: Docker Integration

2016-03-28 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/280#issuecomment-202480370 actually based on the CHANGELOG contents and git tree, it looks like it should be targeted at `tp31` and not master, no? --- If your project is set up

[GitHub] incubator-tinkerpop pull request: Docker Integration

2016-03-28 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/280#issuecomment-202479556 any reason this can't be targetted at tp31 and merged forward to master? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-tinkerpop pull request: Docker Integration

2016-03-28 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/280 Docker Integration Provided Docker script that allows the execution of several build tasks within a Docker container. You can merge this pull request into a Git repository by running: