Re: Tagging Tomcat Native 1.2.19

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/29/18 16:29, Mark Thomas wrote: > I think the issues are resolved now so I plan to review the > current state of the code and then tag either later today or early > tomorrow. +1 - -chris -BEGIN PGP SIGNATURE- Comment: Using

Re: Tagging Tomcat Native 1.2.19

2018-11-29 Thread Mark Thomas
I think the issues are resolved now so I plan to review the current state of the code and then tag either later today or early tomorrow. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands,

svn commit: r1847765 - in /tomcat/trunk: java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java webapps/docs/changelog.xml

2018-11-29 Thread markt
Author: markt Date: Thu Nov 29 21:27:43 2018 New Revision: 1847765 URL: http://svn.apache.org/viewvc?rev=1847765=rev Log: Avoid hang with TLS 1.0 and NIO/NIO2+OpenSSL 1.1.1 Modified: tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

Re: svn commit: r1847747 - in /tomcat/trunk/java/org/apache: catalina/core/LocalStrings.properties catalina/core/StandardEngine.java catalina/startup/Catalina.java catalina/startup/LocalStrings.proper

2018-11-29 Thread Mark Thomas
On 29/11/2018 20:36, Rémy Maucherat wrote: > On Thu, Nov 29, 2018 at 9:08 PM Mark Thomas wrote: > >> Indeed. There is some low hanging fruit for a new contributor there. It >> shouldn't be too hard to write a regular expression to look for >> (non-debug) logging calls that don't use a

svn commit: r1847763 - in /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties Tomcat.java

2018-11-29 Thread remm
Author: remm Date: Thu Nov 29 20:50:59 2018 New Revision: 1847763 URL: http://svn.apache.org/viewvc?rev=1847763=rev Log: More cleanups and strings Modified: tomcat/trunk/java/org/apache/catalina/startup/LocalStrings.properties tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

svn commit: r1847762 - in /tomcat/trunk/java/org/apache/catalina/startup: Catalina.java LocalStrings.properties

2018-11-29 Thread remm
Author: remm Date: Thu Nov 29 20:36:53 2018 New Revision: 1847762 URL: http://svn.apache.org/viewvc?rev=1847762=rev Log: More cleanups and strings for Catalina Modified: tomcat/trunk/java/org/apache/catalina/startup/Catalina.java

Re: svn commit: r1847747 - in /tomcat/trunk/java/org/apache: catalina/core/LocalStrings.properties catalina/core/StandardEngine.java catalina/startup/Catalina.java catalina/startup/LocalStrings.proper

2018-11-29 Thread Rémy Maucherat
On Thu, Nov 29, 2018 at 9:08 PM Mark Thomas wrote: > Indeed. There is some low hanging fruit for a new contributor there. It > shouldn't be too hard to write a regular expression to look for > (non-debug) logging calls that don't use a StringManager. > > I see you've added the French

svn commit: r1847761 - /tomcat/trunk/webapps/docs/changelog.xml

2018-11-29 Thread markt
Author: markt Date: Thu Nov 29 20:33:28 2018 New Revision: 1847761 URL: http://svn.apache.org/viewvc?rev=1847761=rev Log: Update translation contributors Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

svn commit: r1847760 - /tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings_pt_BR.properties

2018-11-29 Thread markt
Author: markt Date: Thu Nov 29 20:28:40 2018 New Revision: 1847760 URL: http://svn.apache.org/viewvc?rev=1847760=rev Log: Update Brazilian Portuguese Modified: tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings_pt_BR.properties Modified:

svn commit: r1847759 - /tomcat/trunk/java/org/apache/coyote/LocalStrings_ja.properties

2018-11-29 Thread markt
Author: markt Date: Thu Nov 29 20:27:59 2018 New Revision: 1847759 URL: http://svn.apache.org/viewvc?rev=1847759=rev Log: Update Japanese translations Modified: tomcat/trunk/java/org/apache/coyote/LocalStrings_ja.properties Modified:

svn commit: r1847758 - /tomcat/trunk/java/org/apache/catalina/util/LocalStrings_ru.properties

2018-11-29 Thread markt
Author: markt Date: Thu Nov 29 20:27:42 2018 New Revision: 1847758 URL: http://svn.apache.org/viewvc?rev=1847758=rev Log: Update Russian translations Added: tomcat/trunk/java/org/apache/catalina/util/LocalStrings_ru.properties (with props) Added:

svn commit: r1847757 - in /tomcat/trunk/java/org/apache: catalina/ha/authenticator/LocalStrings_zh_CN.properties catalina/session/LocalStrings_zh_CN.properties coyote/http2/LocalStrings_zh_CN.properti

2018-11-29 Thread markt
Author: markt Date: Thu Nov 29 20:27:17 2018 New Revision: 1847757 URL: http://svn.apache.org/viewvc?rev=1847757=rev Log: Update Simplified Chinese translations Added: tomcat/trunk/java/org/apache/catalina/ha/authenticator/LocalStrings_zh_CN.properties (with props) Modified:

svn commit: r1847756 - in /tomcat/trunk/java/org/apache: catalina/connector/ catalina/core/ catalina/filters/ catalina/ha/deploy/ catalina/loader/ catalina/realm/ catalina/servlets/ catalina/startup/

2018-11-29 Thread markt
Author: markt Date: Thu Nov 29 20:26:32 2018 New Revision: 1847756 URL: http://svn.apache.org/viewvc?rev=1847756=rev Log: UPdate Russian Added: tomcat/trunk/java/org/apache/catalina/loader/LocalStrings_ru.properties (with props)

svn commit: r1847755 - in /tomcat/trunk: java/org/apache/catalina/connector/LocalStrings_de.properties java/org/apache/jasper/resources/LocalStrings_de.properties webapps/examples/WEB-INF/classes/Loca

2018-11-29 Thread markt
Author: markt Date: Thu Nov 29 20:25:43 2018 New Revision: 1847755 URL: http://svn.apache.org/viewvc?rev=1847755=rev Log: Update German translations Modified: tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_de.properties

svn commit: r1847754 - in /tomcat/trunk/java/org/apache: catalina/authenticator/ catalina/connector/ catalina/core/ catalina/ha/deploy/ catalina/tribes/group/interceptors/ catalina/tribes/tipis/ coyot

2018-11-29 Thread markt
Author: markt Date: Thu Nov 29 20:24:54 2018 New Revision: 1847754 URL: http://svn.apache.org/viewvc?rev=1847754=rev Log: Update Spanish translations Added: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/LocalStrings_es.properties (with props) Modified:

svn commit: r1847752 - in /tomcat/trunk: java/org/apache/catalina/authenticator/ java/org/apache/catalina/authenticator/jaspic/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/

2018-11-29 Thread markt
Author: markt Date: Thu Nov 29 20:22:29 2018 New Revision: 1847752 URL: http://svn.apache.org/viewvc?rev=1847752=rev Log: Update Japanese translations Added: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings_ja.properties (with props)

svn commit: r1847751 - in /tomcat/trunk/java/org/apache: catalina/core/LocalStrings_fr.properties catalina/startup/LocalStrings_fr.properties coyote/http11/LocalStrings_fr.properties

2018-11-29 Thread markt
Author: markt Date: Thu Nov 29 20:15:11 2018 New Revision: 1847751 URL: http://svn.apache.org/viewvc?rev=1847751=rev Log: Update French translations Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings_fr.properties

Re: svn commit: r1847747 - in /tomcat/trunk/java/org/apache: catalina/core/LocalStrings.properties catalina/core/StandardEngine.java catalina/startup/Catalina.java catalina/startup/LocalStrings.proper

2018-11-29 Thread Mark Thomas
On 29/11/2018 20:05, Rémy Maucherat wrote: > On Thu, Nov 29, 2018 at 9:02 PM Mark Thomas wrote: > >> On 29/11/2018 19:46, r...@apache.org wrote: >>> Author: remm >>> Date: Thu Nov 29 19:46:04 2018 >>> New Revision: 1847747 >>> >>> URL: http://svn.apache.org/viewvc?rev=1847747=rev >>> Log: >>>

Re: svn commit: r1847747 - in /tomcat/trunk/java/org/apache: catalina/core/LocalStrings.properties catalina/core/StandardEngine.java catalina/startup/Catalina.java catalina/startup/LocalStrings.proper

2018-11-29 Thread Rémy Maucherat
On Thu, Nov 29, 2018 at 9:02 PM Mark Thomas wrote: > On 29/11/2018 19:46, r...@apache.org wrote: > > Author: remm > > Date: Thu Nov 29 19:46:04 2018 > > New Revision: 1847747 > > > > URL: http://svn.apache.org/viewvc?rev=1847747=rev > > Log: > > i18n and cleanup > > I've added these new terms to

Re: svn commit: r1847747 - in /tomcat/trunk/java/org/apache: catalina/core/LocalStrings.properties catalina/core/StandardEngine.java catalina/startup/Catalina.java catalina/startup/LocalStrings.proper

2018-11-29 Thread Mark Thomas
On 29/11/2018 19:46, r...@apache.org wrote: > Author: remm > Date: Thu Nov 29 19:46:04 2018 > New Revision: 1847747 > > URL: http://svn.apache.org/viewvc?rev=1847747=rev > Log: > i18n and cleanup I've added these new terms to POEditor. Mark

svn commit: r1847747 - in /tomcat/trunk/java/org/apache: catalina/core/LocalStrings.properties catalina/core/StandardEngine.java catalina/startup/Catalina.java catalina/startup/LocalStrings.properties

2018-11-29 Thread remm
Author: remm Date: Thu Nov 29 19:46:04 2018 New Revision: 1847747 URL: http://svn.apache.org/viewvc?rev=1847747=rev Log: i18n and cleanup Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java

[Bug 62965] Some request will get the response intended for others similar to CVE-2018-8037

2018-11-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62965 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Bug 62965] Some request will get the response intended for others similar to CVE-2018-8037

2018-11-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62965 --- Comment #1 from Christopher Schultz --- (a) What is your evidence that tomcat responses are being confused? (b) Why would you report a vulnerability "this bad" on a public bug-tracker? If you have legitimate proof of a vulnerability,

[Bug 62965] New: Some request will get the response intended for others similar to CVE-2018-8037

2018-11-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62965 Bug ID: 62965 Summary: Some request will get the response intended for others similar to CVE-2018-8037 Product: Tomcat Connectors Version: 1.2.43 Hardware: Other

svn commit: r1847744 - in /tomcat/trunk: modules/jdbc-pool/ res/maven/ res/tomcat-maven/ webapps/docs/

2018-11-29 Thread csutherl
Author: csutherl Date: Thu Nov 29 17:46:45 2018 New Revision: 1847744 URL: http://svn.apache.org/viewvc?rev=1847744=rev Log: Add XML Namespace to the project element of all POM files so that XML files are Well Formed and Valid Modified: tomcat/trunk/modules/jdbc-pool/pom.xml

Re: svn commit: r1847714 - /tomcat/native/trunk/native/src/sslconf.c

2018-11-29 Thread jean-frederic clere
On 29/11/2018 18:25, Christopher Schultz wrote: > Jean-Frederic, > > On 11/29/18 12:18, jean-frederic clere wrote: >> On 29/11/2018 18:13, Christopher Schultz wrote: >>> Jean-Frederic, >>> >>> On 11/29/18 08:06, jfcl...@apache.org wrote: Author: jfclere Date: Thu Nov 29 13:06:21 2018 New

Re: svn commit: r1847714 - /tomcat/native/trunk/native/src/sslconf.c

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Jean-Frederic, On 11/29/18 12:18, jean-frederic clere wrote: > On 29/11/2018 18:13, Christopher Schultz wrote: >> Jean-Frederic, >> >> On 11/29/18 08:06, jfcl...@apache.org wrote: >>> Author: jfclere Date: Thu Nov 29 13:06:21 2018 New Revision:

Re: Current problems with TLS 1.0 and NIO(2)+native+openssl 1.1.1

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 11/29/18 08:27, Rémy Maucherat wrote: > On Sun, Nov 25, 2018 at 10:42 AM Rainer Jung > wrote: > >> In our Java code, what happens is a call to unwrap() in >> OpenSSLEngine. This call writes I think 146 bytes, then checks >>

[Bug 62964] Add RFC7807 conformant Problem Details for HTTP status codes for Webdav Servlets

2018-11-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62964 --- Comment #3 from Christopher Schultz --- The WebDAV servlet is fairly isolated from everything else in Tomcat. Patches are always welcome. Anything you add to the existing responses should be opt-in based upon configuration of the WebDAV

Re: svn commit: r1847714 - /tomcat/native/trunk/native/src/sslconf.c

2018-11-29 Thread jean-frederic clere
On 29/11/2018 18:13, Christopher Schultz wrote: > Jean-Frederic, > > On 11/29/18 08:06, jfcl...@apache.org wrote: >> Author: jfclere Date: Thu Nov 29 13:06:21 2018 New Revision: >> 1847714 > >> URL: http://svn.apache.org/viewvc?rev=1847714=rev Log: Allow >> to compile with

Re: svn commit: r1847714 - /tomcat/native/trunk/native/src/sslconf.c

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Jean-Frederic, On 11/29/18 08:06, jfcl...@apache.org wrote: > Author: jfclere Date: Thu Nov 29 13:06:21 2018 New Revision: > 1847714 > > URL: http://svn.apache.org/viewvc?rev=1847714=rev Log: Allow > to compile with

[Bug 62964] Add RFC7807 conformant Problem Details for HTTP status codes for Webdav Servlets

2018-11-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62964 --- Comment #2 from Sarah Moy de Vitry --- (In reply to Mark Thomas from comment #1) > How are RFC 7807 error messages meant to be provided to WebDAV clients since > the WebDAV spec predates RFC 7807 and RFC 7807 provides no guidance on this.

svn commit: r1847729 - /tomcat/trunk/webapps/docs/changelog.xml

2018-11-29 Thread remm
Author: remm Date: Thu Nov 29 16:05:35 2018 New Revision: 1847729 URL: http://svn.apache.org/viewvc?rev=1847729=rev Log: Trivial fix (trigger a build) Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

Re: Current problems with TLS 1.0 and NIO(2)+native+openssl 1.1.1

2018-11-29 Thread Rainer Jung
Am 29.11.2018 um 15:55 schrieb Mark Thomas: On 29/11/2018 13:27, Rémy Maucherat wrote: On Sun, Nov 25, 2018 at 10:42 AM Rainer Jung wrote: In our Java code, what happens is a call to unwrap() in OpenSSLEngine. This call writes I think 146 bytes, then checks pendingReadableBytesInSSL(). That

Re: Current problems with TLS 1.0 and NIO(2)+native+openssl 1.1.1

2018-11-29 Thread Mark Thomas
On 29/11/2018 13:27, Rémy Maucherat wrote: > On Sun, Nov 25, 2018 at 10:42 AM Rainer Jung > wrote: > >> In our Java code, what happens is a call to unwrap() in OpenSSLEngine. >> This call writes I think 146 bytes, then checks >> pendingReadableBytesInSSL(). That call in turn calls

svn commit: r1847725 - in /tomcat/trunk: res/tomcat-maven/ res/tomcat-maven/Dockerfile res/tomcat-maven/README.md res/tomcat-maven/pom.xml webapps/docs/changelog.xml

2018-11-29 Thread remm
Author: remm Date: Thu Nov 29 14:29:57 2018 New Revision: 1847725 URL: http://svn.apache.org/viewvc?rev=1847725=rev Log: As requested, add the packaging-using-Maven as well as the corresponding (much simpler than the official one) dockerfile. To be refined most likely. Added:

[Bug 62964] Add RFC7807 conformant Problem Details for HTTP status codes for Webdav Servlets

2018-11-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62964 --- Comment #1 from Mark Thomas --- How are RFC 7807 error messages meant to be provided to WebDAV clients since the WebDAV spec predates RFC 7807 and RFC 7807 provides no guidance on this. Which WebDAV clients support RFC 7807 error

[Bug 60618] Configurable reason phrase in HTTP response

2018-11-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60618 --- Comment #2 from Ralf Hauser --- see also Bug 62964 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail:

[Bug 60362] Missing reason phrase in response

2018-11-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #78 from Ralf Hauser --- see also Bug 62964 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail:

[Bug 62964] Add RFC7807 conformant Problem Details for HTTP status codes for Webdav Servlets

2018-11-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62964 Ralf Hauser changed: What|Removed |Added CC||hau...@acm.org -- You are receiving

Re: Current problems with TLS 1.0 and NIO(2)+native+openssl 1.1.1

2018-11-29 Thread Rémy Maucherat
On Sun, Nov 25, 2018 at 10:42 AM Rainer Jung wrote: > In our Java code, what happens is a call to unwrap() in OpenSSLEngine. > This call writes I think 146 bytes, then checks > pendingReadableBytesInSSL(). That call in turn calls SSL.readFromSSL() > and gets back "0" (from SSL_read()). Up in

[Bug 62964] New: Add RFC7807 conformant Problem Details for HTTP status codes for Webdav Servlets

2018-11-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62964 Bug ID: 62964 Summary: Add RFC7807 conformant Problem Details for HTTP status codes for Webdav Servlets Product: Tomcat 9 Version: 9.0.x Hardware: PC OS:

Re: svn commit: r1847704 - /tomcat/trunk/java/org/apache/catalina/ha/backend/HeartbeatListener.java

2018-11-29 Thread jean-frederic clere
On 29/11/2018 11:04, Mark Thomas wrote: > On 29/11/2018 09:56, jean-frederic clere wrote: >> On 29/11/2018 10:46, ma...@apache.org wrote: >>> Author: markt >>> Date: Thu Nov 29 09:46:49 2018 >>> New Revision: 1847704 >>> >>> URL: http://svn.apache.org/viewvc?rev=1847704=rev >>> Log: >>> Fix issues

svn commit: r1847714 - /tomcat/native/trunk/native/src/sslconf.c

2018-11-29 Thread jfclere
Author: jfclere Date: Thu Nov 29 13:06:21 2018 New Revision: 1847714 URL: http://svn.apache.org/viewvc?rev=1847714=rev Log: Allow to compile with --enable-insecure-export-ciphers Modified: tomcat/native/trunk/native/src/sslconf.c Modified: tomcat/native/trunk/native/src/sslconf.c URL:

buildbot success in on tomcat-trunk

2018-11-29 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3805 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1847709 - /tomcat/trunk/webapps/docs/config/listeners.xml

2018-11-29 Thread jfclere
Author: jfclere Date: Thu Nov 29 10:26:05 2018 New Revision: 1847709 URL: http://svn.apache.org/viewvc?rev=1847709=rev Log: Add missing doc. Modified: tomcat/trunk/webapps/docs/config/listeners.xml Modified: tomcat/trunk/webapps/docs/config/listeners.xml URL:

Re: svn commit: r1847704 - /tomcat/trunk/java/org/apache/catalina/ha/backend/HeartbeatListener.java

2018-11-29 Thread Mark Thomas
On 29/11/2018 09:56, jean-frederic clere wrote: > On 29/11/2018 10:46, ma...@apache.org wrote: >> Author: markt >> Date: Thu Nov 29 09:46:49 2018 >> New Revision: 1847704 >> >> URL: http://svn.apache.org/viewvc?rev=1847704=rev >> Log: >> Fix issues reported by CI >> > > Thanks np I was was nice

svn commit: r1847704 - /tomcat/trunk/java/org/apache/catalina/ha/backend/HeartbeatListener.java

2018-11-29 Thread markt
Author: markt Date: Thu Nov 29 09:46:49 2018 New Revision: 1847704 URL: http://svn.apache.org/viewvc?rev=1847704=rev Log: Fix issues reported by CI Modified: tomcat/trunk/java/org/apache/catalina/ha/backend/HeartbeatListener.java Modified:

buildbot failure in on tomcat-trunk

2018-11-29 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3803 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1847702 - in /tomcat/trunk/java/org/apache/catalina/ha/backend: CollectedInfo.java HeartbeatListener.java

2018-11-29 Thread jfclere
Author: jfclere Date: Thu Nov 29 09:14:27 2018 New Revision: 1847702 URL: http://svn.apache.org/viewvc?rev=1847702=rev Log: Add back the getters and setters and arrange the Listener so that it works in tomcat9. Modified: tomcat/trunk/java/org/apache/catalina/ha/backend/CollectedInfo.java