Re: Finally getting around to switching to Git

2019-04-23 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 4/23/19 10:07, Rémy Maucherat wrote: > On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > > All, > > I haven't updated my local working copies of Tomcat source sinc

Re: Finally getting around to switching to Git

2019-04-23 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 4/23/19 10:07, Rémy Maucherat wrote: > On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > > All, > > I haven't updated my local working copies of Tomcat source sinc

Finally getting around to switching to Git

2019-04-23 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I haven't updated my local working copies of Tomcat source since the move to Git. I'm going to do that, now, and I'm looking for advice. Specifically, which repo is "better" -- gitbox or GitHub? I'm guessing the its all go to the same place

Re: [tomcat] branch master updated: Security hardening. Avoid loading user specified classes.

2019-04-23 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 4/18/19 14:34, ma...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > markt pushed a commit to branch master in repository > https://gitbox.apache.org/repos/asf/tomcat.git > > > The following

Re: [tomcat] branch master updated: Fix resource leak on exception path

2019-04-17 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 4/17/19 12:55, ma...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > markt pushed a commit to branch master in repository > https://gitbox.apache.org/repos/asf/tomcat.git > > > The following

Re: SSLv2Hello "Protocol" Support

2019-04-17 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Coty, On 4/16/19 07:28, Coty Sutherland wrote: > Hi, > > It appears that the IBM JDK (version 8) has dropped support for > SSLv2Hello so when you startup tomcat with the IBM JDK you get a > warning saying that the protocol is being skipped.

Re: [VOTE] Release Apache Tomcat 8.5.40

2019-04-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 4/11/19 12:40, Mark Thomas wrote: > On 11/04/2019 15:21, Christopher Schultz wrote: > > > >> I'm having a bit of trouble building the bundled tcnative. I'm >> tried building against OpenSSL 1.0.2k and 1.1.1 and b

Re: [VOTE] Release Apache Tomcat 8.5.40

2019-04-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Gah. I replied to Mark only yesterday. :( On 4/10/19 10:58, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.40 release is now available for > voting. > > The major changes compared to the 8.5.39 release are: > > - Fix for CVE-2019-0232

Re: [tomcat] 01/01: Fix wrong protocol version usage

2019-04-01 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Michael, On 3/31/19 04:03, micha...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > michaelo pushed a commit to branch wrong-http2-version in > repository https://gitbox.apache.org/repos/asf/tomcat.git

Re: svn commit: r1856174 [1/29] - in /tomcat/site/trunk: docs/ xdocs/ xdocs/stylesheets/

2019-04-01 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Konstantin, On 3/25/19 16:24, Konstantin Kolinko wrote: > пн, 25 мар. 2019 г. в 20:13, Mark Thomas : >> >> On 25/03/2019 16:02, Christopher Schultz wrote: >>> Mark, >>> >>> You don't like leading whitesp

Re: Tomcat Site Redesign

2019-03-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Konstantin, On 3/25/19 17:41, Konstantin Kolinko wrote: > My main concern is that the documentation is printable and is easy > to use as a reference document. > > 1) Not being able to print is a show-stopper. (Really.) Anything > else is just a

Re: svn commit: r1856174 [1/29] - in /tomcat/site/trunk: docs/ xdocs/ xdocs/stylesheets/

2019-03-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, You don't like leading whitespace, now? This diff looks ... WAY bigger than it should have been. - -chris On 3/25/19 05:26, ma...@apache.org wrote: > Author: markt Date: Mon Mar 25 09:26:32 2019 New Revision: 1856174 > > URL:

Re: Default Number of Test Threads

2019-03-16 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 3/15/19 22:38, Igal Sapir wrote: > Chris, > > On Fri, Mar 15, 2019 at 4:56 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >&

Re: Default Number of Test Threads

2019-03-15 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 3/15/19 16:45, Igal Sapir wrote: > On Fri, Mar 15, 2019 at 9:45 AM Konstantin Kolinko > wrote: > >> чт, 14 мар. 2019 г. в 22:26, Igal Sapir : >> What is the use case? People verifying a release? CI >> servers that may have different

Re: Default Number of Test Threads

2019-03-15 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 3/14/19 16:29, Igal Sapir wrote: > On 3/14/2019 12:51 PM, Mark Thomas wrote: >> On 14/03/2019 19:26, Igal Sapir wrote: >>> Does test.threads default to 1 for a reason? >> Mostly historical. The tests weren't originally designed to run >>

Re: Tomcat Site Redesign

2019-03-05 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 3/4/19 01:02, Igal Sapir wrote: > I have uploaded the Tomcat site redesign to a temporary location > for review: http://people.apache.org/~isapir/mockups/tomcat-site/ > > The source can be seen at https://github.com/isapir/tomcat-website

Re: DEBUG binaries for win32/win64

2019-02-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 2/25/19 09:42, Mark Thomas wrote: > On 25/02/2019 14:17, Christopher Schultz wrote: >> All, >> >> At the risk of making the build for Windows even more onerous, >> would it be possible to distribute DEBUG builds

DEBUG binaries for win32/win64

2019-02-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, At the risk of making the build for Windows even more onerous, would it be possible to distribute DEBUG builds along with the standard ones? The native stack trace in this bug report[1] for example is non-existent and useless because it just

Re: Git migration: new branch/tag naming scheme

2019-02-18 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 2/18/19 05:03, Mark Thomas wrote: > On 18/02/2019 09:13, Rémy Maucherat wrote: >> On Sat, Feb 16, 2019 at 4:09 PM Michael Osipov >> wrote: >> >>> Folks, >>> >>> given that we are currently in the process of migrating to Git >>> I'd like

Re: Tag Tomcat 7

2019-02-15 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Violetta, On 2/15/19 05:37, Violeta Georgieva wrote: > На пт, 15.02.2019 г. в 10:24 ч. Mark Thomas > написа: >> >> >> >> On 15/02/2019 07:02, Violeta Georgieva wrote: >>> На вт, 12.02.2019 г. в 7:30 ч. Violeta Georgieva >>> написа:

Confirming that UTF-7 is not a typo in Tomcat docs

2019-02-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I just wanted to confirm that UTF-7 is not a typo on this page: http://tomcat.apache.org/tomcat-9.0-doc/security-howto.html#System_Prope rties Under the system property ENFORCE_ENCODING_IN_GET_WRITER. I'm almost certain that it's *not* a

Re: [Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-02-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 2/13/19 06:46, bugzi...@apache.org wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=63041 > > --- Comment #26 from Mark Thomas --- Got it. > > With the single & the pid of the process that is put in the > background is not the

Re: [PROPOSAL] Copy DBCP 1.x (and POOL 1.x) source to 7.0.x

2019-02-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 2/12/19 08:55, Mark Thomas wrote: > Hi, > > Tomcat 7 depends on DBCP 1.x and POOL 1.x. The last release of each > of these was in 2013. There are a number of fixes I would like to > be able to pull into Tomcat 7 - including the fix for BZ

Re: Quick review of outline for Tomcat security presentation?

2019-02-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, Thanks for the review. On 2/11/19 15:24, Mark Thomas wrote: > On 11/02/2019 19:53, Christopher Schultz wrote: >> https://people.apache.org/~schultz/Apache%20RoadShow%20DC%202019/Lock ing >> >> >> - -Down%20Apache%

Re: Quick review of outline for Tomcat security presentation?

2019-02-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, New and improved! With a link to the outline! https://people.apache.org/~schultz/Apache%20RoadShow%20DC%202019/Locking - -Down%20Apache%20Tomcat_outline.pdf Thanks, - -chris On 2/11/19 11:54, Christopher Schultz wrote: > All, > >

Quick review of outline for Tomcat security presentation?

2019-02-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I'm going to be presenting at the upcoming Apache RoadShow in Washington, DC -- Monday, March 25th if you are local -- and my presentation is on locking-down Tomcat. I have an outline that I'd like anyone to take a look at. It's only 15

APRLifecycleListener on Solaris + gcc

2019-02-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Ref: http://tomcat.apache.org/tomcat-9.0-doc/security-howto.html#Listene rs " The APR Lifecycle Listener is not stable if compiled on Solaris using gcc. If using the APR/native connector on Solaris, compile it with the Sun Studio compiler. "

Re: [VOTE] Release Apache Tomcat Native 1.2.21

2019-01-30 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/25/19 16:06, Mark Thomas wrote: > Version 1.2.21 includes the following changes compared to 1.2.19: > > - Fixed memory leak associated with the use of OpenSSL BIO (used > when OpenSSL provides the TLS functionality for the NIO and NIO2

Proposal: BackupManager *is* "battle-tested"

2019-01-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, The documentation[1][2] for the cluster manager currently says: " Downside of the BackupManager: not quite as battle tested as the delta manager. " I think we can remove this qualification from the BackupManager at this point. In fact, we

Re: [Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2019-01-24 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/23/19 16:55, VP Brand wrote: > On 23/01/2019 21:48, bugzi...@apache.org wrote: >> https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 >> >> --- Comment #14 from Mark Thomas --- Created >> attachment 36389 --> >>

Re: Links to other websites in the documentation?

2019-01-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 1/22/19 14:31, Igal Sapir wrote: > On Tue, Jan 22, 2019 at 11:09 AM Mark Thomas > wrote: > >> On 22/01/2019 18:13, Christopher Schultz wrote: >>> All, >>> >>> Would it be okay to link to anothe

Links to other websites in the documentation?

2019-01-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Would it be okay to link to another web site -- specifically, Wikipedia -- in the Tomcat documentation? I'd like to link to the page on "block cipher modes" from the EncryptInterceptor documentation. We have links to Oracle's documentation,

Re: Setting "svn:mime-type" in non-English .properties (Was: svn commit: r1850330 [1/2] - in /tomcat/trunk/java: ...)

2019-01-07 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/6/19 17:12, Mark Thomas wrote: > On 06/01/2019 21:51, Christopher Schultz wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> Mark, >> >> On 1/6/19 16:37, Mark Thomas wrote: >>>

Re: Setting "svn:mime-type" in non-English .properties (Was: svn commit: r1850330 [1/2] - in /tomcat/trunk/java: ...)

2019-01-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/6/19 16:37, Mark Thomas wrote: > On 06/01/2019 17:40, Christopher Schultz wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> Woonsan, >> >> On 1/4/19 05:11, Woonsan Ko wrote: >&g

Re: buildbot failure in on tomcat-85-trunk

2019-01-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rainer, On 1/6/19 10:09, Rainer Jung wrote: > Hi Chris, > > Am 05.01.2019 um 22:25 schrieb Christopher Schultz: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> All, >> >> Hmm... this my fault.

Re: Setting "svn:mime-type" in non-English .properties (Was: svn commit: r1850330 [1/2] - in /tomcat/trunk/java: ...)

2019-01-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Woonsan, On 1/4/19 05:11, Woonsan Ko wrote: > I've noticed in the commit messages that some i18n bundle files > showing Japanese correctly (e.g, > tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings_ja.pr operties > > below) while

Re: buildbot failure in on tomcat-85-trunk

2019-01-05 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Hmm... this my fault. The EncryptInterceptor tests pass on my local machine but not on the buildbot server, apparently. How can I get the log file from the test failure? junit's stdout isn't enough. Thanks, - -chris On 1/5/19 16:14,

Re: System properties: JVM launch versus catalina.properties

2018-12-28 Thread Christopher Schultz
' -e 's/$/"/' conf/system.not-properties $) $) ... java [script properties] $sysprops You still have the awful problem of quoting, though. - -chris > Le 28 déc. 2018 16:07, "Christopher Schultz" > a écrit : > > All, > > Someone asked this question on SO recently:

System properties: JVM launch versus catalina.properties

2018-12-28 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Someone asked this question on SO recently: https://stackoverflow.com/questions/53921375/tomcat-overriding-catalina- properties-from-commandline/53952396#53952396 TLDR: this person wants to set system properties in catalina.properties but be

Re: svn commit: r1849311 - in /tomcat/trunk: java/org/apache/catalina/startup/LocalStrings.properties java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/startup/TestTomcat.java weba

2018-12-20 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 12/19/18 14:14, Rémy Maucherat wrote: > On Wed, Dec 19, 2018 at 5:13 PM wrote: > >> Author: markt Date: Wed Dec 19 16:13:46 2018 New Revision: >> 1849311 >> >> URL: http://svn.apache.org/viewvc?rev=1849311=rev Log: Fix >>

Re: [VOTE] Release Apache Tomcat 8.5.37

2018-12-17 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Thanks for volunteering to RM this release. Sigs are correct. Unit test failure is environmental in nature. +1 to release STABLE 8.5.37 - -chris On 12/16/18 11:02, Christopher Schultz wrote: > All, > > On 12/12/18 08:22, Mark Tho

Re: [VOTE] Release Apache Tomcat 8.5.37

2018-12-17 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 12/17/18 11:37, Mark Thomas wrote: > On 17/12/2018 16:21, Christopher Schultz wrote: > > > >> 16-Dec-2018 11:01:04.189 INFO [main] >> org.apache.catalina.tribes.transport.ReceiverBase.bind Unable to >>

Re: [VOTE] Release Apache Tomcat 8.5.37

2018-12-17 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 12/17/18 05:49, Mark Thomas wrote: > On 16/12/2018 16:02, Christopher Schultz wrote: > > > >> I've got a signature problem with the Windows installer (see >> below). Everything else seems okay. I'll hold my +1 u

Re: [Bug 63009] Content-Length header is dropped when HTTP2 is used

2018-12-16 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 12/14/18 17:05, Caldarale, Charles R wrote: >> From: Christopher Schultz [mailto:ch...@christopherschultz.net] >> Subject: Re: [Bug 63009] Content-Length header is dropped when >> HTTP2 is > used > >> Is

Re: [VOTE] Release Apache Tomcat 8.5.37

2018-12-16 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 12/12/18 08:22, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.37 release is now available for > voting. > > The major changes compared to the 8.5.35 release are: > > - Implement the requirements of section 8.2.2 2.c of the Servlet

Re: [Bug 63009] Content-Length header is dropped when HTTP2 is used

2018-12-14 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Is this bad enough to pull and re-roll the latest 8.5.x release? Missing Content-Type is ... pretty bad. - -chris On 12/14/18 12:39, bugzi...@apache.org wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=63009 > > Mark Thomas changed:

Re: svn commit: r1848810 - in /tomcat/trunk: java/javax/servlet/http/HttpServlet.java test/javax/servlet/http/TestHttpServlet.java webapps/docs/changelog.xml

2018-12-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 12/12/18 18:26, Mark Thomas wrote: > On 12/12/2018 23:25, ma...@apache.org wrote: >> Author: markt Date: Wed Dec 12 23:25:39 2018 New Revision: >> 1848810 >> >> URL: http://svn.apache.org/viewvc?rev=1848810=rev Log: >> Ensure that the

Re: svn commit: r1848806 - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/jasper/ org/apache/jasper/compiler/ org/apache/jasper/resources/ org/apache/jasper/runtime/ or

2018-12-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 12/12/18 17:42, Rémy Maucherat wrote: > On Wed, Dec 12, 2018 at 11:29 PM wrote: > >> Author: remm Date: Wed Dec 12 22:29:52 2018 New Revision: >> 1848806 >> >> URL: http://svn.apache.org/viewvc?rev=1848806=rev Log: Add >> i18n for

Re: Time for 8.5.36?

2018-12-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Just confirming that I did indeed send the below message. I was having a problem with gpg-agent on my laptop and getting really weird errors when attempting to sign the message. Thanks, - -chris On 12/11/18 22:57, Christopher Schultz wrote

Re: Time for 8.5.36?

2018-12-11 Thread Christopher Schultz
All, On 12/11/18 08:21, Mark Thomas wrote: > Chris, > > Are you still interested in being RM for this? I don't think I'm quite ready to take over for 8.5.36, but I would like to work towards it. I haven't been able to get the build to run 100% in my Windows VM yet. This time around, I'll see

Re: svn commit: r1847854 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

2018-12-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/30/18 15:59, ma...@apache.org wrote: > Author: markt Date: Fri Nov 30 20:59:37 2018 New Revision: 1847854 > > URL: http://svn.apache.org/viewvc?rev=1847854=rev Log: > Clean-up file created during test It was actually intentional to

Re: Tagging Tomcat Native 1.2.19

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/29/18 16:29, Mark Thomas wrote: > I think the issues are resolved now so I plan to review the > current state of the code and then tag either later today or early > tomorrow. +1 - -chris -BEGIN PGP SIGNATURE- Comment: Using

Re: svn commit: r1847714 - /tomcat/native/trunk/native/src/sslconf.c

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Jean-Frederic, On 11/29/18 12:18, jean-frederic clere wrote: > On 29/11/2018 18:13, Christopher Schultz wrote: >> Jean-Frederic, >> >> On 11/29/18 08:06, jfcl...@apache.org wrote: >>> Author: jfclere Date: Thu Nov

Re: Current problems with TLS 1.0 and NIO(2)+native+openssl 1.1.1

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 11/29/18 08:27, Rémy Maucherat wrote: > On Sun, Nov 25, 2018 at 10:42 AM Rainer Jung > wrote: > >> In our Java code, what happens is a call to unwrap() in >> OpenSSLEngine. This call writes I think 146 bytes, then checks >>

Re: svn commit: r1847714 - /tomcat/native/trunk/native/src/sslconf.c

2018-11-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Jean-Frederic, On 11/29/18 08:06, jfcl...@apache.org wrote: > Author: jfclere Date: Thu Nov 29 13:06:21 2018 New Revision: > 1847714 > > URL: http://svn.apache.org/viewvc?rev=1847714=rev Log: Allow > to compile with

Re: svn commit: r1847636 - /tomcat/trunk/java/org/apache/catalina/core/StandardServer.java

2018-11-28 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 11/28/18 08:06, r...@apache.org wrote: > Author: remm Date: Wed Nov 28 13:06:09 2018 New Revision: 1847636 > > URL: http://svn.apache.org/viewvc?rev=1847636=rev Log: Fix > javadoc > > Modified: >

Re: Security of cluster's EncryptInterceptor

2018-11-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 11/20/18 14:02, Christopher Schultz wrote: > All, > > On 11/20/18 13:46, Christopher Schultz wrote: >> All, > >> I'd like a sanity-check on something I've done for the >> EncryptIntercepto r. > >&g

Re: svn commit: r1847417 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java w

2018-11-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 11/26/18 11:19, Christopher Schultz wrote: > All, > > On 11/25/18 10:49, schu...@apache.org wrote: >> Author: schultz Date: Sun Nov 25 15:49:28 2018 New Revision: >> 1847417 > >> URL: http://svn.apache.org/v

Re: svn commit: r1847417 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java w

2018-11-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 11/25/18 10:49, schu...@apache.org wrote: > Author: schultz Date: Sun Nov 25 15:49:28 2018 New Revision: > 1847417 > > URL: http://svn.apache.org/viewvc?rev=1847417=rev Log: Add > support for GCM block cipher mode. It's possible that GCM

Re: svn commit: r1847326 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

2018-11-24 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/23/18 18:08, ma...@apache.org wrote: > Author: markt Date: Fri Nov 23 23:08:41 2018 New Revision: 1847326 > > URL: http://svn.apache.org/viewvc?rev=1847326=rev Log: Fix IDE > nags > > Modified: >

Re: svn commit: r1847318 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java w

2018-11-24 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/23/18 16:55, Mark Thomas wrote: > On 23/11/2018 21:18, schu...@apache.org wrote: >> Author: schultz Date: Fri Nov 23 21:18:48 2018 New Revision: >> 1847318 >> >> URL: http://svn.apache.org/viewvc?rev=1847318=rev Log: Fix >>

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/22/18 18:24, Mark Thomas wrote: > > > On 22/11/2018 23:05, Christopher Schultz wrote: >> On 11/22/18 17:52, Mark Thomas wrote: >>> On 22/11/2018 22:32, Christopher Schultz wrote: >>>>

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/22/18 17:52, Mark Thomas wrote: > On 22/11/2018 22:32, Christopher Schultz wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> Mark, >> >> On 11/22/18 16:43, Mark Thomas wrote: >>>

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 11/22/18 17:32, Christopher Schultz wrote: > Mark, > > On 11/22/18 16:43, Mark Thomas wrote: >> On 22/11/2018 19:17, Christopher Schultz wrote: >>> Mark, >>> >>> On 11/22/18 05:21, Mark Thomas wr

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/22/18 16:43, Mark Thomas wrote: > On 22/11/2018 19:17, Christopher Schultz wrote: >> Mark, >> >> On 11/22/18 05:21, Mark Thomas wrote: >>> On 21/11/2018 22:39, Christopher Schultz wrote: >>>>

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/22/18 05:21, Mark Thomas wrote: > On 21/11/2018 22:39, Christopher Schultz wrote: >> Mark, >> > > >>> I thought you were using CBC so a missing block (a message >>> being one or more bl

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/21/18 15:11, Mark Thomas wrote: > On 21/11/2018 19:43, Christopher Schultz wrote: >> Mark, >> >> On 11/21/18 11:51, Mark Thomas wrote: >>> On 21/11/2018 16:36, Mark Thomas wrote: >>>> On 21/11/

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/21/18 11:51, Mark Thomas wrote: > On 21/11/2018 16:36, Mark Thomas wrote: >> On 21/11/2018 15:37, Mark Thomas wrote: >>> On 21/11/2018 15:29, Christopher Schultz wrote: >>>> All, >>>> >&

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/21/18 11:36, Mark Thomas wrote: > On 21/11/2018 15:37, Mark Thomas wrote: >> On 21/11/2018 15:29, Christopher Schultz wrote: >>> All, >>> >>> With this last patch, I'm ready for a back-port to tc8

Re: svn commit: r1847118 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/

2018-11-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, With this last patch, I'm ready for a back-port to tc8.5.x, but I'm waiting for a user who is trying to get this working on tc9.0 to be successful. If anyone else can confirm that this is all working in a real cluster (dev/test is okay) then

Re: Parallel Classloader - Again

2018-11-20 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/20/18 12:50, Mark Thomas wrote: > On 20/11/2018 15:21, Andrew Carr wrote: >> Hello, >> >> We have been seeing some intermittent issues with the parallel >> classloader. I do not want to jump to any conclusions and say >> this is a

Re: Security of cluster's EncryptInterceptor

2018-11-20 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 11/20/18 13:46, Christopher Schultz wrote: > All, > > I'd like a sanity-check on something I've done for the > EncryptIntercepto r. > > I'm using CBC mode because any other mode makes no sense. Using > ECB mode

Security of cluster's EncryptInterceptor

2018-11-20 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I'd like a sanity-check on something I've done for the EncryptIntercepto r. I'm using CBC mode because any other mode makes no sense. Using ECB mode isn't evasive enough and the more elaborate ones require that both sides (encrypt/decrypt)

Re: AccessLogValve using STDOUT

2018-11-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Romain, On 11/11/18 05:57, Romain Manni-Bucau wrote: > I think the perf point is likely wrong. Default JUL handlers are > "slow" (the hypothesis being you log a lot but this is more > comparatively to others frameworks) but if you switch the

Re: JDK 12 , JDK 8u202 & Project Panama Early-Access builds available

2018-11-10 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 11/9/18 07:38, Mark Thomas wrote: > On 09/11/2018 10:57, Rory O'Donnell wrote: > > > >> *Project Panama Early-Access build 0 ***is available at : - >> http://jdk.java.net/panama/ > > This looks interesting. If I am reading the

Re: [OT] L10n / I18n

2018-11-10 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I've tried to post to this thread a few times, but I never see the messages arriving on the list. Moderated? They do include a two HTTP URLs, but that hasn't seemed to stop messages in the past... Thanks, - -chris On 11/8/18 17:30, Emmanuel

Re: L10n / I18n

2018-11-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/7/18 5:36 PM, Mark Thomas wrote: > Hi, > > After looking at bug 62843, I got thinking about tools to help > manage translations from contributors. Something that would show > the key, the original value and the translated value side by

L10n / I18n

2018-11-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, (Looks like this message wasn't delivered the first time) On 11/7/18 5:36 PM, Mark Thomas wrote: > Hi, > > After looking at bug 62843, I got thinking about tools to help > manage translations from contributors. Something that would show >

Re: Release script for Tomcat 8.5.x

2018-11-08 Thread Christopher Schultz
. If so, I'm pretty happy with the results :) Thanks, - -chris On 11/6/18 5:50 PM, Christopher Schultz wrote: > All, > > I've been working this afternoon on a Powershell script to do > pretty much everything for a release. I chose Powershell because > (a) I will have to ope

Re: Release script for Tomcat 8.5.x

2018-11-07 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Emmanuel, On 11/7/18 08:09, Emmanuel Bourg wrote: > Le 07/11/2018 à 10:28, Konstantin Kolinko a écrit : > >> If I cannot do something with a batch script, I write a shell >> (bash) script and run it with git-bash from Git for Windows. > > There

Re: Release script for Tomcat 8.5.x

2018-11-07 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Chuck, On 11/6/18 22:40, Caldarale, Charles R wrote: >> From: Christopher Schultz [mailto:ch...@christopherschultz.net] >> Subject: Release script for Tomcat 8.5.x > >> It's downloading everything it needs (except

Re: Release script for Tomcat 8.5.x

2018-11-07 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Konstantin, On 11/7/18 04:28, Konstantin Kolinko wrote: > ср, 7 нояб. 2018 г. в 1:50, Christopher Schultz > : >> All, >> >> I've been working this afternoon on a Powershell script to do >> pretty much everything for

Release script for Tomcat 8.5.x

2018-11-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I've been working this afternoon on a Powershell script to do pretty much everything for a release. I chose Powershell because (a) I will have to operate on Windows for releases until I get NSIS working elsewhere and (b) batch scripts are The

Does there exist a download URL that will redirect me to a mirror?

2018-11-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Does ASF host a web service that I can hit that requests a download of a particular resource, but first to redirect to a mirror? If I go to e.g. https://tomcat.apache.org/download-90.cgi, I'll get a bunch of links that point to a

Re: Threads

2018-11-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 11/6/18 11:06 AM, Rémy Maucherat wrote: > On Tue, Nov 6, 2018 at 4:18 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> This reply is quite late, I'm sorry for that. >> >> I'm n

Re: Threads

2018-11-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 10/15/18 10:49, Rémy Maucherat wrote: > Hi, > > Looking at threads since there's a proliferation of executors and > loose threads, I notice a possible refactoring: - > start/stopExecutor is an obvious target, but by default is not >

Building (and running) Tomcat on MacOS

2018-11-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Periodically, some folks ask how to get Tomcat running on MacOS. In order to fully-test the most recent version of Tomcat 8.5.x being voted on, I built a new environment on my Mac from scratch and documented everything. I put all of my notes

Re: [VOTE] Release Apache Tomcat 8.5.35

2018-11-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/6/18 09:22, Mark Thomas wrote: > On 06/11/2018 14:14, Christopher Schultz wrote: >> Emmanuel, >> >> On 11/6/18 09:00, Emmanuel Bourg wrote: >>> Le 06/11/2018 à 12:44, Mark Thomas a écrit

Re: [VOTE] Release Apache Tomcat 8.5.35

2018-11-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Emmanuel, On 11/6/18 09:00, Emmanuel Bourg wrote: > Le 06/11/2018 à 12:44, Mark Thomas a écrit : > >> Should be fixed now. > >> There were some robustness fixes in 9.0.x that had not been >> back-ported. I've just done that. > > I confirm it

Re: libtcnative w/custom OpenSSL on MacOS

2018-11-06 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/5/18 17:32, Mark Thomas wrote: > On 05/11/2018 19:48, Christopher Schultz wrote: >> On 11/5/18 13:05, Rainer Jung wrote: >>> Am 05.11.2018 um 18:44 schrieb Christopher Schultz: > > > >>>> What

Re: libtcnative w/custom OpenSSL on MacOS

2018-11-05 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 11/5/18 13:05, Rainer Jung wrote: > Hi Chris, > > Am 05.11.2018 um 18:44 schrieb Christopher Schultz: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> All, >> >> I'm trying to run tests locally

libtcnative w/custom OpenSSL on MacOS

2018-11-05 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I'm trying to run tests locally (macos mojave) with a custom openssl version. I have OpenSSL (installed via brew) in /usr/local/Cellar/openssl@1.1/1.1.1, and I've copied all these files into my Tomcat's bin/ directory, so this is what I have

Re: [VOTE] Release Apache Tomcat 8.5.35

2018-11-05 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/3/18 13:55, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.35 release is now available for > voting. > > The major changes compared to the 8.5.34 release are: > > - support for TLSv1.3 when used with a JRE or OpenSSl version that

Re: [GitHub] tomcat issue #131: qqq

2018-11-05 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/5/18 09:59, markt-asf wrote: > Github user markt-asf commented on the issue: > > https://github.com/apache/tomcat/pull/131 > > Spam. Reported to GitHub's abuse team. I went in to see if I could kill it myself. My GitHub id is

Re: Release Manager for 8.5.x

2018-11-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/2/18 10:04, Mark Thomas wrote: > On 02/11/2018 12:59, Christopher Schultz wrote: >> All, >> >> I'd like to volunteer to RM for the 8.5.x series. > > Excellent. > >> At ApacheCon in Montréal, markt

Re: Release Manager for 8.5.x

2018-11-02 Thread Christopher Schultz
nick rbowen sctemme Also, should I create a new subkey of my current key[1] for signing-only, or should I create a completely new key for signing-only? Thanks, - -chris [1] https://pgp.mit.edu/pks/lookup?op=vindex=0xF3AD5C94A67F707E On 11/2/18 08:59, Christopher Schultz wrote: > All, >

Release Manager for 8.5.x

2018-11-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I'd like to volunteer to RM for the 8.5.x series. At ApacheCon in Montréal, markt indicated that he would certainly appreciate someone taking-over the great work that he has been doing as RM since the very first 8.5.x release. It's going to

Re: Mime types

2018-11-01 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 10/31/18 12:37, Rémy Maucherat wrote: > There are two main contraptions in Tomcat that do (badly ...) > extension to mime type mapping: the shared web.xml and some > hardcoded stuff in startup.Tomcat. It would probably be good to unify

Re: svn commit: r1845162 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-10-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 10/29/18 14:40, Mark Thomas wrote: > On 29/10/2018 18:40, ma...@apache.org wrote: >> Author: markt Date: Mon Oct 29 18:40:16 2018 New Revision: >> 1845162 >> >> URL: http://svn.apache.org/viewvc?rev=1845162=rev Log: Fix >> redundant

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy et al, On 10/25/18 11:54, Rémy Maucherat wrote: > On Thu, Oct 25, 2018 at 5:15 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> All,

  1   2   3   4   5   6   7   8   9   10   >